USB: ehci-fsl: Use usb_put_transceiver instead of put_device
authorJarkko Nikula <jarkko.nikula@bitmer.com>
Sun, 13 May 2012 18:10:20 +0000 (21:10 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 14 May 2012 15:49:50 +0000 (08:49 -0700)
Currently usb_put_transceiver calls put_device so this is a no-op but it
is better to keep API usage consistent as ehci->transceiver is allocated
with usb_get_transceiver.

While at there remove one extra ehci->transceiver test as the code block
has already tested it.

Signed-off-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/ehci-fsl.c

index 34acfcee740547a565bab20241ecc5cf68d738a5..43362577b54afb6f42530c9743474e9c3ffe028c 100644 (file)
@@ -150,8 +150,7 @@ static int usb_hcd_fsl_probe(const struct hc_driver *driver,
                        retval = otg_set_host(ehci->transceiver->otg,
                                              &ehci_to_hcd(ehci)->self);
                        if (retval) {
-                               if (ehci->transceiver)
-                                       put_device(ehci->transceiver->dev);
+                               usb_put_transceiver(ehci->transceiver);
                                goto err4;
                        }
                } else {
@@ -195,7 +194,7 @@ static void usb_hcd_fsl_remove(struct usb_hcd *hcd,
 
        if (ehci->transceiver) {
                otg_set_host(ehci->transceiver->otg, NULL);
-               put_device(ehci->transceiver->dev);
+               usb_put_transceiver(ehci->transceiver);
        }
 
        usb_remove_hcd(hcd);