qlge: Fix receive packets drop.
authorManish Chopra <manish.chopra@qlogic.com>
Tue, 15 Mar 2016 11:13:45 +0000 (07:13 -0400)
committerWilly Tarreau <w@1wt.eu>
Tue, 7 Jun 2016 08:42:49 +0000 (10:42 +0200)
commit 2c9a266afefe137bff06bbe0fc48b4d3b3cb348c upstream.

When running small packets [length < 256 bytes] traffic, packets were
being dropped due to invalid data in those packets which were
delivered by the driver upto the stack. Using pci_dma_sync_single_for_cpu
ensures copying latest and updated data into skb from the receive buffer.

Signed-off-by: Sony Chacko <sony.chacko@qlogic.com>
Signed-off-by: Manish Chopra <manish.chopra@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/net/ethernet/qlogic/qlge/qlge_main.c

index f87cc216045b5feb5e20dbc2f4df3fe2190eba14..a978cc2eafe07018e164545508850bec602f72c6 100644 (file)
@@ -1620,7 +1620,18 @@ static void ql_process_mac_rx_skb(struct ql_adapter *qdev,
                return;
        }
        skb_reserve(new_skb, NET_IP_ALIGN);
+
+       pci_dma_sync_single_for_cpu(qdev->pdev,
+                                   dma_unmap_addr(sbq_desc, mapaddr),
+                                   dma_unmap_len(sbq_desc, maplen),
+                                   PCI_DMA_FROMDEVICE);
+
        memcpy(skb_put(new_skb, length), skb->data, length);
+
+       pci_dma_sync_single_for_device(qdev->pdev,
+                                      dma_unmap_addr(sbq_desc, mapaddr),
+                                      dma_unmap_len(sbq_desc, maplen),
+                                      PCI_DMA_FROMDEVICE);
        skb = new_skb;
 
        /* Frame error, so drop the packet. */