kbuild: make $(checker-shell ) strip spaces around the result
authorLinus Torvalds <torvalds@woody.linux-foundation.org>
Thu, 8 Feb 2007 04:24:25 +0000 (20:24 -0800)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Thu, 8 Feb 2007 04:24:25 +0000 (20:24 -0800)
It looks like GNU make version 3.80 (but apparently not 3.81) adds
leading whitespace to the result of the checker-shell execution.  This
strips them off explicitly.

Also, don't bother symlinking the output file to /dev/null.  It's likely
as expensive as just writing the temp-file, and we need to remove it
anyway afterwards.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
scripts/Kbuild.include

index d65c40331e66193c731daaad592019569e4582af..8d7eabf238c05b104badc20af88c69fd52079ee7 100644 (file)
@@ -60,17 +60,16 @@ endef
 # Usage: option = $(call checker-shell,$(CC)...-o $$OUT,option-ok,otherwise)
 # Exit code chooses option. $$OUT is safe location for needless output.
 define checker-shell
+ $(strip
   $(shell set -e; \
     DIR=$(KBUILD_EXTMOD); \
     cd $${DIR:-$(objtree)}; \
     OUT=$$PWD/.$$$$.null; \
-    \
-    ln -s /dev/null $$OUT; \
     if $(1) >/dev/null 2>&1; \
       then echo "$(2)"; \
       else echo "$(3)"; \
     fi; \
-    rm -f $$OUT)
+    rm -f $$OUT))
 endef
 
 # as-option