mfd: omap-usb-tll: Check for missing platform data in probe
authorRoger Quadros <rogerq@ti.com>
Mon, 26 Nov 2012 13:17:32 +0000 (15:17 +0200)
committerRoger Quadros <rogerq@ti.com>
Wed, 13 Feb 2013 11:22:41 +0000 (13:22 +0200)
No need to check for missing platform data in runtime_suspend/resume
as it makes more sense to do it in the probe function.

Signed-off-by: Roger Quadros <rogerq@ti.com>
Reviewed-by: Felipe Balbi <balbi@ti.com>
drivers/mfd/omap-usb-tll.c

index af67b96ded0fa86fd73a14c4c1cb40f88b09aec4..3dbbfea515ad003dadadb71b240c2611b8b28496 100644 (file)
@@ -225,6 +225,11 @@ static int usbtll_omap_probe(struct platform_device *pdev)
                return -ENOMEM;
        }
 
+       if (!pdata) {
+               dev_err(dev, "Platform data missing\n");
+               return -ENODEV;
+       }
+
        spin_lock_init(&tll->lock);
 
        tll->pdata = pdata;
@@ -368,11 +373,6 @@ static int usbtll_runtime_resume(struct device *dev)
 
        dev_dbg(dev, "usbtll_runtime_resume\n");
 
-       if (!pdata) {
-               dev_dbg(dev, "missing platform_data\n");
-               return  -ENODEV;
-       }
-
        spin_lock_irqsave(&tll->lock, flags);
 
        for (i = 0; i < tll->nch; i++) {
@@ -404,11 +404,6 @@ static int usbtll_runtime_suspend(struct device *dev)
 
        dev_dbg(dev, "usbtll_runtime_suspend\n");
 
-       if (!pdata) {
-               dev_dbg(dev, "missing platform_data\n");
-               return  -ENODEV;
-       }
-
        spin_lock_irqsave(&tll->lock, flags);
 
        for (i = 0; i < tll->nch; i++) {