veth: extend device features
authorEric Dumazet <edumazet@google.com>
Sat, 29 Dec 2012 16:26:10 +0000 (16:26 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 30 Dec 2012 10:31:59 +0000 (02:31 -0800)
veth is lacking most modern facilities, like SG, checksums, TSO.

It makes sense to extend dev->features to get them, or GRO aggregation
is defeated by a forced segmentation.

Reported-by: Andrew Vagin <avagin@parallels.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/veth.c

index c048f8d27bbf7e43a6ecd0148d1803cdb1515429..8b2e11238efadea62fc3624a086df82a5e6e846b 100644 (file)
@@ -238,6 +238,10 @@ static const struct net_device_ops veth_netdev_ops = {
        .ndo_set_mac_address = eth_mac_addr,
 };
 
+#define VETH_FEATURES (NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_ALL_TSO |    \
+                      NETIF_F_HW_CSUM | NETIF_F_RXCSUM | NETIF_F_HIGHDMA | \
+                      NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX)
+
 static void veth_setup(struct net_device *dev)
 {
        ether_setup(dev);
@@ -248,9 +252,10 @@ static void veth_setup(struct net_device *dev)
        dev->netdev_ops = &veth_netdev_ops;
        dev->ethtool_ops = &veth_ethtool_ops;
        dev->features |= NETIF_F_LLTX;
+       dev->features |= VETH_FEATURES;
        dev->destructor = veth_dev_free;
 
-       dev->hw_features = NETIF_F_HW_CSUM | NETIF_F_SG | NETIF_F_RXCSUM;
+       dev->hw_features = VETH_FEATURES;
 }
 
 /*