mtd: block2mtd: throttle writes by calling balance_dirty_pages_ratelimited.
authorNeilBrown <neilb@suse.de>
Wed, 12 Dec 2012 08:32:15 +0000 (19:32 +1100)
committerArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
Thu, 13 Dec 2012 11:39:44 +0000 (13:39 +0200)
If you create a block2mtd device that is larger than main memory,
and write to all of it, then lots of pages will be dirtied but
they will never be flushed out as nothing calls any variant of
balance_dirty_pages.

It would be nice to call set_page_dirty_balance(), but that isn't exported,
so just call balance_dirty_pages_ratelimited() directly.

Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
drivers/mtd/devices/block2mtd.c

index 8debac9efde986b16b37a5586feb75fff5bf9f26..e081bfeaaf7da1941c9dc243856c3ab2ba9abde2 100644 (file)
@@ -62,6 +62,7 @@ static int _block2mtd_erase(struct block2mtd_dev *dev, loff_t to, size_t len)
                                memset(page_address(page), 0xff, PAGE_SIZE);
                                set_page_dirty(page);
                                unlock_page(page);
+                               balance_dirty_pages_ratelimited(mapping);
                                break;
                        }
 
@@ -152,6 +153,7 @@ static int _block2mtd_write(struct block2mtd_dev *dev, const u_char *buf,
                        memcpy(page_address(page) + offset, buf, cpylen);
                        set_page_dirty(page);
                        unlock_page(page);
+                       balance_dirty_pages_ratelimited(mapping);
                }
                page_cache_release(page);