ext4: remove lock_buffer in bclean() and setup_new_group_blocks()
[GitHub/mt8127/android_kernel_alcatel_ttab.git] / fs / ext4 / resize.c
CommitLineData
ac27a0ec 1/*
617ba13b 2 * linux/fs/ext4/resize.c
ac27a0ec 3 *
617ba13b 4 * Support for resizing an ext4 filesystem while it is mounted.
ac27a0ec
DK
5 *
6 * Copyright (C) 2001, 2002 Andreas Dilger <adilger@clusterfs.com>
7 *
8 * This could probably be made into a module, because it is not often in use.
9 */
10
11
617ba13b 12#define EXT4FS_DEBUG
ac27a0ec 13
ac27a0ec
DK
14#include <linux/errno.h>
15#include <linux/slab.h>
16
3dcf5451 17#include "ext4_jbd2.h"
ac27a0ec 18
8f82f840
YY
19int ext4_resize_begin(struct super_block *sb)
20{
21 int ret = 0;
22
23 if (!capable(CAP_SYS_RESOURCE))
24 return -EPERM;
25
ce723c31
YY
26 /*
27 * We are not allowed to do online-resizing on a filesystem mounted
28 * with error, because it can destroy the filesystem easily.
29 */
30 if (EXT4_SB(sb)->s_mount_state & EXT4_ERROR_FS) {
31 ext4_warning(sb, "There are errors in the filesystem, "
32 "so online resizing is not allowed\n");
33 return -EPERM;
34 }
35
8f82f840
YY
36 if (test_and_set_bit_lock(EXT4_RESIZING, &EXT4_SB(sb)->s_resize_flags))
37 ret = -EBUSY;
38
39 return ret;
40}
41
42void ext4_resize_end(struct super_block *sb)
43{
44 clear_bit_unlock(EXT4_RESIZING, &EXT4_SB(sb)->s_resize_flags);
45 smp_mb__after_clear_bit();
46}
47
ac27a0ec
DK
48#define outside(b, first, last) ((b) < (first) || (b) >= (last))
49#define inside(b, first, last) ((b) >= (first) && (b) < (last))
50
51static int verify_group_input(struct super_block *sb,
617ba13b 52 struct ext4_new_group_data *input)
ac27a0ec 53{
617ba13b
MC
54 struct ext4_sb_info *sbi = EXT4_SB(sb);
55 struct ext4_super_block *es = sbi->s_es;
bd81d8ee 56 ext4_fsblk_t start = ext4_blocks_count(es);
617ba13b 57 ext4_fsblk_t end = start + input->blocks_count;
fd2d4291 58 ext4_group_t group = input->group;
617ba13b
MC
59 ext4_fsblk_t itend = input->inode_table + sbi->s_itb_per_group;
60 unsigned overhead = ext4_bg_has_super(sb, group) ?
61 (1 + ext4_bg_num_gdb(sb, group) +
ac27a0ec 62 le16_to_cpu(es->s_reserved_gdt_blocks)) : 0;
617ba13b 63 ext4_fsblk_t metaend = start + overhead;
ac27a0ec 64 struct buffer_head *bh = NULL;
3a5b2ecd 65 ext4_grpblk_t free_blocks_count, offset;
ac27a0ec
DK
66 int err = -EINVAL;
67
68 input->free_blocks_count = free_blocks_count =
69 input->blocks_count - 2 - overhead - sbi->s_itb_per_group;
70
71 if (test_opt(sb, DEBUG))
617ba13b 72 printk(KERN_DEBUG "EXT4-fs: adding %s group %u: %u blocks "
ac27a0ec 73 "(%d free, %u reserved)\n",
617ba13b 74 ext4_bg_has_super(sb, input->group) ? "normal" :
ac27a0ec
DK
75 "no-super", input->group, input->blocks_count,
76 free_blocks_count, input->reserved_blocks);
77
3a5b2ecd 78 ext4_get_group_no_and_offset(sb, start, NULL, &offset);
ac27a0ec 79 if (group != sbi->s_groups_count)
12062ddd 80 ext4_warning(sb, "Cannot add at group %u (only %u groups)",
ac27a0ec 81 input->group, sbi->s_groups_count);
3a5b2ecd 82 else if (offset != 0)
12062ddd 83 ext4_warning(sb, "Last group not full");
ac27a0ec 84 else if (input->reserved_blocks > input->blocks_count / 5)
12062ddd 85 ext4_warning(sb, "Reserved blocks too high (%u)",
ac27a0ec
DK
86 input->reserved_blocks);
87 else if (free_blocks_count < 0)
12062ddd 88 ext4_warning(sb, "Bad blocks count %u",
ac27a0ec
DK
89 input->blocks_count);
90 else if (!(bh = sb_bread(sb, end - 1)))
12062ddd 91 ext4_warning(sb, "Cannot read last block (%llu)",
ac27a0ec
DK
92 end - 1);
93 else if (outside(input->block_bitmap, start, end))
12062ddd 94 ext4_warning(sb, "Block bitmap not in group (block %llu)",
1939e49a 95 (unsigned long long)input->block_bitmap);
ac27a0ec 96 else if (outside(input->inode_bitmap, start, end))
12062ddd 97 ext4_warning(sb, "Inode bitmap not in group (block %llu)",
1939e49a 98 (unsigned long long)input->inode_bitmap);
ac27a0ec 99 else if (outside(input->inode_table, start, end) ||
2b2d6d01 100 outside(itend - 1, start, end))
12062ddd 101 ext4_warning(sb, "Inode table not in group (blocks %llu-%llu)",
1939e49a 102 (unsigned long long)input->inode_table, itend - 1);
ac27a0ec 103 else if (input->inode_bitmap == input->block_bitmap)
12062ddd 104 ext4_warning(sb, "Block bitmap same as inode bitmap (%llu)",
1939e49a 105 (unsigned long long)input->block_bitmap);
ac27a0ec 106 else if (inside(input->block_bitmap, input->inode_table, itend))
12062ddd
ES
107 ext4_warning(sb, "Block bitmap (%llu) in inode table "
108 "(%llu-%llu)",
1939e49a
RD
109 (unsigned long long)input->block_bitmap,
110 (unsigned long long)input->inode_table, itend - 1);
ac27a0ec 111 else if (inside(input->inode_bitmap, input->inode_table, itend))
12062ddd
ES
112 ext4_warning(sb, "Inode bitmap (%llu) in inode table "
113 "(%llu-%llu)",
1939e49a
RD
114 (unsigned long long)input->inode_bitmap,
115 (unsigned long long)input->inode_table, itend - 1);
ac27a0ec 116 else if (inside(input->block_bitmap, start, metaend))
12062ddd 117 ext4_warning(sb, "Block bitmap (%llu) in GDT table (%llu-%llu)",
1939e49a
RD
118 (unsigned long long)input->block_bitmap,
119 start, metaend - 1);
ac27a0ec 120 else if (inside(input->inode_bitmap, start, metaend))
12062ddd 121 ext4_warning(sb, "Inode bitmap (%llu) in GDT table (%llu-%llu)",
1939e49a
RD
122 (unsigned long long)input->inode_bitmap,
123 start, metaend - 1);
ac27a0ec 124 else if (inside(input->inode_table, start, metaend) ||
2b2d6d01 125 inside(itend - 1, start, metaend))
12062ddd
ES
126 ext4_warning(sb, "Inode table (%llu-%llu) overlaps GDT table "
127 "(%llu-%llu)",
1939e49a
RD
128 (unsigned long long)input->inode_table,
129 itend - 1, start, metaend - 1);
ac27a0ec
DK
130 else
131 err = 0;
132 brelse(bh);
133
134 return err;
135}
136
137static struct buffer_head *bclean(handle_t *handle, struct super_block *sb,
617ba13b 138 ext4_fsblk_t blk)
ac27a0ec
DK
139{
140 struct buffer_head *bh;
141 int err;
142
143 bh = sb_getblk(sb, blk);
144 if (!bh)
145 return ERR_PTR(-EIO);
617ba13b 146 if ((err = ext4_journal_get_write_access(handle, bh))) {
ac27a0ec
DK
147 brelse(bh);
148 bh = ERR_PTR(err);
149 } else {
ac27a0ec
DK
150 memset(bh->b_data, 0, sb->s_blocksize);
151 set_buffer_uptodate(bh);
ac27a0ec
DK
152 }
153
154 return bh;
155}
156
14904107
ES
157/*
158 * If we have fewer than thresh credits, extend by EXT4_MAX_TRANS_DATA.
159 * If that fails, restart the transaction & regain write access for the
160 * buffer head which is used for block_bitmap modifications.
161 */
6d40bc5a 162static int extend_or_restart_transaction(handle_t *handle, int thresh)
14904107
ES
163{
164 int err;
165
0390131b 166 if (ext4_handle_has_enough_credits(handle, thresh))
14904107
ES
167 return 0;
168
169 err = ext4_journal_extend(handle, EXT4_MAX_TRANS_DATA);
170 if (err < 0)
171 return err;
172 if (err) {
6d40bc5a
YY
173 err = ext4_journal_restart(handle, EXT4_MAX_TRANS_DATA);
174 if (err)
14904107 175 return err;
2b2d6d01 176 }
14904107
ES
177
178 return 0;
179}
180
ac27a0ec
DK
181/*
182 * Set up the block and inode bitmaps, and the inode table for the new group.
183 * This doesn't need to be part of the main transaction, since we are only
184 * changing blocks outside the actual filesystem. We still do journaling to
185 * ensure the recovery is correct in case of a failure just after resize.
186 * If any part of this fails, we simply abort the resize.
187 */
188static int setup_new_group_blocks(struct super_block *sb,
617ba13b 189 struct ext4_new_group_data *input)
ac27a0ec 190{
617ba13b
MC
191 struct ext4_sb_info *sbi = EXT4_SB(sb);
192 ext4_fsblk_t start = ext4_group_first_block_no(sb, input->group);
193 int reserved_gdb = ext4_bg_has_super(sb, input->group) ?
ac27a0ec 194 le16_to_cpu(sbi->s_es->s_reserved_gdt_blocks) : 0;
617ba13b 195 unsigned long gdblocks = ext4_bg_num_gdb(sb, input->group);
ac27a0ec
DK
196 struct buffer_head *bh;
197 handle_t *handle;
617ba13b
MC
198 ext4_fsblk_t block;
199 ext4_grpblk_t bit;
ac27a0ec
DK
200 int i;
201 int err = 0, err2;
202
14904107
ES
203 /* This transaction may be extended/restarted along the way */
204 handle = ext4_journal_start_sb(sb, EXT4_MAX_TRANS_DATA);
205
ac27a0ec
DK
206 if (IS_ERR(handle))
207 return PTR_ERR(handle);
208
8f82f840 209 BUG_ON(input->group != sbi->s_groups_count);
ac27a0ec 210
ac27a0ec
DK
211 /* Copy all of the GDT blocks into the backup in this group */
212 for (i = 0, bit = 1, block = start + 1;
213 i < gdblocks; i++, block++, bit++) {
214 struct buffer_head *gdb;
215
c549a95d 216 ext4_debug("update backup group %#04llx (+%d)\n", block, bit);
6d40bc5a
YY
217 err = extend_or_restart_transaction(handle, 1);
218 if (err)
219 goto exit_journal;
14904107 220
ac27a0ec
DK
221 gdb = sb_getblk(sb, block);
222 if (!gdb) {
223 err = -EIO;
6d40bc5a 224 goto exit_journal;
ac27a0ec 225 }
617ba13b 226 if ((err = ext4_journal_get_write_access(handle, gdb))) {
ac27a0ec 227 brelse(gdb);
6d40bc5a 228 goto exit_journal;
ac27a0ec 229 }
5b615287 230 memcpy(gdb->b_data, sbi->s_group_desc[i]->b_data, gdb->b_size);
ac27a0ec 231 set_buffer_uptodate(gdb);
b4097142
TT
232 err = ext4_handle_dirty_metadata(handle, NULL, gdb);
233 if (unlikely(err)) {
234 brelse(gdb);
6d40bc5a 235 goto exit_journal;
b4097142 236 }
ac27a0ec
DK
237 brelse(gdb);
238 }
239
240 /* Zero out all of the reserved backup group descriptor table blocks */
da488945 241 ext4_debug("clear inode table blocks %#04llx -> %#04lx\n",
a31437b8
LC
242 block, sbi->s_itb_per_group);
243 err = sb_issue_zeroout(sb, gdblocks + start + 1, reserved_gdb,
a107e5a3 244 GFP_NOFS);
a31437b8 245 if (err)
6d40bc5a
YY
246 goto exit_journal;
247
248 err = extend_or_restart_transaction(handle, 2);
249 if (err)
250 goto exit_journal;
251
252 bh = bclean(handle, sb, input->block_bitmap);
253 if (IS_ERR(bh)) {
254 err = PTR_ERR(bh);
255 goto exit_journal;
256 }
c3e94d1d
YY
257
258 if (ext4_bg_has_super(sb, input->group)) {
259 ext4_debug("mark backup group tables %#04llx (+0)\n", start);
260 ext4_set_bits(bh->b_data, 0, gdblocks + reserved_gdb + 1);
261 }
14904107 262
c549a95d 263 ext4_debug("mark block bitmap %#04llx (+%llu)\n", input->block_bitmap,
ac27a0ec 264 input->block_bitmap - start);
617ba13b 265 ext4_set_bit(input->block_bitmap - start, bh->b_data);
c549a95d 266 ext4_debug("mark inode bitmap %#04llx (+%llu)\n", input->inode_bitmap,
ac27a0ec 267 input->inode_bitmap - start);
617ba13b 268 ext4_set_bit(input->inode_bitmap - start, bh->b_data);
ac27a0ec
DK
269
270 /* Zero out all of the inode table blocks */
a31437b8 271 block = input->inode_table;
da488945 272 ext4_debug("clear inode table blocks %#04llx -> %#04lx\n",
a31437b8 273 block, sbi->s_itb_per_group);
a107e5a3 274 err = sb_issue_zeroout(sb, block, sbi->s_itb_per_group, GFP_NOFS);
a31437b8
LC
275 if (err)
276 goto exit_bh;
c3e94d1d
YY
277 ext4_set_bits(bh->b_data, input->inode_table - start,
278 sbi->s_itb_per_group);
14904107 279
14904107 280
61d08673
TT
281 ext4_mark_bitmap_end(input->blocks_count, sb->s_blocksize * 8,
282 bh->b_data);
b4097142
TT
283 err = ext4_handle_dirty_metadata(handle, NULL, bh);
284 if (unlikely(err)) {
285 ext4_std_error(sb, err);
286 goto exit_bh;
287 }
ac27a0ec 288 brelse(bh);
ac27a0ec 289 /* Mark unused entries in inode bitmap used */
c549a95d 290 ext4_debug("clear inode bitmap %#04llx (+%llu)\n",
ac27a0ec
DK
291 input->inode_bitmap, input->inode_bitmap - start);
292 if (IS_ERR(bh = bclean(handle, sb, input->inode_bitmap))) {
293 err = PTR_ERR(bh);
294 goto exit_journal;
295 }
296
61d08673
TT
297 ext4_mark_bitmap_end(EXT4_INODES_PER_GROUP(sb), sb->s_blocksize * 8,
298 bh->b_data);
b4097142
TT
299 err = ext4_handle_dirty_metadata(handle, NULL, bh);
300 if (unlikely(err))
301 ext4_std_error(sb, err);
ac27a0ec
DK
302exit_bh:
303 brelse(bh);
304
305exit_journal:
617ba13b 306 if ((err2 = ext4_journal_stop(handle)) && !err)
ac27a0ec
DK
307 err = err2;
308
309 return err;
310}
311
312/*
313 * Iterate through the groups which hold BACKUP superblock/GDT copies in an
617ba13b 314 * ext4 filesystem. The counters should be initialized to 1, 5, and 7 before
ac27a0ec
DK
315 * calling this for the first time. In a sparse filesystem it will be the
316 * sequence of powers of 3, 5, and 7: 1, 3, 5, 7, 9, 25, 27, 49, 81, ...
317 * For a non-sparse filesystem it will be every group: 1, 2, 3, 4, ...
318 */
617ba13b 319static unsigned ext4_list_backups(struct super_block *sb, unsigned *three,
ac27a0ec
DK
320 unsigned *five, unsigned *seven)
321{
322 unsigned *min = three;
323 int mult = 3;
324 unsigned ret;
325
617ba13b
MC
326 if (!EXT4_HAS_RO_COMPAT_FEATURE(sb,
327 EXT4_FEATURE_RO_COMPAT_SPARSE_SUPER)) {
ac27a0ec
DK
328 ret = *min;
329 *min += 1;
330 return ret;
331 }
332
333 if (*five < *min) {
334 min = five;
335 mult = 5;
336 }
337 if (*seven < *min) {
338 min = seven;
339 mult = 7;
340 }
341
342 ret = *min;
343 *min *= mult;
344
345 return ret;
346}
347
348/*
349 * Check that all of the backup GDT blocks are held in the primary GDT block.
350 * It is assumed that they are stored in group order. Returns the number of
351 * groups in current filesystem that have BACKUPS, or -ve error code.
352 */
353static int verify_reserved_gdb(struct super_block *sb,
354 struct buffer_head *primary)
355{
617ba13b 356 const ext4_fsblk_t blk = primary->b_blocknr;
fd2d4291 357 const ext4_group_t end = EXT4_SB(sb)->s_groups_count;
ac27a0ec
DK
358 unsigned three = 1;
359 unsigned five = 5;
360 unsigned seven = 7;
361 unsigned grp;
362 __le32 *p = (__le32 *)primary->b_data;
363 int gdbackups = 0;
364
617ba13b 365 while ((grp = ext4_list_backups(sb, &three, &five, &seven)) < end) {
bd81d8ee
LV
366 if (le32_to_cpu(*p++) !=
367 grp * EXT4_BLOCKS_PER_GROUP(sb) + blk){
12062ddd 368 ext4_warning(sb, "reserved GDT %llu"
2ae02107 369 " missing grp %d (%llu)",
ac27a0ec 370 blk, grp,
bd81d8ee
LV
371 grp *
372 (ext4_fsblk_t)EXT4_BLOCKS_PER_GROUP(sb) +
373 blk);
ac27a0ec
DK
374 return -EINVAL;
375 }
617ba13b 376 if (++gdbackups > EXT4_ADDR_PER_BLOCK(sb))
ac27a0ec
DK
377 return -EFBIG;
378 }
379
380 return gdbackups;
381}
382
383/*
384 * Called when we need to bring a reserved group descriptor table block into
385 * use from the resize inode. The primary copy of the new GDT block currently
386 * is an indirect block (under the double indirect block in the resize inode).
387 * The new backup GDT blocks will be stored as leaf blocks in this indirect
388 * block, in group order. Even though we know all the block numbers we need,
389 * we check to ensure that the resize inode has actually reserved these blocks.
390 *
391 * Don't need to update the block bitmaps because the blocks are still in use.
392 *
393 * We get all of the error cases out of the way, so that we are sure to not
394 * fail once we start modifying the data on disk, because JBD has no rollback.
395 */
396static int add_new_gdb(handle_t *handle, struct inode *inode,
617ba13b 397 struct ext4_new_group_data *input,
ac27a0ec
DK
398 struct buffer_head **primary)
399{
400 struct super_block *sb = inode->i_sb;
617ba13b
MC
401 struct ext4_super_block *es = EXT4_SB(sb)->s_es;
402 unsigned long gdb_num = input->group / EXT4_DESC_PER_BLOCK(sb);
403 ext4_fsblk_t gdblock = EXT4_SB(sb)->s_sbh->b_blocknr + 1 + gdb_num;
ac27a0ec
DK
404 struct buffer_head **o_group_desc, **n_group_desc;
405 struct buffer_head *dind;
406 int gdbackups;
617ba13b 407 struct ext4_iloc iloc;
ac27a0ec
DK
408 __le32 *data;
409 int err;
410
411 if (test_opt(sb, DEBUG))
412 printk(KERN_DEBUG
617ba13b 413 "EXT4-fs: ext4_add_new_gdb: adding group block %lu\n",
ac27a0ec
DK
414 gdb_num);
415
af5bc92d
TT
416 /*
417 * If we are not using the primary superblock/GDT copy don't resize,
2b2d6d01
TT
418 * because the user tools have no way of handling this. Probably a
419 * bad time to do it anyways.
420 */
617ba13b
MC
421 if (EXT4_SB(sb)->s_sbh->b_blocknr !=
422 le32_to_cpu(EXT4_SB(sb)->s_es->s_first_data_block)) {
12062ddd 423 ext4_warning(sb, "won't resize using backup superblock at %llu",
617ba13b 424 (unsigned long long)EXT4_SB(sb)->s_sbh->b_blocknr);
ac27a0ec
DK
425 return -EPERM;
426 }
427
428 *primary = sb_bread(sb, gdblock);
429 if (!*primary)
430 return -EIO;
431
432 if ((gdbackups = verify_reserved_gdb(sb, *primary)) < 0) {
433 err = gdbackups;
434 goto exit_bh;
435 }
436
617ba13b 437 data = EXT4_I(inode)->i_data + EXT4_DIND_BLOCK;
ac27a0ec
DK
438 dind = sb_bread(sb, le32_to_cpu(*data));
439 if (!dind) {
440 err = -EIO;
441 goto exit_bh;
442 }
443
444 data = (__le32 *)dind->b_data;
617ba13b 445 if (le32_to_cpu(data[gdb_num % EXT4_ADDR_PER_BLOCK(sb)]) != gdblock) {
12062ddd 446 ext4_warning(sb, "new group %u GDT block %llu not reserved",
ac27a0ec
DK
447 input->group, gdblock);
448 err = -EINVAL;
449 goto exit_dind;
450 }
451
b4097142
TT
452 err = ext4_journal_get_write_access(handle, EXT4_SB(sb)->s_sbh);
453 if (unlikely(err))
ac27a0ec
DK
454 goto exit_dind;
455
b4097142
TT
456 err = ext4_journal_get_write_access(handle, *primary);
457 if (unlikely(err))
ac27a0ec
DK
458 goto exit_sbh;
459
b4097142
TT
460 err = ext4_journal_get_write_access(handle, dind);
461 if (unlikely(err))
462 ext4_std_error(sb, err);
ac27a0ec 463
617ba13b 464 /* ext4_reserve_inode_write() gets a reference on the iloc */
b4097142
TT
465 err = ext4_reserve_inode_write(handle, inode, &iloc);
466 if (unlikely(err))
ac27a0ec
DK
467 goto exit_dindj;
468
469 n_group_desc = kmalloc((gdb_num + 1) * sizeof(struct buffer_head *),
216553c4 470 GFP_NOFS);
ac27a0ec
DK
471 if (!n_group_desc) {
472 err = -ENOMEM;
12062ddd 473 ext4_warning(sb,
ac27a0ec
DK
474 "not enough memory for %lu groups", gdb_num + 1);
475 goto exit_inode;
476 }
477
478 /*
479 * Finally, we have all of the possible failures behind us...
480 *
481 * Remove new GDT block from inode double-indirect block and clear out
482 * the new GDT block for use (which also "frees" the backup GDT blocks
483 * from the reserved inode). We don't need to change the bitmaps for
484 * these blocks, because they are marked as in-use from being in the
485 * reserved inode, and will become GDT blocks (primary and backup).
486 */
617ba13b 487 data[gdb_num % EXT4_ADDR_PER_BLOCK(sb)] = 0;
b4097142
TT
488 err = ext4_handle_dirty_metadata(handle, NULL, dind);
489 if (unlikely(err)) {
490 ext4_std_error(sb, err);
491 goto exit_inode;
492 }
ac27a0ec 493 inode->i_blocks -= (gdbackups + 1) * sb->s_blocksize >> 9;
617ba13b 494 ext4_mark_iloc_dirty(handle, inode, &iloc);
ac27a0ec 495 memset((*primary)->b_data, 0, sb->s_blocksize);
b4097142
TT
496 err = ext4_handle_dirty_metadata(handle, NULL, *primary);
497 if (unlikely(err)) {
498 ext4_std_error(sb, err);
499 goto exit_inode;
500 }
501 brelse(dind);
ac27a0ec 502
617ba13b 503 o_group_desc = EXT4_SB(sb)->s_group_desc;
ac27a0ec 504 memcpy(n_group_desc, o_group_desc,
617ba13b 505 EXT4_SB(sb)->s_gdb_count * sizeof(struct buffer_head *));
ac27a0ec 506 n_group_desc[gdb_num] = *primary;
617ba13b
MC
507 EXT4_SB(sb)->s_group_desc = n_group_desc;
508 EXT4_SB(sb)->s_gdb_count++;
ac27a0ec
DK
509 kfree(o_group_desc);
510
e8546d06 511 le16_add_cpu(&es->s_reserved_gdt_blocks, -1);
b4097142
TT
512 err = ext4_handle_dirty_metadata(handle, NULL, EXT4_SB(sb)->s_sbh);
513 if (err)
514 ext4_std_error(sb, err);
ac27a0ec 515
b4097142 516 return err;
ac27a0ec
DK
517
518exit_inode:
537a0310 519 /* ext4_handle_release_buffer(handle, iloc.bh); */
ac27a0ec
DK
520 brelse(iloc.bh);
521exit_dindj:
537a0310 522 /* ext4_handle_release_buffer(handle, dind); */
ac27a0ec 523exit_sbh:
537a0310 524 /* ext4_handle_release_buffer(handle, EXT4_SB(sb)->s_sbh); */
ac27a0ec
DK
525exit_dind:
526 brelse(dind);
527exit_bh:
528 brelse(*primary);
529
617ba13b 530 ext4_debug("leaving with error %d\n", err);
ac27a0ec
DK
531 return err;
532}
533
534/*
535 * Called when we are adding a new group which has a backup copy of each of
536 * the GDT blocks (i.e. sparse group) and there are reserved GDT blocks.
537 * We need to add these reserved backup GDT blocks to the resize inode, so
538 * that they are kept for future resizing and not allocated to files.
539 *
540 * Each reserved backup GDT block will go into a different indirect block.
541 * The indirect blocks are actually the primary reserved GDT blocks,
542 * so we know in advance what their block numbers are. We only get the
543 * double-indirect block to verify it is pointing to the primary reserved
544 * GDT blocks so we don't overwrite a data block by accident. The reserved
545 * backup GDT blocks are stored in their reserved primary GDT block.
546 */
547static int reserve_backup_gdb(handle_t *handle, struct inode *inode,
617ba13b 548 struct ext4_new_group_data *input)
ac27a0ec
DK
549{
550 struct super_block *sb = inode->i_sb;
617ba13b 551 int reserved_gdb =le16_to_cpu(EXT4_SB(sb)->s_es->s_reserved_gdt_blocks);
ac27a0ec
DK
552 struct buffer_head **primary;
553 struct buffer_head *dind;
617ba13b
MC
554 struct ext4_iloc iloc;
555 ext4_fsblk_t blk;
ac27a0ec
DK
556 __le32 *data, *end;
557 int gdbackups = 0;
558 int res, i;
559 int err;
560
216553c4 561 primary = kmalloc(reserved_gdb * sizeof(*primary), GFP_NOFS);
ac27a0ec
DK
562 if (!primary)
563 return -ENOMEM;
564
617ba13b 565 data = EXT4_I(inode)->i_data + EXT4_DIND_BLOCK;
ac27a0ec
DK
566 dind = sb_bread(sb, le32_to_cpu(*data));
567 if (!dind) {
568 err = -EIO;
569 goto exit_free;
570 }
571
617ba13b 572 blk = EXT4_SB(sb)->s_sbh->b_blocknr + 1 + EXT4_SB(sb)->s_gdb_count;
94460093
JB
573 data = (__le32 *)dind->b_data + (EXT4_SB(sb)->s_gdb_count %
574 EXT4_ADDR_PER_BLOCK(sb));
617ba13b 575 end = (__le32 *)dind->b_data + EXT4_ADDR_PER_BLOCK(sb);
ac27a0ec
DK
576
577 /* Get each reserved primary GDT block and verify it holds backups */
578 for (res = 0; res < reserved_gdb; res++, blk++) {
579 if (le32_to_cpu(*data) != blk) {
12062ddd 580 ext4_warning(sb, "reserved block %llu"
ac27a0ec
DK
581 " not at offset %ld",
582 blk,
583 (long)(data - (__le32 *)dind->b_data));
584 err = -EINVAL;
585 goto exit_bh;
586 }
587 primary[res] = sb_bread(sb, blk);
588 if (!primary[res]) {
589 err = -EIO;
590 goto exit_bh;
591 }
592 if ((gdbackups = verify_reserved_gdb(sb, primary[res])) < 0) {
593 brelse(primary[res]);
594 err = gdbackups;
595 goto exit_bh;
596 }
597 if (++data >= end)
598 data = (__le32 *)dind->b_data;
599 }
600
601 for (i = 0; i < reserved_gdb; i++) {
617ba13b 602 if ((err = ext4_journal_get_write_access(handle, primary[i]))) {
ac27a0ec
DK
603 /*
604 int j;
605 for (j = 0; j < i; j++)
537a0310 606 ext4_handle_release_buffer(handle, primary[j]);
ac27a0ec
DK
607 */
608 goto exit_bh;
609 }
610 }
611
617ba13b 612 if ((err = ext4_reserve_inode_write(handle, inode, &iloc)))
ac27a0ec
DK
613 goto exit_bh;
614
615 /*
616 * Finally we can add each of the reserved backup GDT blocks from
617 * the new group to its reserved primary GDT block.
618 */
617ba13b 619 blk = input->group * EXT4_BLOCKS_PER_GROUP(sb);
ac27a0ec
DK
620 for (i = 0; i < reserved_gdb; i++) {
621 int err2;
622 data = (__le32 *)primary[i]->b_data;
623 /* printk("reserving backup %lu[%u] = %lu\n",
624 primary[i]->b_blocknr, gdbackups,
625 blk + primary[i]->b_blocknr); */
626 data[gdbackups] = cpu_to_le32(blk + primary[i]->b_blocknr);
0390131b 627 err2 = ext4_handle_dirty_metadata(handle, NULL, primary[i]);
ac27a0ec
DK
628 if (!err)
629 err = err2;
630 }
631 inode->i_blocks += reserved_gdb * sb->s_blocksize >> 9;
617ba13b 632 ext4_mark_iloc_dirty(handle, inode, &iloc);
ac27a0ec
DK
633
634exit_bh:
635 while (--res >= 0)
636 brelse(primary[res]);
637 brelse(dind);
638
639exit_free:
640 kfree(primary);
641
642 return err;
643}
644
645/*
617ba13b 646 * Update the backup copies of the ext4 metadata. These don't need to be part
ac27a0ec
DK
647 * of the main resize transaction, because e2fsck will re-write them if there
648 * is a problem (basically only OOM will cause a problem). However, we
649 * _should_ update the backups if possible, in case the primary gets trashed
650 * for some reason and we need to run e2fsck from a backup superblock. The
651 * important part is that the new block and inode counts are in the backup
652 * superblocks, and the location of the new group metadata in the GDT backups.
653 *
32ed5058
TT
654 * We do not need take the s_resize_lock for this, because these
655 * blocks are not otherwise touched by the filesystem code when it is
656 * mounted. We don't need to worry about last changing from
657 * sbi->s_groups_count, because the worst that can happen is that we
658 * do not copy the full number of backups at this time. The resize
659 * which changed s_groups_count will backup again.
ac27a0ec
DK
660 */
661static void update_backups(struct super_block *sb,
662 int blk_off, char *data, int size)
663{
617ba13b 664 struct ext4_sb_info *sbi = EXT4_SB(sb);
fd2d4291 665 const ext4_group_t last = sbi->s_groups_count;
617ba13b 666 const int bpg = EXT4_BLOCKS_PER_GROUP(sb);
ac27a0ec
DK
667 unsigned three = 1;
668 unsigned five = 5;
669 unsigned seven = 7;
fd2d4291 670 ext4_group_t group;
ac27a0ec
DK
671 int rest = sb->s_blocksize - size;
672 handle_t *handle;
673 int err = 0, err2;
674
617ba13b 675 handle = ext4_journal_start_sb(sb, EXT4_MAX_TRANS_DATA);
ac27a0ec
DK
676 if (IS_ERR(handle)) {
677 group = 1;
678 err = PTR_ERR(handle);
679 goto exit_err;
680 }
681
617ba13b 682 while ((group = ext4_list_backups(sb, &three, &five, &seven)) < last) {
ac27a0ec
DK
683 struct buffer_head *bh;
684
685 /* Out of journal space, and can't get more - abort - so sad */
0390131b
FM
686 if (ext4_handle_valid(handle) &&
687 handle->h_buffer_credits == 0 &&
617ba13b
MC
688 ext4_journal_extend(handle, EXT4_MAX_TRANS_DATA) &&
689 (err = ext4_journal_restart(handle, EXT4_MAX_TRANS_DATA)))
ac27a0ec
DK
690 break;
691
692 bh = sb_getblk(sb, group * bpg + blk_off);
693 if (!bh) {
694 err = -EIO;
695 break;
696 }
617ba13b 697 ext4_debug("update metadata backup %#04lx\n",
ac27a0ec 698 (unsigned long)bh->b_blocknr);
617ba13b 699 if ((err = ext4_journal_get_write_access(handle, bh)))
ac27a0ec
DK
700 break;
701 lock_buffer(bh);
702 memcpy(bh->b_data, data, size);
703 if (rest)
704 memset(bh->b_data + size, 0, rest);
705 set_buffer_uptodate(bh);
706 unlock_buffer(bh);
b4097142
TT
707 err = ext4_handle_dirty_metadata(handle, NULL, bh);
708 if (unlikely(err))
709 ext4_std_error(sb, err);
ac27a0ec
DK
710 brelse(bh);
711 }
617ba13b 712 if ((err2 = ext4_journal_stop(handle)) && !err)
ac27a0ec
DK
713 err = err2;
714
715 /*
716 * Ugh! Need to have e2fsck write the backup copies. It is too
717 * late to revert the resize, we shouldn't fail just because of
718 * the backup copies (they are only needed in case of corruption).
719 *
720 * However, if we got here we have a journal problem too, so we
721 * can't really start a transaction to mark the superblock.
722 * Chicken out and just set the flag on the hope it will be written
723 * to disk, and if not - we will simply wait until next fsck.
724 */
725exit_err:
726 if (err) {
12062ddd 727 ext4_warning(sb, "can't update backup for group %u (err %d), "
ac27a0ec 728 "forcing fsck on next reboot", group, err);
617ba13b
MC
729 sbi->s_mount_state &= ~EXT4_VALID_FS;
730 sbi->s_es->s_state &= cpu_to_le16(~EXT4_VALID_FS);
ac27a0ec
DK
731 mark_buffer_dirty(sbi->s_sbh);
732 }
733}
734
735/* Add group descriptor data to an existing or new group descriptor block.
736 * Ensure we handle all possible error conditions _before_ we start modifying
737 * the filesystem, because we cannot abort the transaction and not have it
738 * write the data to disk.
739 *
740 * If we are on a GDT block boundary, we need to get the reserved GDT block.
741 * Otherwise, we may need to add backup GDT blocks for a sparse group.
742 *
743 * We only need to hold the superblock lock while we are actually adding
744 * in the new group's counts to the superblock. Prior to that we have
745 * not really "added" the group at all. We re-check that we are still
746 * adding in the last group in case things have changed since verifying.
747 */
617ba13b 748int ext4_group_add(struct super_block *sb, struct ext4_new_group_data *input)
ac27a0ec 749{
617ba13b
MC
750 struct ext4_sb_info *sbi = EXT4_SB(sb);
751 struct ext4_super_block *es = sbi->s_es;
752 int reserved_gdb = ext4_bg_has_super(sb, input->group) ?
ac27a0ec
DK
753 le16_to_cpu(es->s_reserved_gdt_blocks) : 0;
754 struct buffer_head *primary = NULL;
617ba13b 755 struct ext4_group_desc *gdp;
ac27a0ec
DK
756 struct inode *inode = NULL;
757 handle_t *handle;
758 int gdb_off, gdb_num;
759 int err, err2;
760
617ba13b
MC
761 gdb_num = input->group / EXT4_DESC_PER_BLOCK(sb);
762 gdb_off = input->group % EXT4_DESC_PER_BLOCK(sb);
ac27a0ec 763
617ba13b
MC
764 if (gdb_off == 0 && !EXT4_HAS_RO_COMPAT_FEATURE(sb,
765 EXT4_FEATURE_RO_COMPAT_SPARSE_SUPER)) {
12062ddd 766 ext4_warning(sb, "Can't resize non-sparse filesystem further");
ac27a0ec
DK
767 return -EPERM;
768 }
769
bd81d8ee
LV
770 if (ext4_blocks_count(es) + input->blocks_count <
771 ext4_blocks_count(es)) {
12062ddd 772 ext4_warning(sb, "blocks_count overflow");
ac27a0ec
DK
773 return -EINVAL;
774 }
775
617ba13b 776 if (le32_to_cpu(es->s_inodes_count) + EXT4_INODES_PER_GROUP(sb) <
ac27a0ec 777 le32_to_cpu(es->s_inodes_count)) {
12062ddd 778 ext4_warning(sb, "inodes_count overflow");
ac27a0ec
DK
779 return -EINVAL;
780 }
781
782 if (reserved_gdb || gdb_off == 0) {
617ba13b 783 if (!EXT4_HAS_COMPAT_FEATURE(sb,
37609fd5
JB
784 EXT4_FEATURE_COMPAT_RESIZE_INODE)
785 || !le16_to_cpu(es->s_reserved_gdt_blocks)) {
12062ddd 786 ext4_warning(sb,
ac27a0ec
DK
787 "No reserved GDT blocks, can't resize");
788 return -EPERM;
789 }
1d1fe1ee
DH
790 inode = ext4_iget(sb, EXT4_RESIZE_INO);
791 if (IS_ERR(inode)) {
12062ddd 792 ext4_warning(sb, "Error opening resize inode");
1d1fe1ee 793 return PTR_ERR(inode);
ac27a0ec
DK
794 }
795 }
796
920313a7 797
ac27a0ec
DK
798 if ((err = verify_group_input(sb, input)))
799 goto exit_put;
800
801 if ((err = setup_new_group_blocks(sb, input)))
802 goto exit_put;
803
804 /*
805 * We will always be modifying at least the superblock and a GDT
806 * block. If we are adding a group past the last current GDT block,
807 * we will also modify the inode and the dindirect block. If we
808 * are adding a group with superblock/GDT backups we will also
809 * modify each of the reserved GDT dindirect blocks.
810 */
617ba13b
MC
811 handle = ext4_journal_start_sb(sb,
812 ext4_bg_has_super(sb, input->group) ?
ac27a0ec
DK
813 3 + reserved_gdb : 4);
814 if (IS_ERR(handle)) {
815 err = PTR_ERR(handle);
816 goto exit_put;
817 }
818
617ba13b 819 if ((err = ext4_journal_get_write_access(handle, sbi->s_sbh)))
ac27a0ec
DK
820 goto exit_journal;
821
2b2d6d01
TT
822 /*
823 * We will only either add reserved group blocks to a backup group
824 * or remove reserved blocks for the first group in a new group block.
825 * Doing both would be mean more complex code, and sane people don't
826 * use non-sparse filesystems anymore. This is already checked above.
827 */
ac27a0ec
DK
828 if (gdb_off) {
829 primary = sbi->s_group_desc[gdb_num];
617ba13b 830 if ((err = ext4_journal_get_write_access(handle, primary)))
ac27a0ec
DK
831 goto exit_journal;
832
617ba13b 833 if (reserved_gdb && ext4_bg_num_gdb(sb, input->group) &&
ac27a0ec
DK
834 (err = reserve_backup_gdb(handle, inode, input)))
835 goto exit_journal;
836 } else if ((err = add_new_gdb(handle, inode, input, &primary)))
837 goto exit_journal;
838
2b2d6d01
TT
839 /*
840 * OK, now we've set up the new group. Time to make it active.
841 *
2b2d6d01
TT
842 * so we have to be safe wrt. concurrent accesses the group
843 * data. So we need to be careful to set all of the relevant
844 * group descriptor data etc. *before* we enable the group.
845 *
846 * The key field here is sbi->s_groups_count: as long as
847 * that retains its old value, nobody is going to access the new
848 * group.
849 *
850 * So first we update all the descriptor metadata for the new
851 * group; then we update the total disk blocks count; then we
852 * update the groups count to enable the group; then finally we
853 * update the free space counts so that the system can start
854 * using the new disk blocks.
855 */
ac27a0ec
DK
856
857 /* Update group descriptor block for new group */
2856922c
FB
858 gdp = (struct ext4_group_desc *)((char *)primary->b_data +
859 gdb_off * EXT4_DESC_SIZE(sb));
ac27a0ec 860
fdff73f0 861 memset(gdp, 0, EXT4_DESC_SIZE(sb));
8fadc143
AR
862 ext4_block_bitmap_set(sb, gdp, input->block_bitmap); /* LV FIXME */
863 ext4_inode_bitmap_set(sb, gdp, input->inode_bitmap); /* LV FIXME */
864 ext4_inode_table_set(sb, gdp, input->inode_table); /* LV FIXME */
560671a0
AK
865 ext4_free_blks_set(sb, gdp, input->free_blocks_count);
866 ext4_free_inodes_set(sb, gdp, EXT4_INODES_PER_GROUP(sb));
fdff73f0 867 gdp->bg_flags = cpu_to_le16(EXT4_BG_INODE_ZEROED);
717d50e4 868 gdp->bg_checksum = ext4_group_desc_csum(sbi, input->group, gdp);
ac27a0ec 869
5f21b0e6
FB
870 /*
871 * We can allocate memory for mb_alloc based on the new group
872 * descriptor
873 */
920313a7 874 err = ext4_mb_add_groupinfo(sb, input->group, gdp);
08c3a813 875 if (err)
c2ea3fde
TT
876 goto exit_journal;
877
ac27a0ec
DK
878 /*
879 * Make the new blocks and inodes valid next. We do this before
880 * increasing the group count so that once the group is enabled,
881 * all of its blocks and inodes are already valid.
882 *
883 * We always allocate group-by-group, then block-by-block or
884 * inode-by-inode within a group, so enabling these
885 * blocks/inodes before the group is live won't actually let us
886 * allocate the new space yet.
887 */
bd81d8ee 888 ext4_blocks_count_set(es, ext4_blocks_count(es) +
ac27a0ec 889 input->blocks_count);
e8546d06 890 le32_add_cpu(&es->s_inodes_count, EXT4_INODES_PER_GROUP(sb));
ac27a0ec
DK
891
892 /*
893 * We need to protect s_groups_count against other CPUs seeing
894 * inconsistent state in the superblock.
895 *
896 * The precise rules we use are:
897 *
ac27a0ec
DK
898 * * Writers must perform a smp_wmb() after updating all dependent
899 * data and before modifying the groups count
900 *
ac27a0ec
DK
901 * * Readers must perform an smp_rmb() after reading the groups count
902 * and before reading any dependent data.
903 *
904 * NB. These rules can be relaxed when checking the group count
905 * while freeing data, as we can only allocate from a block
906 * group after serialising against the group count, and we can
907 * only then free after serialising in turn against that
908 * allocation.
909 */
910 smp_wmb();
911
912 /* Update the global fs size fields */
913 sbi->s_groups_count++;
914
b4097142
TT
915 err = ext4_handle_dirty_metadata(handle, NULL, primary);
916 if (unlikely(err)) {
917 ext4_std_error(sb, err);
918 goto exit_journal;
919 }
ac27a0ec
DK
920
921 /* Update the reserved block counts only once the new group is
922 * active. */
bd81d8ee 923 ext4_r_blocks_count_set(es, ext4_r_blocks_count(es) +
ac27a0ec
DK
924 input->reserved_blocks);
925
926 /* Update the free space counts */
aa0dff2d 927 percpu_counter_add(&sbi->s_freeblocks_counter,
ac27a0ec 928 input->free_blocks_count);
aa0dff2d 929 percpu_counter_add(&sbi->s_freeinodes_counter,
617ba13b 930 EXT4_INODES_PER_GROUP(sb));
ac27a0ec 931
42007efd
ES
932 if (EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_FLEX_BG) &&
933 sbi->s_log_groups_per_flex) {
c62a11fd
FB
934 ext4_group_t flex_group;
935 flex_group = ext4_flex_group(sbi, input->group);
9f24e420
TT
936 atomic_add(input->free_blocks_count,
937 &sbi->s_flex_groups[flex_group].free_blocks);
938 atomic_add(EXT4_INODES_PER_GROUP(sb),
939 &sbi->s_flex_groups[flex_group].free_inodes);
c62a11fd
FB
940 }
941
a0375156 942 ext4_handle_dirty_super(handle, sb);
ac27a0ec
DK
943
944exit_journal:
617ba13b 945 if ((err2 = ext4_journal_stop(handle)) && !err)
ac27a0ec
DK
946 err = err2;
947 if (!err) {
948 update_backups(sb, sbi->s_sbh->b_blocknr, (char *)es,
617ba13b 949 sizeof(struct ext4_super_block));
ac27a0ec
DK
950 update_backups(sb, primary->b_blocknr, primary->b_data,
951 primary->b_size);
952 }
953exit_put:
954 iput(inode);
955 return err;
617ba13b 956} /* ext4_group_add */
ac27a0ec 957
2b2d6d01
TT
958/*
959 * Extend the filesystem to the new number of blocks specified. This entry
ac27a0ec
DK
960 * point is only used to extend the current filesystem to the end of the last
961 * existing group. It can be accessed via ioctl, or by "remount,resize=<size>"
962 * for emergencies (because it has no dependencies on reserved blocks).
963 *
617ba13b 964 * If we _really_ wanted, we could use default values to call ext4_group_add()
ac27a0ec
DK
965 * allow the "remount" trick to work for arbitrary resizing, assuming enough
966 * GDT blocks are reserved to grow to the desired size.
967 */
617ba13b
MC
968int ext4_group_extend(struct super_block *sb, struct ext4_super_block *es,
969 ext4_fsblk_t n_blocks_count)
ac27a0ec 970{
617ba13b 971 ext4_fsblk_t o_blocks_count;
617ba13b
MC
972 ext4_grpblk_t last;
973 ext4_grpblk_t add;
af5bc92d 974 struct buffer_head *bh;
ac27a0ec 975 handle_t *handle;
cc7365df 976 int err, err2;
5f21b0e6 977 ext4_group_t group;
ac27a0ec 978
bd81d8ee 979 o_blocks_count = ext4_blocks_count(es);
ac27a0ec
DK
980
981 if (test_opt(sb, DEBUG))
2b79b09d 982 printk(KERN_DEBUG "EXT4-fs: extending last group from %llu to %llu blocks\n",
ac27a0ec
DK
983 o_blocks_count, n_blocks_count);
984
985 if (n_blocks_count == 0 || n_blocks_count == o_blocks_count)
986 return 0;
987
988 if (n_blocks_count > (sector_t)(~0ULL) >> (sb->s_blocksize_bits - 9)) {
617ba13b 989 printk(KERN_ERR "EXT4-fs: filesystem on %s:"
2ae02107 990 " too large to resize to %llu blocks safely\n",
ac27a0ec
DK
991 sb->s_id, n_blocks_count);
992 if (sizeof(sector_t) < 8)
12062ddd 993 ext4_warning(sb, "CONFIG_LBDAF not enabled");
ac27a0ec
DK
994 return -EINVAL;
995 }
996
997 if (n_blocks_count < o_blocks_count) {
12062ddd 998 ext4_warning(sb, "can't shrink FS - resize aborted");
8f82f840 999 return -EINVAL;
ac27a0ec
DK
1000 }
1001
1002 /* Handle the remaining blocks in the last group only. */
5f21b0e6 1003 ext4_get_group_no_and_offset(sb, o_blocks_count, &group, &last);
ac27a0ec
DK
1004
1005 if (last == 0) {
12062ddd 1006 ext4_warning(sb, "need to use ext2online to resize further");
ac27a0ec
DK
1007 return -EPERM;
1008 }
1009
617ba13b 1010 add = EXT4_BLOCKS_PER_GROUP(sb) - last;
ac27a0ec
DK
1011
1012 if (o_blocks_count + add < o_blocks_count) {
12062ddd 1013 ext4_warning(sb, "blocks_count overflow");
ac27a0ec
DK
1014 return -EINVAL;
1015 }
1016
1017 if (o_blocks_count + add > n_blocks_count)
1018 add = n_blocks_count - o_blocks_count;
1019
1020 if (o_blocks_count + add < n_blocks_count)
12062ddd 1021 ext4_warning(sb, "will only finish group (%llu blocks, %u new)",
ac27a0ec
DK
1022 o_blocks_count + add, add);
1023
1024 /* See if the device is actually as big as what was requested */
2b2d6d01 1025 bh = sb_bread(sb, o_blocks_count + add - 1);
ac27a0ec 1026 if (!bh) {
12062ddd 1027 ext4_warning(sb, "can't read last block, resize aborted");
ac27a0ec
DK
1028 return -ENOSPC;
1029 }
1030 brelse(bh);
1031
1032 /* We will update the superblock, one block bitmap, and
617ba13b 1033 * one group descriptor via ext4_free_blocks().
ac27a0ec 1034 */
617ba13b 1035 handle = ext4_journal_start_sb(sb, 3);
ac27a0ec
DK
1036 if (IS_ERR(handle)) {
1037 err = PTR_ERR(handle);
12062ddd 1038 ext4_warning(sb, "error %d on journal start", err);
ac27a0ec
DK
1039 goto exit_put;
1040 }
1041
617ba13b
MC
1042 if ((err = ext4_journal_get_write_access(handle,
1043 EXT4_SB(sb)->s_sbh))) {
12062ddd 1044 ext4_warning(sb, "error %d on journal write access", err);
617ba13b 1045 ext4_journal_stop(handle);
ac27a0ec
DK
1046 goto exit_put;
1047 }
bd81d8ee 1048 ext4_blocks_count_set(es, o_blocks_count + add);
c549a95d 1049 ext4_debug("freeing blocks %llu through %llu\n", o_blocks_count,
ac27a0ec 1050 o_blocks_count + add);
e21675d4 1051 /* We add the blocks to the bitmap and set the group need init bit */
cc7365df 1052 err = ext4_group_add_blocks(handle, sb, o_blocks_count, add);
a0375156 1053 ext4_handle_dirty_super(handle, sb);
2ae02107 1054 ext4_debug("freed blocks %llu through %llu\n", o_blocks_count,
ac27a0ec 1055 o_blocks_count + add);
cc7365df
YY
1056 err2 = ext4_journal_stop(handle);
1057 if (!err && err2)
1058 err = err2;
1059
1060 if (err)
ac27a0ec 1061 goto exit_put;
5f21b0e6 1062
ac27a0ec 1063 if (test_opt(sb, DEBUG))
bd81d8ee
LV
1064 printk(KERN_DEBUG "EXT4-fs: extended group to %llu blocks\n",
1065 ext4_blocks_count(es));
617ba13b
MC
1066 update_backups(sb, EXT4_SB(sb)->s_sbh->b_blocknr, (char *)es,
1067 sizeof(struct ext4_super_block));
ac27a0ec
DK
1068exit_put:
1069 return err;
617ba13b 1070} /* ext4_group_extend */