ext4: prevent parallel resizers by atomic bit ops
[GitHub/mt8127/android_kernel_alcatel_ttab.git] / fs / ext4 / resize.c
CommitLineData
ac27a0ec 1/*
617ba13b 2 * linux/fs/ext4/resize.c
ac27a0ec 3 *
617ba13b 4 * Support for resizing an ext4 filesystem while it is mounted.
ac27a0ec
DK
5 *
6 * Copyright (C) 2001, 2002 Andreas Dilger <adilger@clusterfs.com>
7 *
8 * This could probably be made into a module, because it is not often in use.
9 */
10
11
617ba13b 12#define EXT4FS_DEBUG
ac27a0ec 13
ac27a0ec
DK
14#include <linux/errno.h>
15#include <linux/slab.h>
16
3dcf5451 17#include "ext4_jbd2.h"
ac27a0ec 18
8f82f840
YY
19int ext4_resize_begin(struct super_block *sb)
20{
21 int ret = 0;
22
23 if (!capable(CAP_SYS_RESOURCE))
24 return -EPERM;
25
26 if (test_and_set_bit_lock(EXT4_RESIZING, &EXT4_SB(sb)->s_resize_flags))
27 ret = -EBUSY;
28
29 return ret;
30}
31
32void ext4_resize_end(struct super_block *sb)
33{
34 clear_bit_unlock(EXT4_RESIZING, &EXT4_SB(sb)->s_resize_flags);
35 smp_mb__after_clear_bit();
36}
37
ac27a0ec
DK
38#define outside(b, first, last) ((b) < (first) || (b) >= (last))
39#define inside(b, first, last) ((b) >= (first) && (b) < (last))
40
41static int verify_group_input(struct super_block *sb,
617ba13b 42 struct ext4_new_group_data *input)
ac27a0ec 43{
617ba13b
MC
44 struct ext4_sb_info *sbi = EXT4_SB(sb);
45 struct ext4_super_block *es = sbi->s_es;
bd81d8ee 46 ext4_fsblk_t start = ext4_blocks_count(es);
617ba13b 47 ext4_fsblk_t end = start + input->blocks_count;
fd2d4291 48 ext4_group_t group = input->group;
617ba13b
MC
49 ext4_fsblk_t itend = input->inode_table + sbi->s_itb_per_group;
50 unsigned overhead = ext4_bg_has_super(sb, group) ?
51 (1 + ext4_bg_num_gdb(sb, group) +
ac27a0ec 52 le16_to_cpu(es->s_reserved_gdt_blocks)) : 0;
617ba13b 53 ext4_fsblk_t metaend = start + overhead;
ac27a0ec 54 struct buffer_head *bh = NULL;
3a5b2ecd 55 ext4_grpblk_t free_blocks_count, offset;
ac27a0ec
DK
56 int err = -EINVAL;
57
58 input->free_blocks_count = free_blocks_count =
59 input->blocks_count - 2 - overhead - sbi->s_itb_per_group;
60
61 if (test_opt(sb, DEBUG))
617ba13b 62 printk(KERN_DEBUG "EXT4-fs: adding %s group %u: %u blocks "
ac27a0ec 63 "(%d free, %u reserved)\n",
617ba13b 64 ext4_bg_has_super(sb, input->group) ? "normal" :
ac27a0ec
DK
65 "no-super", input->group, input->blocks_count,
66 free_blocks_count, input->reserved_blocks);
67
3a5b2ecd 68 ext4_get_group_no_and_offset(sb, start, NULL, &offset);
ac27a0ec 69 if (group != sbi->s_groups_count)
12062ddd 70 ext4_warning(sb, "Cannot add at group %u (only %u groups)",
ac27a0ec 71 input->group, sbi->s_groups_count);
3a5b2ecd 72 else if (offset != 0)
12062ddd 73 ext4_warning(sb, "Last group not full");
ac27a0ec 74 else if (input->reserved_blocks > input->blocks_count / 5)
12062ddd 75 ext4_warning(sb, "Reserved blocks too high (%u)",
ac27a0ec
DK
76 input->reserved_blocks);
77 else if (free_blocks_count < 0)
12062ddd 78 ext4_warning(sb, "Bad blocks count %u",
ac27a0ec
DK
79 input->blocks_count);
80 else if (!(bh = sb_bread(sb, end - 1)))
12062ddd 81 ext4_warning(sb, "Cannot read last block (%llu)",
ac27a0ec
DK
82 end - 1);
83 else if (outside(input->block_bitmap, start, end))
12062ddd 84 ext4_warning(sb, "Block bitmap not in group (block %llu)",
1939e49a 85 (unsigned long long)input->block_bitmap);
ac27a0ec 86 else if (outside(input->inode_bitmap, start, end))
12062ddd 87 ext4_warning(sb, "Inode bitmap not in group (block %llu)",
1939e49a 88 (unsigned long long)input->inode_bitmap);
ac27a0ec 89 else if (outside(input->inode_table, start, end) ||
2b2d6d01 90 outside(itend - 1, start, end))
12062ddd 91 ext4_warning(sb, "Inode table not in group (blocks %llu-%llu)",
1939e49a 92 (unsigned long long)input->inode_table, itend - 1);
ac27a0ec 93 else if (input->inode_bitmap == input->block_bitmap)
12062ddd 94 ext4_warning(sb, "Block bitmap same as inode bitmap (%llu)",
1939e49a 95 (unsigned long long)input->block_bitmap);
ac27a0ec 96 else if (inside(input->block_bitmap, input->inode_table, itend))
12062ddd
ES
97 ext4_warning(sb, "Block bitmap (%llu) in inode table "
98 "(%llu-%llu)",
1939e49a
RD
99 (unsigned long long)input->block_bitmap,
100 (unsigned long long)input->inode_table, itend - 1);
ac27a0ec 101 else if (inside(input->inode_bitmap, input->inode_table, itend))
12062ddd
ES
102 ext4_warning(sb, "Inode bitmap (%llu) in inode table "
103 "(%llu-%llu)",
1939e49a
RD
104 (unsigned long long)input->inode_bitmap,
105 (unsigned long long)input->inode_table, itend - 1);
ac27a0ec 106 else if (inside(input->block_bitmap, start, metaend))
12062ddd 107 ext4_warning(sb, "Block bitmap (%llu) in GDT table (%llu-%llu)",
1939e49a
RD
108 (unsigned long long)input->block_bitmap,
109 start, metaend - 1);
ac27a0ec 110 else if (inside(input->inode_bitmap, start, metaend))
12062ddd 111 ext4_warning(sb, "Inode bitmap (%llu) in GDT table (%llu-%llu)",
1939e49a
RD
112 (unsigned long long)input->inode_bitmap,
113 start, metaend - 1);
ac27a0ec 114 else if (inside(input->inode_table, start, metaend) ||
2b2d6d01 115 inside(itend - 1, start, metaend))
12062ddd
ES
116 ext4_warning(sb, "Inode table (%llu-%llu) overlaps GDT table "
117 "(%llu-%llu)",
1939e49a
RD
118 (unsigned long long)input->inode_table,
119 itend - 1, start, metaend - 1);
ac27a0ec
DK
120 else
121 err = 0;
122 brelse(bh);
123
124 return err;
125}
126
127static struct buffer_head *bclean(handle_t *handle, struct super_block *sb,
617ba13b 128 ext4_fsblk_t blk)
ac27a0ec
DK
129{
130 struct buffer_head *bh;
131 int err;
132
133 bh = sb_getblk(sb, blk);
134 if (!bh)
135 return ERR_PTR(-EIO);
617ba13b 136 if ((err = ext4_journal_get_write_access(handle, bh))) {
ac27a0ec
DK
137 brelse(bh);
138 bh = ERR_PTR(err);
139 } else {
140 lock_buffer(bh);
141 memset(bh->b_data, 0, sb->s_blocksize);
142 set_buffer_uptodate(bh);
143 unlock_buffer(bh);
144 }
145
146 return bh;
147}
148
14904107
ES
149/*
150 * If we have fewer than thresh credits, extend by EXT4_MAX_TRANS_DATA.
151 * If that fails, restart the transaction & regain write access for the
152 * buffer head which is used for block_bitmap modifications.
153 */
154static int extend_or_restart_transaction(handle_t *handle, int thresh,
155 struct buffer_head *bh)
156{
157 int err;
158
0390131b 159 if (ext4_handle_has_enough_credits(handle, thresh))
14904107
ES
160 return 0;
161
162 err = ext4_journal_extend(handle, EXT4_MAX_TRANS_DATA);
163 if (err < 0)
164 return err;
165 if (err) {
166 if ((err = ext4_journal_restart(handle, EXT4_MAX_TRANS_DATA)))
167 return err;
2b2d6d01 168 if ((err = ext4_journal_get_write_access(handle, bh)))
14904107 169 return err;
2b2d6d01 170 }
14904107
ES
171
172 return 0;
173}
174
ac27a0ec
DK
175/*
176 * Set up the block and inode bitmaps, and the inode table for the new group.
177 * This doesn't need to be part of the main transaction, since we are only
178 * changing blocks outside the actual filesystem. We still do journaling to
179 * ensure the recovery is correct in case of a failure just after resize.
180 * If any part of this fails, we simply abort the resize.
181 */
182static int setup_new_group_blocks(struct super_block *sb,
617ba13b 183 struct ext4_new_group_data *input)
ac27a0ec 184{
617ba13b
MC
185 struct ext4_sb_info *sbi = EXT4_SB(sb);
186 ext4_fsblk_t start = ext4_group_first_block_no(sb, input->group);
187 int reserved_gdb = ext4_bg_has_super(sb, input->group) ?
ac27a0ec 188 le16_to_cpu(sbi->s_es->s_reserved_gdt_blocks) : 0;
617ba13b 189 unsigned long gdblocks = ext4_bg_num_gdb(sb, input->group);
ac27a0ec
DK
190 struct buffer_head *bh;
191 handle_t *handle;
617ba13b
MC
192 ext4_fsblk_t block;
193 ext4_grpblk_t bit;
ac27a0ec
DK
194 int i;
195 int err = 0, err2;
196
14904107
ES
197 /* This transaction may be extended/restarted along the way */
198 handle = ext4_journal_start_sb(sb, EXT4_MAX_TRANS_DATA);
199
ac27a0ec
DK
200 if (IS_ERR(handle))
201 return PTR_ERR(handle);
202
8f82f840 203 BUG_ON(input->group != sbi->s_groups_count);
ac27a0ec
DK
204
205 if (IS_ERR(bh = bclean(handle, sb, input->block_bitmap))) {
206 err = PTR_ERR(bh);
207 goto exit_journal;
208 }
209
617ba13b 210 if (ext4_bg_has_super(sb, input->group)) {
c549a95d 211 ext4_debug("mark backup superblock %#04llx (+0)\n", start);
617ba13b 212 ext4_set_bit(0, bh->b_data);
ac27a0ec
DK
213 }
214
215 /* Copy all of the GDT blocks into the backup in this group */
216 for (i = 0, bit = 1, block = start + 1;
217 i < gdblocks; i++, block++, bit++) {
218 struct buffer_head *gdb;
219
c549a95d 220 ext4_debug("update backup group %#04llx (+%d)\n", block, bit);
ac27a0ec 221
14904107
ES
222 if ((err = extend_or_restart_transaction(handle, 1, bh)))
223 goto exit_bh;
224
ac27a0ec
DK
225 gdb = sb_getblk(sb, block);
226 if (!gdb) {
227 err = -EIO;
228 goto exit_bh;
229 }
617ba13b 230 if ((err = ext4_journal_get_write_access(handle, gdb))) {
ac27a0ec
DK
231 brelse(gdb);
232 goto exit_bh;
233 }
5b615287
ES
234 lock_buffer(gdb);
235 memcpy(gdb->b_data, sbi->s_group_desc[i]->b_data, gdb->b_size);
ac27a0ec 236 set_buffer_uptodate(gdb);
5b615287 237 unlock_buffer(gdb);
b4097142
TT
238 err = ext4_handle_dirty_metadata(handle, NULL, gdb);
239 if (unlikely(err)) {
240 brelse(gdb);
241 goto exit_bh;
242 }
617ba13b 243 ext4_set_bit(bit, bh->b_data);
ac27a0ec
DK
244 brelse(gdb);
245 }
246
247 /* Zero out all of the reserved backup group descriptor table blocks */
da488945 248 ext4_debug("clear inode table blocks %#04llx -> %#04lx\n",
a31437b8
LC
249 block, sbi->s_itb_per_group);
250 err = sb_issue_zeroout(sb, gdblocks + start + 1, reserved_gdb,
a107e5a3 251 GFP_NOFS);
a31437b8
LC
252 if (err)
253 goto exit_bh;
8a7411a2
TT
254 for (i = 0, bit = gdblocks + 1; i < reserved_gdb; i++, bit++)
255 ext4_set_bit(bit, bh->b_data);
14904107 256
c549a95d 257 ext4_debug("mark block bitmap %#04llx (+%llu)\n", input->block_bitmap,
ac27a0ec 258 input->block_bitmap - start);
617ba13b 259 ext4_set_bit(input->block_bitmap - start, bh->b_data);
c549a95d 260 ext4_debug("mark inode bitmap %#04llx (+%llu)\n", input->inode_bitmap,
ac27a0ec 261 input->inode_bitmap - start);
617ba13b 262 ext4_set_bit(input->inode_bitmap - start, bh->b_data);
ac27a0ec
DK
263
264 /* Zero out all of the inode table blocks */
a31437b8 265 block = input->inode_table;
da488945 266 ext4_debug("clear inode table blocks %#04llx -> %#04lx\n",
a31437b8 267 block, sbi->s_itb_per_group);
a107e5a3 268 err = sb_issue_zeroout(sb, block, sbi->s_itb_per_group, GFP_NOFS);
a31437b8
LC
269 if (err)
270 goto exit_bh;
8a7411a2
TT
271 for (i = 0, bit = input->inode_table - start;
272 i < sbi->s_itb_per_group; i++, bit++)
273 ext4_set_bit(bit, bh->b_data);
14904107
ES
274
275 if ((err = extend_or_restart_transaction(handle, 2, bh)))
276 goto exit_bh;
277
61d08673
TT
278 ext4_mark_bitmap_end(input->blocks_count, sb->s_blocksize * 8,
279 bh->b_data);
b4097142
TT
280 err = ext4_handle_dirty_metadata(handle, NULL, bh);
281 if (unlikely(err)) {
282 ext4_std_error(sb, err);
283 goto exit_bh;
284 }
ac27a0ec 285 brelse(bh);
ac27a0ec 286 /* Mark unused entries in inode bitmap used */
c549a95d 287 ext4_debug("clear inode bitmap %#04llx (+%llu)\n",
ac27a0ec
DK
288 input->inode_bitmap, input->inode_bitmap - start);
289 if (IS_ERR(bh = bclean(handle, sb, input->inode_bitmap))) {
290 err = PTR_ERR(bh);
291 goto exit_journal;
292 }
293
61d08673
TT
294 ext4_mark_bitmap_end(EXT4_INODES_PER_GROUP(sb), sb->s_blocksize * 8,
295 bh->b_data);
b4097142
TT
296 err = ext4_handle_dirty_metadata(handle, NULL, bh);
297 if (unlikely(err))
298 ext4_std_error(sb, err);
ac27a0ec
DK
299exit_bh:
300 brelse(bh);
301
302exit_journal:
617ba13b 303 if ((err2 = ext4_journal_stop(handle)) && !err)
ac27a0ec
DK
304 err = err2;
305
306 return err;
307}
308
309/*
310 * Iterate through the groups which hold BACKUP superblock/GDT copies in an
617ba13b 311 * ext4 filesystem. The counters should be initialized to 1, 5, and 7 before
ac27a0ec
DK
312 * calling this for the first time. In a sparse filesystem it will be the
313 * sequence of powers of 3, 5, and 7: 1, 3, 5, 7, 9, 25, 27, 49, 81, ...
314 * For a non-sparse filesystem it will be every group: 1, 2, 3, 4, ...
315 */
617ba13b 316static unsigned ext4_list_backups(struct super_block *sb, unsigned *three,
ac27a0ec
DK
317 unsigned *five, unsigned *seven)
318{
319 unsigned *min = three;
320 int mult = 3;
321 unsigned ret;
322
617ba13b
MC
323 if (!EXT4_HAS_RO_COMPAT_FEATURE(sb,
324 EXT4_FEATURE_RO_COMPAT_SPARSE_SUPER)) {
ac27a0ec
DK
325 ret = *min;
326 *min += 1;
327 return ret;
328 }
329
330 if (*five < *min) {
331 min = five;
332 mult = 5;
333 }
334 if (*seven < *min) {
335 min = seven;
336 mult = 7;
337 }
338
339 ret = *min;
340 *min *= mult;
341
342 return ret;
343}
344
345/*
346 * Check that all of the backup GDT blocks are held in the primary GDT block.
347 * It is assumed that they are stored in group order. Returns the number of
348 * groups in current filesystem that have BACKUPS, or -ve error code.
349 */
350static int verify_reserved_gdb(struct super_block *sb,
351 struct buffer_head *primary)
352{
617ba13b 353 const ext4_fsblk_t blk = primary->b_blocknr;
fd2d4291 354 const ext4_group_t end = EXT4_SB(sb)->s_groups_count;
ac27a0ec
DK
355 unsigned three = 1;
356 unsigned five = 5;
357 unsigned seven = 7;
358 unsigned grp;
359 __le32 *p = (__le32 *)primary->b_data;
360 int gdbackups = 0;
361
617ba13b 362 while ((grp = ext4_list_backups(sb, &three, &five, &seven)) < end) {
bd81d8ee
LV
363 if (le32_to_cpu(*p++) !=
364 grp * EXT4_BLOCKS_PER_GROUP(sb) + blk){
12062ddd 365 ext4_warning(sb, "reserved GDT %llu"
2ae02107 366 " missing grp %d (%llu)",
ac27a0ec 367 blk, grp,
bd81d8ee
LV
368 grp *
369 (ext4_fsblk_t)EXT4_BLOCKS_PER_GROUP(sb) +
370 blk);
ac27a0ec
DK
371 return -EINVAL;
372 }
617ba13b 373 if (++gdbackups > EXT4_ADDR_PER_BLOCK(sb))
ac27a0ec
DK
374 return -EFBIG;
375 }
376
377 return gdbackups;
378}
379
380/*
381 * Called when we need to bring a reserved group descriptor table block into
382 * use from the resize inode. The primary copy of the new GDT block currently
383 * is an indirect block (under the double indirect block in the resize inode).
384 * The new backup GDT blocks will be stored as leaf blocks in this indirect
385 * block, in group order. Even though we know all the block numbers we need,
386 * we check to ensure that the resize inode has actually reserved these blocks.
387 *
388 * Don't need to update the block bitmaps because the blocks are still in use.
389 *
390 * We get all of the error cases out of the way, so that we are sure to not
391 * fail once we start modifying the data on disk, because JBD has no rollback.
392 */
393static int add_new_gdb(handle_t *handle, struct inode *inode,
617ba13b 394 struct ext4_new_group_data *input,
ac27a0ec
DK
395 struct buffer_head **primary)
396{
397 struct super_block *sb = inode->i_sb;
617ba13b
MC
398 struct ext4_super_block *es = EXT4_SB(sb)->s_es;
399 unsigned long gdb_num = input->group / EXT4_DESC_PER_BLOCK(sb);
400 ext4_fsblk_t gdblock = EXT4_SB(sb)->s_sbh->b_blocknr + 1 + gdb_num;
ac27a0ec
DK
401 struct buffer_head **o_group_desc, **n_group_desc;
402 struct buffer_head *dind;
403 int gdbackups;
617ba13b 404 struct ext4_iloc iloc;
ac27a0ec
DK
405 __le32 *data;
406 int err;
407
408 if (test_opt(sb, DEBUG))
409 printk(KERN_DEBUG
617ba13b 410 "EXT4-fs: ext4_add_new_gdb: adding group block %lu\n",
ac27a0ec
DK
411 gdb_num);
412
af5bc92d
TT
413 /*
414 * If we are not using the primary superblock/GDT copy don't resize,
2b2d6d01
TT
415 * because the user tools have no way of handling this. Probably a
416 * bad time to do it anyways.
417 */
617ba13b
MC
418 if (EXT4_SB(sb)->s_sbh->b_blocknr !=
419 le32_to_cpu(EXT4_SB(sb)->s_es->s_first_data_block)) {
12062ddd 420 ext4_warning(sb, "won't resize using backup superblock at %llu",
617ba13b 421 (unsigned long long)EXT4_SB(sb)->s_sbh->b_blocknr);
ac27a0ec
DK
422 return -EPERM;
423 }
424
425 *primary = sb_bread(sb, gdblock);
426 if (!*primary)
427 return -EIO;
428
429 if ((gdbackups = verify_reserved_gdb(sb, *primary)) < 0) {
430 err = gdbackups;
431 goto exit_bh;
432 }
433
617ba13b 434 data = EXT4_I(inode)->i_data + EXT4_DIND_BLOCK;
ac27a0ec
DK
435 dind = sb_bread(sb, le32_to_cpu(*data));
436 if (!dind) {
437 err = -EIO;
438 goto exit_bh;
439 }
440
441 data = (__le32 *)dind->b_data;
617ba13b 442 if (le32_to_cpu(data[gdb_num % EXT4_ADDR_PER_BLOCK(sb)]) != gdblock) {
12062ddd 443 ext4_warning(sb, "new group %u GDT block %llu not reserved",
ac27a0ec
DK
444 input->group, gdblock);
445 err = -EINVAL;
446 goto exit_dind;
447 }
448
b4097142
TT
449 err = ext4_journal_get_write_access(handle, EXT4_SB(sb)->s_sbh);
450 if (unlikely(err))
ac27a0ec
DK
451 goto exit_dind;
452
b4097142
TT
453 err = ext4_journal_get_write_access(handle, *primary);
454 if (unlikely(err))
ac27a0ec
DK
455 goto exit_sbh;
456
b4097142
TT
457 err = ext4_journal_get_write_access(handle, dind);
458 if (unlikely(err))
459 ext4_std_error(sb, err);
ac27a0ec 460
617ba13b 461 /* ext4_reserve_inode_write() gets a reference on the iloc */
b4097142
TT
462 err = ext4_reserve_inode_write(handle, inode, &iloc);
463 if (unlikely(err))
ac27a0ec
DK
464 goto exit_dindj;
465
466 n_group_desc = kmalloc((gdb_num + 1) * sizeof(struct buffer_head *),
216553c4 467 GFP_NOFS);
ac27a0ec
DK
468 if (!n_group_desc) {
469 err = -ENOMEM;
12062ddd 470 ext4_warning(sb,
ac27a0ec
DK
471 "not enough memory for %lu groups", gdb_num + 1);
472 goto exit_inode;
473 }
474
475 /*
476 * Finally, we have all of the possible failures behind us...
477 *
478 * Remove new GDT block from inode double-indirect block and clear out
479 * the new GDT block for use (which also "frees" the backup GDT blocks
480 * from the reserved inode). We don't need to change the bitmaps for
481 * these blocks, because they are marked as in-use from being in the
482 * reserved inode, and will become GDT blocks (primary and backup).
483 */
617ba13b 484 data[gdb_num % EXT4_ADDR_PER_BLOCK(sb)] = 0;
b4097142
TT
485 err = ext4_handle_dirty_metadata(handle, NULL, dind);
486 if (unlikely(err)) {
487 ext4_std_error(sb, err);
488 goto exit_inode;
489 }
ac27a0ec 490 inode->i_blocks -= (gdbackups + 1) * sb->s_blocksize >> 9;
617ba13b 491 ext4_mark_iloc_dirty(handle, inode, &iloc);
ac27a0ec 492 memset((*primary)->b_data, 0, sb->s_blocksize);
b4097142
TT
493 err = ext4_handle_dirty_metadata(handle, NULL, *primary);
494 if (unlikely(err)) {
495 ext4_std_error(sb, err);
496 goto exit_inode;
497 }
498 brelse(dind);
ac27a0ec 499
617ba13b 500 o_group_desc = EXT4_SB(sb)->s_group_desc;
ac27a0ec 501 memcpy(n_group_desc, o_group_desc,
617ba13b 502 EXT4_SB(sb)->s_gdb_count * sizeof(struct buffer_head *));
ac27a0ec 503 n_group_desc[gdb_num] = *primary;
617ba13b
MC
504 EXT4_SB(sb)->s_group_desc = n_group_desc;
505 EXT4_SB(sb)->s_gdb_count++;
ac27a0ec
DK
506 kfree(o_group_desc);
507
e8546d06 508 le16_add_cpu(&es->s_reserved_gdt_blocks, -1);
b4097142
TT
509 err = ext4_handle_dirty_metadata(handle, NULL, EXT4_SB(sb)->s_sbh);
510 if (err)
511 ext4_std_error(sb, err);
ac27a0ec 512
b4097142 513 return err;
ac27a0ec
DK
514
515exit_inode:
537a0310 516 /* ext4_handle_release_buffer(handle, iloc.bh); */
ac27a0ec
DK
517 brelse(iloc.bh);
518exit_dindj:
537a0310 519 /* ext4_handle_release_buffer(handle, dind); */
ac27a0ec 520exit_sbh:
537a0310 521 /* ext4_handle_release_buffer(handle, EXT4_SB(sb)->s_sbh); */
ac27a0ec
DK
522exit_dind:
523 brelse(dind);
524exit_bh:
525 brelse(*primary);
526
617ba13b 527 ext4_debug("leaving with error %d\n", err);
ac27a0ec
DK
528 return err;
529}
530
531/*
532 * Called when we are adding a new group which has a backup copy of each of
533 * the GDT blocks (i.e. sparse group) and there are reserved GDT blocks.
534 * We need to add these reserved backup GDT blocks to the resize inode, so
535 * that they are kept for future resizing and not allocated to files.
536 *
537 * Each reserved backup GDT block will go into a different indirect block.
538 * The indirect blocks are actually the primary reserved GDT blocks,
539 * so we know in advance what their block numbers are. We only get the
540 * double-indirect block to verify it is pointing to the primary reserved
541 * GDT blocks so we don't overwrite a data block by accident. The reserved
542 * backup GDT blocks are stored in their reserved primary GDT block.
543 */
544static int reserve_backup_gdb(handle_t *handle, struct inode *inode,
617ba13b 545 struct ext4_new_group_data *input)
ac27a0ec
DK
546{
547 struct super_block *sb = inode->i_sb;
617ba13b 548 int reserved_gdb =le16_to_cpu(EXT4_SB(sb)->s_es->s_reserved_gdt_blocks);
ac27a0ec
DK
549 struct buffer_head **primary;
550 struct buffer_head *dind;
617ba13b
MC
551 struct ext4_iloc iloc;
552 ext4_fsblk_t blk;
ac27a0ec
DK
553 __le32 *data, *end;
554 int gdbackups = 0;
555 int res, i;
556 int err;
557
216553c4 558 primary = kmalloc(reserved_gdb * sizeof(*primary), GFP_NOFS);
ac27a0ec
DK
559 if (!primary)
560 return -ENOMEM;
561
617ba13b 562 data = EXT4_I(inode)->i_data + EXT4_DIND_BLOCK;
ac27a0ec
DK
563 dind = sb_bread(sb, le32_to_cpu(*data));
564 if (!dind) {
565 err = -EIO;
566 goto exit_free;
567 }
568
617ba13b 569 blk = EXT4_SB(sb)->s_sbh->b_blocknr + 1 + EXT4_SB(sb)->s_gdb_count;
94460093
JB
570 data = (__le32 *)dind->b_data + (EXT4_SB(sb)->s_gdb_count %
571 EXT4_ADDR_PER_BLOCK(sb));
617ba13b 572 end = (__le32 *)dind->b_data + EXT4_ADDR_PER_BLOCK(sb);
ac27a0ec
DK
573
574 /* Get each reserved primary GDT block and verify it holds backups */
575 for (res = 0; res < reserved_gdb; res++, blk++) {
576 if (le32_to_cpu(*data) != blk) {
12062ddd 577 ext4_warning(sb, "reserved block %llu"
ac27a0ec
DK
578 " not at offset %ld",
579 blk,
580 (long)(data - (__le32 *)dind->b_data));
581 err = -EINVAL;
582 goto exit_bh;
583 }
584 primary[res] = sb_bread(sb, blk);
585 if (!primary[res]) {
586 err = -EIO;
587 goto exit_bh;
588 }
589 if ((gdbackups = verify_reserved_gdb(sb, primary[res])) < 0) {
590 brelse(primary[res]);
591 err = gdbackups;
592 goto exit_bh;
593 }
594 if (++data >= end)
595 data = (__le32 *)dind->b_data;
596 }
597
598 for (i = 0; i < reserved_gdb; i++) {
617ba13b 599 if ((err = ext4_journal_get_write_access(handle, primary[i]))) {
ac27a0ec
DK
600 /*
601 int j;
602 for (j = 0; j < i; j++)
537a0310 603 ext4_handle_release_buffer(handle, primary[j]);
ac27a0ec
DK
604 */
605 goto exit_bh;
606 }
607 }
608
617ba13b 609 if ((err = ext4_reserve_inode_write(handle, inode, &iloc)))
ac27a0ec
DK
610 goto exit_bh;
611
612 /*
613 * Finally we can add each of the reserved backup GDT blocks from
614 * the new group to its reserved primary GDT block.
615 */
617ba13b 616 blk = input->group * EXT4_BLOCKS_PER_GROUP(sb);
ac27a0ec
DK
617 for (i = 0; i < reserved_gdb; i++) {
618 int err2;
619 data = (__le32 *)primary[i]->b_data;
620 /* printk("reserving backup %lu[%u] = %lu\n",
621 primary[i]->b_blocknr, gdbackups,
622 blk + primary[i]->b_blocknr); */
623 data[gdbackups] = cpu_to_le32(blk + primary[i]->b_blocknr);
0390131b 624 err2 = ext4_handle_dirty_metadata(handle, NULL, primary[i]);
ac27a0ec
DK
625 if (!err)
626 err = err2;
627 }
628 inode->i_blocks += reserved_gdb * sb->s_blocksize >> 9;
617ba13b 629 ext4_mark_iloc_dirty(handle, inode, &iloc);
ac27a0ec
DK
630
631exit_bh:
632 while (--res >= 0)
633 brelse(primary[res]);
634 brelse(dind);
635
636exit_free:
637 kfree(primary);
638
639 return err;
640}
641
642/*
617ba13b 643 * Update the backup copies of the ext4 metadata. These don't need to be part
ac27a0ec
DK
644 * of the main resize transaction, because e2fsck will re-write them if there
645 * is a problem (basically only OOM will cause a problem). However, we
646 * _should_ update the backups if possible, in case the primary gets trashed
647 * for some reason and we need to run e2fsck from a backup superblock. The
648 * important part is that the new block and inode counts are in the backup
649 * superblocks, and the location of the new group metadata in the GDT backups.
650 *
32ed5058
TT
651 * We do not need take the s_resize_lock for this, because these
652 * blocks are not otherwise touched by the filesystem code when it is
653 * mounted. We don't need to worry about last changing from
654 * sbi->s_groups_count, because the worst that can happen is that we
655 * do not copy the full number of backups at this time. The resize
656 * which changed s_groups_count will backup again.
ac27a0ec
DK
657 */
658static void update_backups(struct super_block *sb,
659 int blk_off, char *data, int size)
660{
617ba13b 661 struct ext4_sb_info *sbi = EXT4_SB(sb);
fd2d4291 662 const ext4_group_t last = sbi->s_groups_count;
617ba13b 663 const int bpg = EXT4_BLOCKS_PER_GROUP(sb);
ac27a0ec
DK
664 unsigned three = 1;
665 unsigned five = 5;
666 unsigned seven = 7;
fd2d4291 667 ext4_group_t group;
ac27a0ec
DK
668 int rest = sb->s_blocksize - size;
669 handle_t *handle;
670 int err = 0, err2;
671
617ba13b 672 handle = ext4_journal_start_sb(sb, EXT4_MAX_TRANS_DATA);
ac27a0ec
DK
673 if (IS_ERR(handle)) {
674 group = 1;
675 err = PTR_ERR(handle);
676 goto exit_err;
677 }
678
617ba13b 679 while ((group = ext4_list_backups(sb, &three, &five, &seven)) < last) {
ac27a0ec
DK
680 struct buffer_head *bh;
681
682 /* Out of journal space, and can't get more - abort - so sad */
0390131b
FM
683 if (ext4_handle_valid(handle) &&
684 handle->h_buffer_credits == 0 &&
617ba13b
MC
685 ext4_journal_extend(handle, EXT4_MAX_TRANS_DATA) &&
686 (err = ext4_journal_restart(handle, EXT4_MAX_TRANS_DATA)))
ac27a0ec
DK
687 break;
688
689 bh = sb_getblk(sb, group * bpg + blk_off);
690 if (!bh) {
691 err = -EIO;
692 break;
693 }
617ba13b 694 ext4_debug("update metadata backup %#04lx\n",
ac27a0ec 695 (unsigned long)bh->b_blocknr);
617ba13b 696 if ((err = ext4_journal_get_write_access(handle, bh)))
ac27a0ec
DK
697 break;
698 lock_buffer(bh);
699 memcpy(bh->b_data, data, size);
700 if (rest)
701 memset(bh->b_data + size, 0, rest);
702 set_buffer_uptodate(bh);
703 unlock_buffer(bh);
b4097142
TT
704 err = ext4_handle_dirty_metadata(handle, NULL, bh);
705 if (unlikely(err))
706 ext4_std_error(sb, err);
ac27a0ec
DK
707 brelse(bh);
708 }
617ba13b 709 if ((err2 = ext4_journal_stop(handle)) && !err)
ac27a0ec
DK
710 err = err2;
711
712 /*
713 * Ugh! Need to have e2fsck write the backup copies. It is too
714 * late to revert the resize, we shouldn't fail just because of
715 * the backup copies (they are only needed in case of corruption).
716 *
717 * However, if we got here we have a journal problem too, so we
718 * can't really start a transaction to mark the superblock.
719 * Chicken out and just set the flag on the hope it will be written
720 * to disk, and if not - we will simply wait until next fsck.
721 */
722exit_err:
723 if (err) {
12062ddd 724 ext4_warning(sb, "can't update backup for group %u (err %d), "
ac27a0ec 725 "forcing fsck on next reboot", group, err);
617ba13b
MC
726 sbi->s_mount_state &= ~EXT4_VALID_FS;
727 sbi->s_es->s_state &= cpu_to_le16(~EXT4_VALID_FS);
ac27a0ec
DK
728 mark_buffer_dirty(sbi->s_sbh);
729 }
730}
731
732/* Add group descriptor data to an existing or new group descriptor block.
733 * Ensure we handle all possible error conditions _before_ we start modifying
734 * the filesystem, because we cannot abort the transaction and not have it
735 * write the data to disk.
736 *
737 * If we are on a GDT block boundary, we need to get the reserved GDT block.
738 * Otherwise, we may need to add backup GDT blocks for a sparse group.
739 *
740 * We only need to hold the superblock lock while we are actually adding
741 * in the new group's counts to the superblock. Prior to that we have
742 * not really "added" the group at all. We re-check that we are still
743 * adding in the last group in case things have changed since verifying.
744 */
617ba13b 745int ext4_group_add(struct super_block *sb, struct ext4_new_group_data *input)
ac27a0ec 746{
617ba13b
MC
747 struct ext4_sb_info *sbi = EXT4_SB(sb);
748 struct ext4_super_block *es = sbi->s_es;
749 int reserved_gdb = ext4_bg_has_super(sb, input->group) ?
ac27a0ec
DK
750 le16_to_cpu(es->s_reserved_gdt_blocks) : 0;
751 struct buffer_head *primary = NULL;
617ba13b 752 struct ext4_group_desc *gdp;
ac27a0ec
DK
753 struct inode *inode = NULL;
754 handle_t *handle;
755 int gdb_off, gdb_num;
756 int err, err2;
757
617ba13b
MC
758 gdb_num = input->group / EXT4_DESC_PER_BLOCK(sb);
759 gdb_off = input->group % EXT4_DESC_PER_BLOCK(sb);
ac27a0ec 760
617ba13b
MC
761 if (gdb_off == 0 && !EXT4_HAS_RO_COMPAT_FEATURE(sb,
762 EXT4_FEATURE_RO_COMPAT_SPARSE_SUPER)) {
12062ddd 763 ext4_warning(sb, "Can't resize non-sparse filesystem further");
ac27a0ec
DK
764 return -EPERM;
765 }
766
bd81d8ee
LV
767 if (ext4_blocks_count(es) + input->blocks_count <
768 ext4_blocks_count(es)) {
12062ddd 769 ext4_warning(sb, "blocks_count overflow");
ac27a0ec
DK
770 return -EINVAL;
771 }
772
617ba13b 773 if (le32_to_cpu(es->s_inodes_count) + EXT4_INODES_PER_GROUP(sb) <
ac27a0ec 774 le32_to_cpu(es->s_inodes_count)) {
12062ddd 775 ext4_warning(sb, "inodes_count overflow");
ac27a0ec
DK
776 return -EINVAL;
777 }
778
779 if (reserved_gdb || gdb_off == 0) {
617ba13b 780 if (!EXT4_HAS_COMPAT_FEATURE(sb,
37609fd5
JB
781 EXT4_FEATURE_COMPAT_RESIZE_INODE)
782 || !le16_to_cpu(es->s_reserved_gdt_blocks)) {
12062ddd 783 ext4_warning(sb,
ac27a0ec
DK
784 "No reserved GDT blocks, can't resize");
785 return -EPERM;
786 }
1d1fe1ee
DH
787 inode = ext4_iget(sb, EXT4_RESIZE_INO);
788 if (IS_ERR(inode)) {
12062ddd 789 ext4_warning(sb, "Error opening resize inode");
1d1fe1ee 790 return PTR_ERR(inode);
ac27a0ec
DK
791 }
792 }
793
920313a7 794
ac27a0ec
DK
795 if ((err = verify_group_input(sb, input)))
796 goto exit_put;
797
798 if ((err = setup_new_group_blocks(sb, input)))
799 goto exit_put;
800
801 /*
802 * We will always be modifying at least the superblock and a GDT
803 * block. If we are adding a group past the last current GDT block,
804 * we will also modify the inode and the dindirect block. If we
805 * are adding a group with superblock/GDT backups we will also
806 * modify each of the reserved GDT dindirect blocks.
807 */
617ba13b
MC
808 handle = ext4_journal_start_sb(sb,
809 ext4_bg_has_super(sb, input->group) ?
ac27a0ec
DK
810 3 + reserved_gdb : 4);
811 if (IS_ERR(handle)) {
812 err = PTR_ERR(handle);
813 goto exit_put;
814 }
815
617ba13b 816 if ((err = ext4_journal_get_write_access(handle, sbi->s_sbh)))
ac27a0ec
DK
817 goto exit_journal;
818
2b2d6d01
TT
819 /*
820 * We will only either add reserved group blocks to a backup group
821 * or remove reserved blocks for the first group in a new group block.
822 * Doing both would be mean more complex code, and sane people don't
823 * use non-sparse filesystems anymore. This is already checked above.
824 */
ac27a0ec
DK
825 if (gdb_off) {
826 primary = sbi->s_group_desc[gdb_num];
617ba13b 827 if ((err = ext4_journal_get_write_access(handle, primary)))
ac27a0ec
DK
828 goto exit_journal;
829
617ba13b 830 if (reserved_gdb && ext4_bg_num_gdb(sb, input->group) &&
ac27a0ec
DK
831 (err = reserve_backup_gdb(handle, inode, input)))
832 goto exit_journal;
833 } else if ((err = add_new_gdb(handle, inode, input, &primary)))
834 goto exit_journal;
835
2b2d6d01
TT
836 /*
837 * OK, now we've set up the new group. Time to make it active.
838 *
2b2d6d01
TT
839 * so we have to be safe wrt. concurrent accesses the group
840 * data. So we need to be careful to set all of the relevant
841 * group descriptor data etc. *before* we enable the group.
842 *
843 * The key field here is sbi->s_groups_count: as long as
844 * that retains its old value, nobody is going to access the new
845 * group.
846 *
847 * So first we update all the descriptor metadata for the new
848 * group; then we update the total disk blocks count; then we
849 * update the groups count to enable the group; then finally we
850 * update the free space counts so that the system can start
851 * using the new disk blocks.
852 */
ac27a0ec
DK
853
854 /* Update group descriptor block for new group */
2856922c
FB
855 gdp = (struct ext4_group_desc *)((char *)primary->b_data +
856 gdb_off * EXT4_DESC_SIZE(sb));
ac27a0ec 857
fdff73f0 858 memset(gdp, 0, EXT4_DESC_SIZE(sb));
8fadc143
AR
859 ext4_block_bitmap_set(sb, gdp, input->block_bitmap); /* LV FIXME */
860 ext4_inode_bitmap_set(sb, gdp, input->inode_bitmap); /* LV FIXME */
861 ext4_inode_table_set(sb, gdp, input->inode_table); /* LV FIXME */
560671a0
AK
862 ext4_free_blks_set(sb, gdp, input->free_blocks_count);
863 ext4_free_inodes_set(sb, gdp, EXT4_INODES_PER_GROUP(sb));
fdff73f0 864 gdp->bg_flags = cpu_to_le16(EXT4_BG_INODE_ZEROED);
717d50e4 865 gdp->bg_checksum = ext4_group_desc_csum(sbi, input->group, gdp);
ac27a0ec 866
5f21b0e6
FB
867 /*
868 * We can allocate memory for mb_alloc based on the new group
869 * descriptor
870 */
920313a7 871 err = ext4_mb_add_groupinfo(sb, input->group, gdp);
08c3a813 872 if (err)
c2ea3fde
TT
873 goto exit_journal;
874
ac27a0ec
DK
875 /*
876 * Make the new blocks and inodes valid next. We do this before
877 * increasing the group count so that once the group is enabled,
878 * all of its blocks and inodes are already valid.
879 *
880 * We always allocate group-by-group, then block-by-block or
881 * inode-by-inode within a group, so enabling these
882 * blocks/inodes before the group is live won't actually let us
883 * allocate the new space yet.
884 */
bd81d8ee 885 ext4_blocks_count_set(es, ext4_blocks_count(es) +
ac27a0ec 886 input->blocks_count);
e8546d06 887 le32_add_cpu(&es->s_inodes_count, EXT4_INODES_PER_GROUP(sb));
ac27a0ec
DK
888
889 /*
890 * We need to protect s_groups_count against other CPUs seeing
891 * inconsistent state in the superblock.
892 *
893 * The precise rules we use are:
894 *
ac27a0ec
DK
895 * * Writers must perform a smp_wmb() after updating all dependent
896 * data and before modifying the groups count
897 *
ac27a0ec
DK
898 * * Readers must perform an smp_rmb() after reading the groups count
899 * and before reading any dependent data.
900 *
901 * NB. These rules can be relaxed when checking the group count
902 * while freeing data, as we can only allocate from a block
903 * group after serialising against the group count, and we can
904 * only then free after serialising in turn against that
905 * allocation.
906 */
907 smp_wmb();
908
909 /* Update the global fs size fields */
910 sbi->s_groups_count++;
911
b4097142
TT
912 err = ext4_handle_dirty_metadata(handle, NULL, primary);
913 if (unlikely(err)) {
914 ext4_std_error(sb, err);
915 goto exit_journal;
916 }
ac27a0ec
DK
917
918 /* Update the reserved block counts only once the new group is
919 * active. */
bd81d8ee 920 ext4_r_blocks_count_set(es, ext4_r_blocks_count(es) +
ac27a0ec
DK
921 input->reserved_blocks);
922
923 /* Update the free space counts */
aa0dff2d 924 percpu_counter_add(&sbi->s_freeblocks_counter,
ac27a0ec 925 input->free_blocks_count);
aa0dff2d 926 percpu_counter_add(&sbi->s_freeinodes_counter,
617ba13b 927 EXT4_INODES_PER_GROUP(sb));
ac27a0ec 928
42007efd
ES
929 if (EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_FLEX_BG) &&
930 sbi->s_log_groups_per_flex) {
c62a11fd
FB
931 ext4_group_t flex_group;
932 flex_group = ext4_flex_group(sbi, input->group);
9f24e420
TT
933 atomic_add(input->free_blocks_count,
934 &sbi->s_flex_groups[flex_group].free_blocks);
935 atomic_add(EXT4_INODES_PER_GROUP(sb),
936 &sbi->s_flex_groups[flex_group].free_inodes);
c62a11fd
FB
937 }
938
a0375156 939 ext4_handle_dirty_super(handle, sb);
ac27a0ec
DK
940
941exit_journal:
617ba13b 942 if ((err2 = ext4_journal_stop(handle)) && !err)
ac27a0ec
DK
943 err = err2;
944 if (!err) {
945 update_backups(sb, sbi->s_sbh->b_blocknr, (char *)es,
617ba13b 946 sizeof(struct ext4_super_block));
ac27a0ec
DK
947 update_backups(sb, primary->b_blocknr, primary->b_data,
948 primary->b_size);
949 }
950exit_put:
951 iput(inode);
952 return err;
617ba13b 953} /* ext4_group_add */
ac27a0ec 954
2b2d6d01
TT
955/*
956 * Extend the filesystem to the new number of blocks specified. This entry
ac27a0ec
DK
957 * point is only used to extend the current filesystem to the end of the last
958 * existing group. It can be accessed via ioctl, or by "remount,resize=<size>"
959 * for emergencies (because it has no dependencies on reserved blocks).
960 *
617ba13b 961 * If we _really_ wanted, we could use default values to call ext4_group_add()
ac27a0ec
DK
962 * allow the "remount" trick to work for arbitrary resizing, assuming enough
963 * GDT blocks are reserved to grow to the desired size.
964 */
617ba13b
MC
965int ext4_group_extend(struct super_block *sb, struct ext4_super_block *es,
966 ext4_fsblk_t n_blocks_count)
ac27a0ec 967{
617ba13b 968 ext4_fsblk_t o_blocks_count;
617ba13b
MC
969 ext4_grpblk_t last;
970 ext4_grpblk_t add;
af5bc92d 971 struct buffer_head *bh;
ac27a0ec
DK
972 handle_t *handle;
973 int err;
5f21b0e6 974 ext4_group_t group;
ac27a0ec 975
bd81d8ee 976 o_blocks_count = ext4_blocks_count(es);
ac27a0ec
DK
977
978 if (test_opt(sb, DEBUG))
2ae02107 979 printk(KERN_DEBUG "EXT4-fs: extending last group from %llu uto %llu blocks\n",
ac27a0ec
DK
980 o_blocks_count, n_blocks_count);
981
982 if (n_blocks_count == 0 || n_blocks_count == o_blocks_count)
983 return 0;
984
985 if (n_blocks_count > (sector_t)(~0ULL) >> (sb->s_blocksize_bits - 9)) {
617ba13b 986 printk(KERN_ERR "EXT4-fs: filesystem on %s:"
2ae02107 987 " too large to resize to %llu blocks safely\n",
ac27a0ec
DK
988 sb->s_id, n_blocks_count);
989 if (sizeof(sector_t) < 8)
12062ddd 990 ext4_warning(sb, "CONFIG_LBDAF not enabled");
ac27a0ec
DK
991 return -EINVAL;
992 }
993
994 if (n_blocks_count < o_blocks_count) {
12062ddd 995 ext4_warning(sb, "can't shrink FS - resize aborted");
8f82f840 996 return -EINVAL;
ac27a0ec
DK
997 }
998
999 /* Handle the remaining blocks in the last group only. */
5f21b0e6 1000 ext4_get_group_no_and_offset(sb, o_blocks_count, &group, &last);
ac27a0ec
DK
1001
1002 if (last == 0) {
12062ddd 1003 ext4_warning(sb, "need to use ext2online to resize further");
ac27a0ec
DK
1004 return -EPERM;
1005 }
1006
617ba13b 1007 add = EXT4_BLOCKS_PER_GROUP(sb) - last;
ac27a0ec
DK
1008
1009 if (o_blocks_count + add < o_blocks_count) {
12062ddd 1010 ext4_warning(sb, "blocks_count overflow");
ac27a0ec
DK
1011 return -EINVAL;
1012 }
1013
1014 if (o_blocks_count + add > n_blocks_count)
1015 add = n_blocks_count - o_blocks_count;
1016
1017 if (o_blocks_count + add < n_blocks_count)
12062ddd 1018 ext4_warning(sb, "will only finish group (%llu blocks, %u new)",
ac27a0ec
DK
1019 o_blocks_count + add, add);
1020
1021 /* See if the device is actually as big as what was requested */
2b2d6d01 1022 bh = sb_bread(sb, o_blocks_count + add - 1);
ac27a0ec 1023 if (!bh) {
12062ddd 1024 ext4_warning(sb, "can't read last block, resize aborted");
ac27a0ec
DK
1025 return -ENOSPC;
1026 }
1027 brelse(bh);
1028
1029 /* We will update the superblock, one block bitmap, and
617ba13b 1030 * one group descriptor via ext4_free_blocks().
ac27a0ec 1031 */
617ba13b 1032 handle = ext4_journal_start_sb(sb, 3);
ac27a0ec
DK
1033 if (IS_ERR(handle)) {
1034 err = PTR_ERR(handle);
12062ddd 1035 ext4_warning(sb, "error %d on journal start", err);
ac27a0ec
DK
1036 goto exit_put;
1037 }
1038
617ba13b
MC
1039 if ((err = ext4_journal_get_write_access(handle,
1040 EXT4_SB(sb)->s_sbh))) {
12062ddd 1041 ext4_warning(sb, "error %d on journal write access", err);
617ba13b 1042 ext4_journal_stop(handle);
ac27a0ec
DK
1043 goto exit_put;
1044 }
bd81d8ee 1045 ext4_blocks_count_set(es, o_blocks_count + add);
c549a95d 1046 ext4_debug("freeing blocks %llu through %llu\n", o_blocks_count,
ac27a0ec 1047 o_blocks_count + add);
e21675d4
AK
1048 /* We add the blocks to the bitmap and set the group need init bit */
1049 ext4_add_groupblocks(handle, sb, o_blocks_count, add);
a0375156 1050 ext4_handle_dirty_super(handle, sb);
2ae02107 1051 ext4_debug("freed blocks %llu through %llu\n", o_blocks_count,
ac27a0ec 1052 o_blocks_count + add);
617ba13b 1053 if ((err = ext4_journal_stop(handle)))
ac27a0ec 1054 goto exit_put;
5f21b0e6 1055
ac27a0ec 1056 if (test_opt(sb, DEBUG))
bd81d8ee
LV
1057 printk(KERN_DEBUG "EXT4-fs: extended group to %llu blocks\n",
1058 ext4_blocks_count(es));
617ba13b
MC
1059 update_backups(sb, EXT4_SB(sb)->s_sbh->b_blocknr, (char *)es,
1060 sizeof(struct ext4_super_block));
ac27a0ec
DK
1061exit_put:
1062 return err;
617ba13b 1063} /* ext4_group_extend */