scsi: ibmvfc: don't check for failure from mempool_alloc()
authorNeilBrown <neilb@suse.com>
Mon, 10 Apr 2017 02:15:13 +0000 (12:15 +1000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 19 Apr 2017 01:50:29 +0000 (21:50 -0400)
mempool_alloc() cannot fail when passed GFP_NOIO or any other gfp
setting that is permitted to sleep.  So remove this pointless code.

Signed-off-by: NeilBrown <neilb@suse.com>
Acked-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ibmvscsi/ibmvfc.c

index 2c92dabb55f6fff07e6a58d48870cc639ec677f7..26cd3c28186acfd56725b0f4750836b795020331 100644 (file)
@@ -3910,12 +3910,6 @@ static int ibmvfc_alloc_target(struct ibmvfc_host *vhost, u64 scsi_id)
        spin_unlock_irqrestore(vhost->host->host_lock, flags);
 
        tgt = mempool_alloc(vhost->tgt_pool, GFP_NOIO);
-       if (!tgt) {
-               dev_err(vhost->dev, "Target allocation failure for scsi id %08llx\n",
-                       scsi_id);
-               return -ENOMEM;
-       }
-
        memset(tgt, 0, sizeof(*tgt));
        tgt->scsi_id = scsi_id;
        tgt->new_scsi_id = scsi_id;