exynos9610: USB: Use -Werror

* Remove unused variables.
* Return result of registerAsService().

Bug: 66996870
Test: build with WITH_TIDY=1
Change-Id: I79d1add6190e835de20a0b0c247bbbb259096c14

diff --git a/hidl/usb/Android.bp b/hidl/usb/Android.bp
index 4370d6c7c9c7d0244155deddda6f3372990b0dc2..f5bde70af77140a2f45af1db7fae8f963113b95e 100644 (file)
--- a/hidl/usb/Android.bp
+++ b/hidl/usb/Android.bp
@@ -17,6 +17,10 @@ cc_binary {
     relative_install_path: "hw",
     init_rc: ["android.hardware.usb@1.1-service.wahoo.rc"],
     srcs: ["service.cpp", "Usb.cpp"],
     relative_install_path: "hw",
     init_rc: ["android.hardware.usb@1.1-service.wahoo.rc"],
     srcs: ["service.cpp", "Usb.cpp"],

+    cflags: [
+        "-Wall",
+        "-Werror",
+    ],

     shared_libs: [
         "libbase",
         "libhidlbase",
     shared_libs: [
         "libbase",
         "libhidlbase",

diff --git a/hidl/usb/Usb.cpp b/hidl/usb/Usb.cpp
index 7b084500cde2325235f56e31e5b852fe2cde751f..5f8bdce4da149c511a494a528380119a39834935 100644 (file)
--- a/hidl/usb/Usb.cpp
+++ b/hidl/usb/Usb.cpp
@@ -380,8 +380,6 @@ Status getTypeCPortNamesHelper(std::unordered_map<std::string, bool> *names) {
 
   dp = opendir("/sys/class/typec");
   if (dp != NULL) {
 
   dp = opendir("/sys/class/typec");
   if (dp != NULL) {

-    int32_t ports = 0;
-    int32_t current = 0;

     struct dirent *ep;
 
     while ((ep = readdir(dp))) {
     struct dirent *ep;
 
     while ((ep = readdir(dp))) {