PKCS#7: fix unitialized boolean 'want'
authorColin Ian King <colin.king@canonical.com>
Sat, 27 Feb 2016 12:45:26 +0000 (12:45 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 15 Nov 2017 16:13:14 +0000 (17:13 +0100)
commit 06aae592425701851e02bb850cb9f4997f0ae163 upstream.

The boolean want is not initialized and hence garbage. The default should
be false (later it is only set to true on tne sinfo->authattrs check).

Found with static analysis using CoverityScan

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Cc: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
crypto/asymmetric_keys/pkcs7_parser.c

index 2516e97c58f1b5d98efb0d88692bfe167baaae97..5e5a8adac0bac7975a25e93cd98ce8a9aee331e0 100644 (file)
@@ -87,7 +87,7 @@ EXPORT_SYMBOL_GPL(pkcs7_free_message);
 static int pkcs7_check_authattrs(struct pkcs7_message *msg)
 {
        struct pkcs7_signed_info *sinfo;
-       bool want;
+       bool want = false;
 
        sinfo = msg->signed_infos;
        if (!sinfo)