Fix table borders when cells with `rowspan` are visually in the last row (#4176)

See https://community.woltlab.com/thread/289598

diff --git a/wcfsetup/install/files/lib/system/html/output/node/HtmlOutputNodeTable.class.php b/wcfsetup/install/files/lib/system/html/output/node/HtmlOutputNodeTable.class.php
index 59a8097c38aeb1c6c4fc73625f9bb972bc9c0120..bc8feb5480339d462a7507089d5bd8fdf18820c5 100644 (file)
--- a/wcfsetup/install/files/lib/system/html/output/node/HtmlOutputNodeTable.class.php
+++ b/wcfsetup/install/files/lib/system/html/output/node/HtmlOutputNodeTable.class.php
@@ -24,6 +24,33 @@ class HtmlOutputNodeTable extends AbstractHtmlOutputNode {
                if ($this->outputType === 'text/html' || $this->outputType === 'text/simplified-html') {
                        /** @var \DOMElement $element */
                        foreach ($elements as $element) {
+                               // Detect cells which are visually in the last row of a table due to their
+                               // `rowspan` property.
+                               /** @var \DOMElement $td */
+                               foreach ($element->getElementsByTagName('td') as $td) {
+                                       $rowspan = $td->getAttribute('rowspan');
+                                       if ($rowspan) {
+                                               $nextTrCount = 0;
+                                               $nextSibling = $td->parentNode->nextSibling;
+                                               while ($nextSibling) {
+                                                       if ($nextSibling->nodeType === \XML_ELEMENT_NODE && $nextSibling->tagName === "tr") {
+                                                               $nextTrCount++;
+                                                       }
+                                                       $nextSibling = $nextSibling->nextSibling;
+                                               }
+                                               
+                                               if ($rowspan - 1 === $nextTrCount) {
+                                                       $class = $td->getAttribute('class');
+                                                       if ($class) {
+                                                               $class .= " ";
+                                                       }
+                                                       $class .= "lastRow";
+                                                       
+                                                       $td->setAttribute('class', $class);
+                                               }
+                                       }
+                               }
+                               
                                // check if table is not contained within another table
                                $parent = $element;
                                while ($parent = $parent->parentNode) {

diff --git a/wcfsetup/install/files/style/ui/tabularBox.scss b/wcfsetup/install/files/style/ui/tabularBox.scss
index 47941d07136c45b7f5434483fc852a0bba59e511..ec24d03de1fad0c0984de392ec8c80930a2726dc 100644 (file)
--- a/wcfsetup/install/files/style/ui/tabularBox.scss
+++ b/wcfsetup/install/files/style/ui/tabularBox.scss
@@ -264,7 +264,7 @@
                        background-color: rgb(242, 242, 242);
                }
                
-               &:not(:last-child) > td {
+               &:not(:last-child) > td:not(.lastRow) {
                        border-bottom: 1px solid $wcfContentBorderInner;
                }
        }