ANDROID: sdcardfs: Set num in extension_details during make_item
authorRitesh Harjani <riteshh@codeaurora.org>
Mon, 4 Dec 2017 04:21:07 +0000 (09:51 +0530)
committerStricted <info@stricted.net>
Thu, 11 Oct 2018 16:03:47 +0000 (18:03 +0200)
Without this patch when you delete an extension from configfs
it still exists in the hash table data structures and we are
unable to delete it or change it's group.
This happens because during deletion the key & value is taken from
extension_details, and was not properly set.

Fix it by this patch.

Change-Id: I7c20cb1ab4d99e6aceadcb5ef850f0bb47f18be8
Signed-off-by: Ritesh Harjani <riteshh@codeaurora.org>
Signed-off-by: Daniel Rosenberg <drosen@google.com>
Bug: 73055997

fs/sdcardfs/packagelist.c

index 886d2f699b8042ccf3129f5637255cd274445829..d9f8ed4961b9fe346fd99bd3e0ed6d63ca1e9e78 100644 (file)
@@ -645,6 +645,7 @@ static struct config_item *extension_details_make_item(struct config_group *grou
                return ERR_PTR(-ENOMEM);
        }
        qstr_init(&extension_details->name, tmp);
+       extension_details->num = extensions_value->num;
        ret = insert_ext_gid_entry(&extension_details->name, extensions_value->num);
 
        if (ret) {