uprobes/tracing: Kill the pointless seq_print_ip_sym() call
authorOleg Nesterov <oleg@redhat.com>
Thu, 28 Mar 2013 17:58:11 +0000 (18:58 +0100)
committerOleg Nesterov <oleg@redhat.com>
Sat, 13 Apr 2013 13:31:59 +0000 (15:31 +0200)
seq_print_ip_sym(ip) in print_uprobe_event() is pointless,
kallsyms_lookup(ip) can not resolve a user-space address.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Tested-by: Anton Arapov <anton@redhat.com>
kernel/trace/trace_uprobe.c

index af5b7735cebf978353536a84fa734e5f6a1e856f..8e009016e4ba5621acf712f2522674bd0fff056d 100644 (file)
@@ -531,13 +531,7 @@ print_uprobe_event(struct trace_iterator *iter, int flags, struct trace_event *e
        field = (struct uprobe_trace_entry_head *)iter->ent;
        tu = container_of(event, struct trace_uprobe, call.event);
 
-       if (!trace_seq_printf(s, "%s: (", tu->call.name))
-               goto partial;
-
-       if (!seq_print_ip_sym(s, field->ip, flags | TRACE_ITER_SYM_OFFSET))
-               goto partial;
-
-       if (!trace_seq_puts(s, ")"))
+       if (!trace_seq_printf(s, "%s: (0x%lx)", tu->call.name, field->ip))
                goto partial;
 
        data = (u8 *)&field[1];