GitHub/WoltLab/WCF.git
3 years agoAdd `Database::prepare()` which replaces `app1_` with `app{WCF_N}_` (#4223)
Matthias Schmidt [Wed, 19 May 2021 05:08:01 +0000 (07:08 +0200)]
Add `Database::prepare()` which replaces `app1_` with `app{WCF_N}_` (#4223)

Close #2911

3 years agoMissing font stack for system font in emails
Alexander Ebert [Tue, 18 May 2021 16:19:42 +0000 (18:19 +0200)]
Missing font stack for system font in emails

3 years agoMerge pull request #4221 from WoltLab/session-legacy-duplicate
Tim Düsterhus [Tue, 18 May 2021 11:28:07 +0000 (13:28 +0200)]
Merge pull request #4221 from WoltLab/session-legacy-duplicate

Prevent duplicate key errors during creation of legacy sessions

3 years agoMerge pull request #4222 from mutec/pjsonfiles
Tim Düsterhus [Tue, 18 May 2021 10:33:35 +0000 (12:33 +0200)]
Merge pull request #4222 from mutec/pjsonfiles

provide files-property for `package.json`

3 years agoprovide files-property for package.json
mutec [Tue, 18 May 2021 10:23:43 +0000 (12:23 +0200)]
provide files-property for package.json

Prevent reading the whole repository when this repository is a dependency.

3 years agoPrevent duplicate key errors during creation of legacy sessions
Tim Düsterhus [Tue, 18 May 2021 09:06:11 +0000 (11:06 +0200)]
Prevent duplicate key errors during creation of legacy sessions

Fixes #4214.
see 7878eb77952c506e5818587b49f9a64773b87fb1

3 years agoGracefully handle missing legacy session in SessionHandler::__get()
Tim Düsterhus [Tue, 18 May 2021 08:48:00 +0000 (10:48 +0200)]
Gracefully handle missing legacy session in SessionHandler::__get()

3 years agoExplicitly `return null` in SessionHandler::__get()'s default case
Tim Düsterhus [Tue, 18 May 2021 08:45:42 +0000 (10:45 +0200)]
Explicitly `return null` in SessionHandler::__get()'s default case

3 years agoRevert "Ignore duplicate key errors when creating a legacy session"
Tim Düsterhus [Tue, 18 May 2021 08:11:07 +0000 (10:11 +0200)]
Revert "Ignore duplicate key errors when creating a legacy session"

This commit was incorrect, as `createOrIgnore()` might return `null` which is
disallowed by the return type and is undesired.

This reverts commit 7878eb77952c506e5818587b49f9a64773b87fb1.

3 years agoFix code style issues
Matthias Schmidt [Tue, 18 May 2021 06:51:47 +0000 (08:51 +0200)]
Fix code style issues

3 years agoProperly position errors below fields in `.inputAddon` elements
Matthias Schmidt [Tue, 18 May 2021 05:01:42 +0000 (07:01 +0200)]
Properly position errors below fields in `.inputAddon` elements

3 years agoMerge branch '5.3'
Matthias Schmidt [Tue, 18 May 2021 04:57:32 +0000 (06:57 +0200)]
Merge branch '5.3'

3 years agoProperly position errors below fields in `.inputAddon` elements (#4219)
Matthias Schmidt [Tue, 18 May 2021 04:56:48 +0000 (06:56 +0200)]
Properly position errors below fields in `.inputAddon` elements (#4219)

3 years agoMerge branch '5.3'
Alexander Ebert [Mon, 17 May 2021 17:05:22 +0000 (19:05 +0200)]
Merge branch '5.3'

3 years agoIncorrect redirect url after login in multi domain setups
Alexander Ebert [Mon, 17 May 2021 17:05:06 +0000 (19:05 +0200)]
Incorrect redirect url after login in multi domain setups

3 years agoUse `opacity` to fade out icons
Alexander Ebert [Mon, 17 May 2021 17:02:50 +0000 (19:02 +0200)]
Use `opacity` to fade out icons

3 years agoMerge branch '5.3'
Alexander Ebert [Mon, 17 May 2021 17:01:14 +0000 (19:01 +0200)]
Merge branch '5.3'

3 years agoIncorrect fade out effect in iOS Safari
Alexander Ebert [Mon, 17 May 2021 17:00:44 +0000 (19:00 +0200)]
Incorrect fade out effect in iOS Safari

3 years agoMerge pull request #4217 from WoltLab/readme_redactor
Matthias Schmidt [Mon, 17 May 2021 12:02:31 +0000 (14:02 +0200)]
Merge pull request #4217 from WoltLab/readme_redactor

Remove reference to specific WSC version in `README.md`

3 years agoSkip basic bbcodes when the selection is inside a code block
Alexander Ebert [Mon, 17 May 2021 10:10:49 +0000 (12:10 +0200)]
Skip basic bbcodes when the selection is inside a code block

3 years agoFix possible property access on `null` in `SessionHandler::applyPendingUserChange()`
Tim Düsterhus [Mon, 17 May 2021 10:01:08 +0000 (12:01 +0200)]
Fix possible property access on `null` in `SessionHandler::applyPendingUserChange()`

3 years agoStart each sentence in new line in `README.md`
Matthias Schmidt [Mon, 17 May 2021 06:14:11 +0000 (08:14 +0200)]
Start each sentence in new line in `README.md`

3 years agoRemove reference to specific WSC version in `README.md`
Matthias Schmidt [Mon, 17 May 2021 06:13:23 +0000 (08:13 +0200)]
Remove reference to specific WSC version in `README.md`

3 years agoSupport for lazy loading of rich embeds
Alexander Ebert [Fri, 14 May 2021 15:55:13 +0000 (17:55 +0200)]
Support for lazy loading of rich embeds

3 years agoThe title of rich embeds can now span two lines
Alexander Ebert [Fri, 14 May 2021 15:27:09 +0000 (17:27 +0200)]
The title of rich embeds can now span two lines

3 years agoIgnore duplicate key errors when creating a legacy session
Tim Düsterhus [Fri, 14 May 2021 11:44:55 +0000 (13:44 +0200)]
Ignore duplicate key errors when creating a legacy session

Fixes #4214

3 years agoMerge branch '5.3'
Matthias Schmidt [Fri, 14 May 2021 11:18:18 +0000 (13:18 +0200)]
Merge branch '5.3'

3 years agoFix attachment ids in metacode elements during import (#4213)
Matthias Schmidt [Fri, 14 May 2021 11:14:59 +0000 (13:14 +0200)]
Fix attachment ids in metacode elements during import (#4213)

* Fix attachment ids in metacode elements during import

Close #4212

* Update wcfsetup/install/files/lib/system/importer/AbstractAttachmentImporter.class.php

Co-authored-by: Tim Düsterhus <duesterhus@woltlab.com>
Co-authored-by: Tim Düsterhus <duesterhus@woltlab.com>
3 years agoPreserve names of method arguments during inheritance
Matthias Schmidt [Fri, 14 May 2021 06:34:25 +0000 (08:34 +0200)]
Preserve names of method arguments during inheritance

Close #4211

3 years agoFix condition in `Dependency/Manager.isHiddenByDependencies()`
Matthias Schmidt [Fri, 14 May 2021 05:40:13 +0000 (07:40 +0200)]
Fix condition in `Dependency/Manager.isHiddenByDependencies()`

The checked node is considered hidden, if it (`node`) is in a hidden node (`hiddenNode`) .
The variables were mixed up in this condition during the transition to TypeScript.

3 years agoUpdating minified JavaScript files
WoltLab [Wed, 12 May 2021 13:38:12 +0000 (13:38 +0000)]
Updating minified JavaScript files

3 years agoAdd .gitignore for sourcemaps
Tim Düsterhus [Wed, 12 May 2021 13:11:13 +0000 (15:11 +0200)]
Add .gitignore for sourcemaps

3 years agoGenerate sourcemaps for WoltLabSuite.Core bundles
Tim Düsterhus [Fri, 30 Apr 2021 10:17:45 +0000 (12:17 +0200)]
Generate sourcemaps for WoltLabSuite.Core bundles

3 years agoIncorrect file path
Alexander Ebert [Wed, 12 May 2021 13:01:24 +0000 (15:01 +0200)]
Incorrect file path

3 years agoUse new instead of deprecated popover data attribute for mentions
Matthias Schmidt [Wed, 12 May 2021 11:19:00 +0000 (13:19 +0200)]
Use new instead of deprecated popover data attribute for mentions

See #3318

3 years agoUse BCrypt costs '9' for MFA backup codes
Tim Düsterhus [Wed, 12 May 2021 10:28:42 +0000 (12:28 +0200)]
Use BCrypt costs '9' for MFA backup codes

Resolves #4206

3 years agoAllow adjusting the '$cost' parameter for BCrypt hashes
Tim Düsterhus [Wed, 12 May 2021 10:25:42 +0000 (12:25 +0200)]
Allow adjusting the '$cost' parameter for BCrypt hashes

3 years agoAdd note regarding the upgrade from 5.4.0 Alpha 2 to package.xml
Tim Düsterhus [Wed, 12 May 2021 10:13:27 +0000 (12:13 +0200)]
Add note regarding the upgrade from 5.4.0 Alpha 2 to package.xml

3 years agoDo not change the userID of legacy sessions during update
Tim Düsterhus [Wed, 12 May 2021 09:49:52 +0000 (11:49 +0200)]
Do not change the userID of legacy sessions during update

This causes issues when combined with the `hideSession` parameter of
SessionHandler::changeUser() and is not required, because an existing session
will *never* change its userID.

1. During login (changing user to non-guest)
the previous user's session will be deleted together with the legacy session
matching the sessionID, a new session will be created, its assigned legacy
session will be deleted, then the userID will be adjusted and the session
reloaded, thus creating a legacy session with the appropriate userID (or
re-using an existing one of that newly logged-in user). The legacy session of
the previous user will never be reused as the legacy session for the new user.

2. During logout (changing user to guest)
the previous user session will simply be deleted together with the legacy
session matching the sessionID. A new session + legacy session for the guest
will be created for the next request. The legacy session of the user will never
be reused as the legacy session for the guest.

Resolves WoltLab/com.woltlab.pluginStore#39

3 years agoMerge branch '5.3'
Matthias Schmidt [Wed, 12 May 2021 08:41:26 +0000 (10:41 +0200)]
Merge branch '5.3'

3 years agoDo not delete media files if file is replaced with itself
Matthias Schmidt [Wed, 12 May 2021 08:31:10 +0000 (10:31 +0200)]
Do not delete media files if file is replaced with itself

3 years agoDo not open media manager dialog after replacing media file
Matthias Schmidt [Wed, 12 May 2021 08:23:58 +0000 (10:23 +0200)]
Do not open media manager dialog after replacing media file

… and always reload the media list page in the ACP after editing/replacing media file to ensure updated data.

3 years agoMerge branch '5.3'
Matthias Schmidt [Wed, 12 May 2021 07:49:01 +0000 (09:49 +0200)]
Merge branch '5.3'

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Wed, 12 May 2021 07:37:34 +0000 (09:37 +0200)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Matthias Schmidt [Wed, 12 May 2021 07:37:16 +0000 (09:37 +0200)]
Merge branch '3.1' into 5.2

3 years agoMerge pull request #4209 from WoltLab/comment_moderation_queue
Matthias Schmidt [Wed, 12 May 2021 07:33:29 +0000 (09:33 +0200)]
Merge pull request #4209 from WoltLab/comment_moderation_queue

Delete moderation queue entries after deleting comments/comment responses

3 years agoUse `InvalidObjectArgument` in more places (#4207)
Matthias Schmidt [Tue, 11 May 2021 17:14:40 +0000 (19:14 +0200)]
Use `InvalidObjectArgument` in more places (#4207)

3 years agoDelete moderation queue entries after deleting comments/comment responses
Matthias Schmidt [Tue, 11 May 2021 17:13:21 +0000 (19:13 +0200)]
Delete moderation queue entries after deleting comments/comment responses

Close #4208

3 years agoAdd missing `$definitionName` value for comment response moderation queue handlers
Matthias Schmidt [Tue, 11 May 2021 17:11:03 +0000 (19:11 +0200)]
Add missing `$definitionName` value for comment response moderation queue handlers

3 years agoPrevent invalid or done IPN from being sent again
Marcel Werk [Tue, 11 May 2021 15:53:49 +0000 (17:53 +0200)]
Prevent invalid or done IPN from being sent again

3 years agoBad package version 5.4.0_Alpha_2
Alexander Ebert [Tue, 11 May 2021 14:39:29 +0000 (16:39 +0200)]
Bad package version

3 years agoRelease 5.4.0 Alpha 2
Alexander Ebert [Tue, 11 May 2021 14:23:15 +0000 (16:23 +0200)]
Release 5.4.0 Alpha 2

3 years agoUpdating minified JavaScript files
WoltLab [Tue, 11 May 2021 14:04:31 +0000 (14:04 +0000)]
Updating minified JavaScript files

3 years agoUpdate composer dependencies
Tim Düsterhus [Tue, 11 May 2021 13:54:27 +0000 (15:54 +0200)]
Update composer dependencies

3 years agoAdd `getFilenameExtension` for `UploadFile` instances
joshuaruesweg [Tue, 11 May 2021 12:16:07 +0000 (14:16 +0200)]
Add `getFilenameExtension` for `UploadFile` instances

Closes #4007

3 years agoMerge branch '5.3'
Matthias Schmidt [Tue, 11 May 2021 11:34:14 +0000 (13:34 +0200)]
Merge branch '5.3'

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Tue, 11 May 2021 11:31:01 +0000 (13:31 +0200)]
Merge branch '5.2' into 5.3

3 years agoPreserve article sorting when using pagination
Matthias Schmidt [Tue, 11 May 2021 11:30:48 +0000 (13:30 +0200)]
Preserve article sorting when using pagination

3 years agoMerge branch '5.2' into 5.3
joshuaruesweg [Tue, 11 May 2021 10:53:32 +0000 (12:53 +0200)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
joshuaruesweg [Tue, 11 May 2021 10:53:09 +0000 (12:53 +0200)]
Merge branch '3.1' into 5.2

3 years agoFix ignoring the disable state of an article category
joshuaruesweg [Tue, 11 May 2021 10:52:07 +0000 (12:52 +0200)]
Fix ignoring the disable state of an article category

Deactivated categories are currently only hidden in the overview of categories in the frontend. However, articles in these categories (and the category itself, via the direct link) were still accessible. This patch solves the problem by hiding the category for all users and making articles and the category itself no longer accessible for any user.

3 years agoMerge pull request #4205 from WoltLab/cover-photo-webp
Alexander Ebert [Tue, 11 May 2021 10:06:35 +0000 (12:06 +0200)]
Merge pull request #4205 from WoltLab/cover-photo-webp

Generate WebP variants of users' cover photos

3 years agoMinor code style adjustments
Alexander Ebert [Tue, 11 May 2021 09:50:59 +0000 (11:50 +0200)]
Minor code style adjustments

3 years agoFix typo in method documentation
Matthias Schmidt [Tue, 11 May 2021 08:05:46 +0000 (10:05 +0200)]
Fix typo in method documentation

3 years agoMerge branch '5.3'
Matthias Schmidt [Tue, 11 May 2021 06:56:33 +0000 (08:56 +0200)]
Merge branch '5.3'

3 years agoProperly reset internal state in image viewer widget
Matthias Schmidt [Tue, 11 May 2021 06:56:21 +0000 (08:56 +0200)]
Properly reset internal state in image viewer widget

See #3835

3 years agoAdd `@method` comment for `DatabaseObjectList::getSingleObject()` in subclasses
Matthias Schmidt [Tue, 11 May 2021 06:33:39 +0000 (08:33 +0200)]
Add `@method` comment for `DatabaseObjectList::getSingleObject()` in subclasses

3 years agoFix code style issues
Matthias Schmidt [Tue, 11 May 2021 06:07:31 +0000 (08:07 +0200)]
Fix code style issues

3 years agoMerge branch '5.3'
Matthias Schmidt [Mon, 10 May 2021 17:14:13 +0000 (19:14 +0200)]
Merge branch '5.3'

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Mon, 10 May 2021 17:13:55 +0000 (19:13 +0200)]
Merge branch '5.2' into 5.3

3 years agoFix error messages of numeric form fields for minimum/maximum
Matthias Schmidt [Mon, 10 May 2021 17:13:10 +0000 (19:13 +0200)]
Fix error messages of numeric form fields for minimum/maximum

3 years agoGenerate WebP variants of users' cover photos
Alexander Ebert [Mon, 10 May 2021 17:08:01 +0000 (19:08 +0200)]
Generate WebP variants of users' cover photos

See #4187

3 years agoReport the status for the WebP variant
Alexander Ebert [Mon, 10 May 2021 15:48:35 +0000 (17:48 +0200)]
Report the status for the WebP variant

3 years agoExplicit dimensions of the small page logo
Alexander Ebert [Mon, 10 May 2021 15:41:06 +0000 (17:41 +0200)]
Explicit dimensions of the small page logo

3 years agoMerge pull request #4204 from WoltLab/code_cleanup
Matthias Schmidt [Mon, 10 May 2021 14:34:46 +0000 (16:34 +0200)]
Merge pull request #4204 from WoltLab/code_cleanup

Code cleanup

3 years agoRemove unused import
Matthias Schmidt [Mon, 10 May 2021 14:30:36 +0000 (16:30 +0200)]
Remove unused import

3 years agoExplicitly declare a non-passive event listener
Alexander Ebert [Mon, 10 May 2021 14:11:34 +0000 (16:11 +0200)]
Explicitly declare a non-passive event listener

3 years agoFix return types in method documentation
Matthias Schmidt [Mon, 10 May 2021 14:08:05 +0000 (16:08 +0200)]
Fix return types in method documentation

3 years agoAdd explicit `return null;` statements
Matthias Schmidt [Mon, 10 May 2021 14:07:35 +0000 (16:07 +0200)]
Add explicit `return null;` statements

3 years agoUse `<span>` instead of `<a>` for jump anchors
Alexander Ebert [Mon, 10 May 2021 14:06:25 +0000 (16:06 +0200)]
Use `<span>` instead of `<a>` for jump anchors

3 years agoForce-bump the version number of the bundled jQuery lib
Alexander Ebert [Mon, 10 May 2021 14:02:49 +0000 (16:02 +0200)]
Force-bump the version number of the bundled jQuery lib

3 years agoAdd missing import
Matthias Schmidt [Mon, 10 May 2021 13:53:54 +0000 (15:53 +0200)]
Add missing import

3 years agoRemove unused import
Matthias Schmidt [Mon, 10 May 2021 13:51:03 +0000 (15:51 +0200)]
Remove unused import

3 years agoRemove unused local variables
Matthias Schmidt [Mon, 10 May 2021 13:50:37 +0000 (15:50 +0200)]
Remove unused local variables

3 years agoConsistenly use “Notfall-Codes” in de.xml
Tim Düsterhus [Mon, 10 May 2021 13:32:17 +0000 (15:32 +0200)]
Consistenly use “Notfall-Codes” in de.xml

3 years agoIncorrect width value for OG images
Alexander Ebert [Mon, 10 May 2021 12:55:21 +0000 (14:55 +0200)]
Incorrect width value for OG images

3 years agoInclude favico.js in WoltLabSuite.Core.min.js
Tim Düsterhus [Mon, 10 May 2021 12:04:24 +0000 (14:04 +0200)]
Include favico.js in WoltLabSuite.Core.min.js

Resolves #4198

3 years agoMerge branch 'master' of https://github.com/WoltLab/WCF
Alexander Ebert [Mon, 10 May 2021 11:57:51 +0000 (13:57 +0200)]
Merge branch 'master' of https://github.com/WoltLab/WCF

3 years agoBetter support for the 2:1 aspect ratio of OG images
Alexander Ebert [Mon, 10 May 2021 11:57:45 +0000 (13:57 +0200)]
Better support for the 2:1 aspect ratio of OG images

3 years agoAdjust layout of recipient column in emailLogList
Tim Düsterhus [Mon, 10 May 2021 11:34:57 +0000 (13:34 +0200)]
Adjust layout of recipient column in emailLogList

3 years agoLoad the page logo immediately
Alexander Ebert [Mon, 10 May 2021 11:45:52 +0000 (13:45 +0200)]
Load the page logo immediately

3 years agoMerge branch '5.3'
Matthias Schmidt [Mon, 10 May 2021 10:29:00 +0000 (12:29 +0200)]
Merge branch '5.3'

3 years agoAdd missing template events for monolingual pages
Matthias Schmidt [Mon, 10 May 2021 10:28:01 +0000 (12:28 +0200)]
Add missing template events for monolingual pages

See #3268

3 years agoFix position of `messageFieldsMultilingual` event in `pageAdd.tpl`
Matthias Schmidt [Mon, 10 May 2021 10:25:59 +0000 (12:25 +0200)]
Fix position of `messageFieldsMultilingual` event in `pageAdd.tpl`

The message tabs have to be below the relevant WYSIWYG editor. Inserting additional fields at this position would split them apart.

3 years agoFix breaking of words in email subject
Tim Düsterhus [Mon, 10 May 2021 10:25:38 +0000 (12:25 +0200)]
Fix breaking of words in email subject

Apparently I forgot to `git add` this change.

Fixes 39ad16436abd190e175dc9599080c6f64c24d02b.

3 years agoBreak words in subject truncation of email log
Tim Düsterhus [Mon, 10 May 2021 10:18:08 +0000 (12:18 +0200)]
Break words in subject truncation of email log

3 years agoMerge branch '5.3'
Matthias Schmidt [Mon, 10 May 2021 10:19:46 +0000 (12:19 +0200)]
Merge branch '5.3'

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Mon, 10 May 2021 10:19:35 +0000 (12:19 +0200)]
Merge branch '5.2' into 5.3

3 years agoAdd missing `license` element in `package.xsd`
Matthias Schmidt [Mon, 10 May 2021 10:19:22 +0000 (12:19 +0200)]
Add missing `license` element in `package.xsd`

3 years agoFix inserting multiple media files via clipboard
Matthias Schmidt [Mon, 10 May 2021 07:55:48 +0000 (09:55 +0200)]
Fix inserting multiple media files via clipboard

See 57324f3a91d806572be58cc6b3e7fb169fc26580