Matthias Schmidt [Fri, 7 May 2021 10:07:57 +0000 (12:07 +0200)]
Fix deleting content from moderation activation page
Matthias Schmidt [Fri, 7 May 2021 10:01:41 +0000 (12:01 +0200)]
Remove obsolete commented-out code (#4200)
All code has been commented out for at least 5 years, some code even from the very beginning.
Close #4139
Matthias Schmidt [Fri, 7 May 2021 07:36:29 +0000 (09:36 +0200)]
Add missing default values of `PasswordStrength` properties
Matthias Schmidt [Fri, 7 May 2021 07:25:08 +0000 (09:25 +0200)]
Use ignore dialog for list of ignored users (#4199)
Close #4140
Matthias Schmidt [Fri, 7 May 2021 05:49:15 +0000 (07:49 +0200)]
Support form builder dependencies with non-Core templates
Alexander Ebert [Thu, 6 May 2021 14:30:33 +0000 (16:30 +0200)]
Visual adjustments for 2FA methods
Alexander Ebert [Thu, 6 May 2021 13:58:03 +0000 (15:58 +0200)]
Explicit font-display behavior for the icon font
Matthias Schmidt [Thu, 6 May 2021 12:02:42 +0000 (14:02 +0200)]
Reset package field in language import form after saving
Close #4191
Matthias Schmidt [Thu, 6 May 2021 12:00:37 +0000 (14:00 +0200)]
Merge branch '5.3'
Matthias Schmidt [Thu, 6 May 2021 11:59:48 +0000 (13:59 +0200)]
Merge branch '5.2' into 5.3
Matthias Schmidt [Thu, 6 May 2021 11:59:35 +0000 (13:59 +0200)]
Merge branch '3.1' into 5.2
Matthias Schmidt [Thu, 6 May 2021 11:59:21 +0000 (13:59 +0200)]
Reset language form field in language import form after saving
Matthias Schmidt [Thu, 6 May 2021 11:54:59 +0000 (13:54 +0200)]
Fix JavaScript code for is-not-clicked form builder dependency
Close #4194
Matthias Schmidt [Thu, 6 May 2021 08:06:43 +0000 (10:06 +0200)]
Fix deleting content from moderation report page
Close WoltLab/com.woltlab.wbb#461
Tim Düsterhus [Wed, 5 May 2021 14:58:11 +0000 (16:58 +0200)]
Merge pull request #4190 from WoltLab/stacktrace-sanitizer-no-arg
Make argument sanitization more resilient
Tim Düsterhus [Wed, 5 May 2021 14:49:00 +0000 (16:49 +0200)]
Catch exceptions during argument sanitization in sanitizeStacktrace()
The sanitization logic is somewhat fragile. Redact all arguments of the current
stack frame if some error occurs to fail closed.
Tim Düsterhus [Wed, 5 May 2021 14:44:11 +0000 (16:44 +0200)]
Split long condition over multiple lines in sanitizeStacktrace()
Tim Düsterhus [Wed, 5 May 2021 14:42:48 +0000 (16:42 +0200)]
Skip argument sanitization when argument list is empty
There is no need to invoke heavy-weight reflection if nothing is to be
sanitized.
Tim Düsterhus [Wed, 5 May 2021 14:38:43 +0000 (16:38 +0200)]
Merge pull request #4189 from WoltLab/message-id
Add Message-ID to MFA emails
Alexander Ebert [Wed, 5 May 2021 13:52:49 +0000 (15:52 +0200)]
Preserve the aspect ratio for scaled images
Specifying an explicit height requires `height: auto` to be set via CSS, otherwise scaling through `max-width: 100%` does not preserve the image's aspect ratio.
Tim Düsterhus [Wed, 5 May 2021 13:03:51 +0000 (15:03 +0200)]
Set explicit Message-ID in EmailMultifactorMethod::sendEmail()
Tim Düsterhus [Wed, 5 May 2021 13:00:41 +0000 (15:00 +0200)]
Set explicit Message-ID in BackupMultifactorMethod::sendAuthenticationEmail()
Tim Düsterhus [Wed, 5 May 2021 12:58:34 +0000 (14:58 +0200)]
Set explicit Message-ID in MultifactorManageForm::sendEmail()
Tim Düsterhus [Wed, 5 May 2021 12:58:19 +0000 (14:58 +0200)]
Add SimpleEmail::setMessageID()
Tim Düsterhus [Wed, 5 May 2021 11:27:23 +0000 (13:27 +0200)]
Fix setting of the long-lived cookie after login
Tim Düsterhus [Wed, 5 May 2021 10:53:09 +0000 (12:53 +0200)]
Fix typo in avatar condition in UserRebuildDataWorker
Alexander Ebert [Wed, 5 May 2021 09:46:55 +0000 (11:46 +0200)]
Release 5.4.0 Alpha 1
Tim Düsterhus [Tue, 4 May 2021 13:02:15 +0000 (15:02 +0200)]
Merge pull request #4185 from WoltLab/acp-legacy-session
Suppress legacy session for ACP activity
Tim Düsterhus [Tue, 4 May 2021 12:52:36 +0000 (14:52 +0200)]
Suppress legacy session for ACP activity
Even if the actual locations are hidden this might leak information about ACP
activity.
Tim Düsterhus [Tue, 4 May 2021 12:15:45 +0000 (14:15 +0200)]
Merge pull request #4184 from WoltLab/sensitive-argument
Add SensitiveArgument attribute
Tim Düsterhus [Tue, 4 May 2021 12:12:47 +0000 (14:12 +0200)]
Improve variable name in sanitizeStacktrace()
Matthias Schmidt [Tue, 4 May 2021 11:37:14 +0000 (13:37 +0200)]
Export IP addresses stored with filebase versions
See WoltLab/com.woltlab.filebase#146
Tim Düsterhus [Tue, 4 May 2021 10:36:32 +0000 (12:36 +0200)]
Add files_pre.tar and files_pre_check.tar
WoltLab [Tue, 4 May 2021 10:35:55 +0000 (10:35 +0000)]
Updating minified JavaScript files
Tim Düsterhus [Tue, 4 May 2021 07:51:58 +0000 (09:51 +0200)]
Make use of \wcf\SensitiveArgument attribute
Tim Düsterhus [Tue, 4 May 2021 09:52:44 +0000 (11:52 +0200)]
Consider parameters with password|passphrase|secret in their name to be sensitive
Tim Düsterhus [Tue, 4 May 2021 07:51:44 +0000 (09:51 +0200)]
Add \wcf\SensitiveArgument attribute
Matthias Schmidt [Tue, 4 May 2021 09:05:52 +0000 (11:05 +0200)]
Pin `php-cs-fixer` version in codestyle workflow
Tim Düsterhus [Mon, 3 May 2021 13:52:03 +0000 (15:52 +0200)]
Add userOption PIP to upgrade instructions
Tim Düsterhus [Mon, 3 May 2021 12:55:03 +0000 (14:55 +0200)]
Merge pull request #4181 from WoltLab/empty-phrase
Delete the empty phrase during update from 5.3 to 5.4
Tim Düsterhus [Mon, 3 May 2021 12:50:02 +0000 (14:50 +0200)]
Delete the empty phrase during update from 5.3 to 5.4
see
9e280cb5c1dd3e398a3096b55f6d88be4baa6923
see https://community.woltlab.com/thread/289955/
Alexander Ebert [Mon, 3 May 2021 10:51:01 +0000 (12:51 +0200)]
Merge pull request #4174 from WoltLab/new-app-management
Simplify the domain and landing page management
Alexander Ebert [Mon, 3 May 2021 10:37:52 +0000 (12:37 +0200)]
Improved the code / Cleanup
Matthias Schmidt [Mon, 3 May 2021 10:34:13 +0000 (12:34 +0200)]
Merge branch '5.3'
Matthias Schmidt [Mon, 3 May 2021 10:30:15 +0000 (12:30 +0200)]
Merge branch '5.2' into 5.3
Matthias Schmidt [Mon, 3 May 2021 10:30:07 +0000 (12:30 +0200)]
Merge branch '3.1' into 5.2
Matthias Schmidt [Mon, 3 May 2021 10:29:48 +0000 (12:29 +0200)]
Fix detection of nested tables in messages
Close #4175
Matthias Schmidt [Mon, 3 May 2021 10:27:17 +0000 (12:27 +0200)]
Fix table borders when cells with `rowspan` are visually in the last row (#4176)
See https://community.woltlab.com/thread/289598
Tim Düsterhus [Mon, 3 May 2021 09:39:07 +0000 (11:39 +0200)]
Merge pull request #4177 from WoltLab/varchar-unique
Reduce the length of MFA VARCHAR columns used in UNIQUE KEY
Tim Düsterhus [Mon, 3 May 2021 09:35:08 +0000 (11:35 +0200)]
Reduce the length of MFA VARCHAR columns used in UNIQUE KEY
Fixes #4171
Alexander Ebert [Sun, 2 May 2021 11:45:33 +0000 (13:45 +0200)]
Incorrect formatting
Alexander Ebert [Sun, 2 May 2021 10:12:12 +0000 (12:12 +0200)]
Implement `Dom/Util.innerSuccess()`
Closes #4170
Alexander Ebert [Sun, 2 May 2021 10:00:12 +0000 (12:00 +0200)]
Simplify the domain and landing page management
joshuaruesweg [Sat, 1 May 2021 13:05:02 +0000 (15:05 +0200)]
Merge branch '5.3'
joshuaruesweg [Sat, 1 May 2021 13:02:08 +0000 (15:02 +0200)]
Fix undefined class variable
Fixes #4163
Sascha Moser [Fri, 30 Apr 2021 14:47:26 +0000 (16:47 +0200)]
Include freshping as spider (#4165)
Freshping is a monitoring alternative to uptime robot.
Useragent: FreshpingBot/1.0 (+https://freshping.io/)
joshuaruesweg [Fri, 30 Apr 2021 12:55:02 +0000 (14:55 +0200)]
Merge branch '5.3'
joshuaruesweg [Fri, 30 Apr 2021 12:48:57 +0000 (14:48 +0200)]
Fix collision for comment react button and comment response react button
The comment react button can bind onto the comment response react button, if there is no comment react button (e.g. because the comment author is the user themselves). Using an own `buttonSelector` for the comment response react button, fixes the problem.
Note: The problem only becomes visible if there is only one reaction (so WoltLab Suite uses the legacy like mode).
Tim Düsterhus [Fri, 30 Apr 2021 11:43:48 +0000 (13:43 +0200)]
Merge pull request #4169 from WoltLab/trophy-lazy
Lazily load trophy images
Tim Düsterhus [Fri, 30 Apr 2021 10:48:06 +0000 (12:48 +0200)]
Lazily load trophy images
see #3980
Tim Düsterhus [Fri, 30 Apr 2021 10:47:37 +0000 (12:47 +0200)]
Use width / height attributes instead of inline CSS in trophyImage.tpl
Tim Düsterhus [Fri, 30 Apr 2021 09:28:22 +0000 (11:28 +0200)]
Remove unused requirement from extra/compiler.js
Tim Düsterhus [Fri, 30 Apr 2021 09:14:41 +0000 (11:14 +0200)]
Merge pull request #4167 from WoltLab/hidden-password-toggle
Fix the password toggle from showing up for the fake input in option.tpl
Tim Düsterhus [Fri, 30 Apr 2021 09:09:50 +0000 (11:09 +0200)]
Add UnfurlResponse::$body property
Resolves #4162
Tim Düsterhus [Fri, 30 Apr 2021 09:08:19 +0000 (11:08 +0200)]
Adjust user-Agent comment for URL Unfurling
Matthias Schmidt [Fri, 30 Apr 2021 08:12:33 +0000 (10:12 +0200)]
Decrease default width of password form fields
See #4148
Tim Düsterhus [Fri, 30 Apr 2021 08:05:00 +0000 (10:05 +0200)]
Fix the password toggle from showing up for the fake input in option.tpl
Fixes #4040
Matthias Schmidt [Fri, 30 Apr 2021 06:00:22 +0000 (08:00 +0200)]
Use null coalescing operator wherever possible
Alexander Ebert [Thu, 29 Apr 2021 16:39:08 +0000 (18:39 +0200)]
Merge pull request #4166 from WoltLab/null-coalescing-operator
Use null coalescing operator wherever possible
Matthias Schmidt [Thu, 29 Apr 2021 12:53:40 +0000 (14:53 +0200)]
Use null coalescing operator wherever possible
These changes were not done manually but by using IDE actions.
Matthias Schmidt [Thu, 29 Apr 2021 12:28:22 +0000 (14:28 +0200)]
Remove obsolete delete instructions
Tim Düsterhus [Thu, 29 Apr 2021 12:21:10 +0000 (14:21 +0200)]
Fix typo in en.xml
Tim Düsterhus [Thu, 29 Apr 2021 07:39:33 +0000 (09:39 +0200)]
Merge branch '5.3'
Tim Düsterhus [Thu, 29 Apr 2021 07:38:05 +0000 (09:38 +0200)]
Fix typo in NewPasswordForm
Fixes #4164
Matthias Schmidt [Thu, 29 Apr 2021 05:52:55 +0000 (07:52 +0200)]
Remove obsolete code in `BlacklistEntryAction`
`$entries` does not exist.
WoltLab [Wed, 28 Apr 2021 15:14:03 +0000 (15:14 +0000)]
Updating minified JavaScript files
Tim Düsterhus [Wed, 28 Apr 2021 13:08:31 +0000 (15:08 +0200)]
Fix preload finder regex in StyleCompiler::extractPreloadRequests()
The previous one did not match preload requests without a trailing semicolon, because a closing brace immediately follows.
Tim Düsterhus [Wed, 28 Apr 2021 09:09:57 +0000 (11:09 +0200)]
Merge pull request #4159 from WoltLab/media-importer
Improve MediaImporter
Tim Düsterhus [Wed, 28 Apr 2021 08:49:32 +0000 (10:49 +0200)]
Do not trust the source database in MediaImporter
Resolves #4154
Tim Düsterhus [Wed, 28 Apr 2021 08:48:33 +0000 (10:48 +0200)]
Check whether the media file is readable in MediaImporter
Matthias Schmidt [Tue, 27 Apr 2021 15:15:28 +0000 (17:15 +0200)]
Merge branch '5.3'
Matthias Schmidt [Tue, 27 Apr 2021 15:11:22 +0000 (17:11 +0200)]
Merge branch '5.2' into 5.3
Matthias Schmidt [Tue, 27 Apr 2021 15:11:03 +0000 (17:11 +0200)]
Add missing return value of `readValue()` of DevTools project form fields
Matthias Schmidt [Tue, 27 Apr 2021 15:04:15 +0000 (17:04 +0200)]
Add explicit `return null;` statements
Tim Düsterhus [Tue, 27 Apr 2021 14:40:10 +0000 (16:40 +0200)]
Merge pull request #4157 from WoltLab/attachment-lazy
Lazily load attachments
Tim Düsterhus [Tue, 27 Apr 2021 14:17:38 +0000 (16:17 +0200)]
Lazily load attachments
see #3980
Tim Düsterhus [Tue, 27 Apr 2021 14:16:56 +0000 (16:16 +0200)]
Add width / height to attachments in attachments.tpl
Tim Düsterhus [Tue, 27 Apr 2021 14:07:24 +0000 (16:07 +0200)]
Specify loading="eager" for smileys
see #3980
Tim Düsterhus [Tue, 27 Apr 2021 14:06:33 +0000 (16:06 +0200)]
Merge pull request #4156 from WoltLab/smiley-html
Delegate smiley HTML generation in HtmlOutputNodeImg to Smiley::getHtml()
Tim Düsterhus [Tue, 27 Apr 2021 12:49:22 +0000 (14:49 +0200)]
Delegate smiley HTML generation in HtmlOutputNodeImg to Smiley::getHtml()
Resolves #4153
Tim Düsterhus [Tue, 27 Apr 2021 12:09:36 +0000 (14:09 +0200)]
Remove thumbnail generation from MediaImporter
This is useless, because it can be performed using MediaRebuildDataWorker. It
might also break the import process for borked source images.
see
44f9dba4c98359b53679cdac3bb43982e716a7e1
Tim Düsterhus [Tue, 27 Apr 2021 09:33:55 +0000 (11:33 +0200)]
Fix table containing TOTP devices overflowing the viewport on mobile
Matthias Schmidt [Tue, 27 Apr 2021 08:31:17 +0000 (10:31 +0200)]
Fix file check of `database` instruction when using DevTools
Tim Düsterhus [Tue, 27 Apr 2021 07:15:37 +0000 (09:15 +0200)]
Merge pull request #4152 from WoltLab/attachment-dimensions
Cleanup dimension attributes in AttachmentBBCode
Tim Düsterhus [Mon, 26 Apr 2021 14:51:29 +0000 (16:51 +0200)]
Use width / height attributes for attachments instead of inline CSS
This plays more nicely with a hypothetical future content security policy and
is more consistent with other places.
Tim Düsterhus [Mon, 26 Apr 2021 14:49:59 +0000 (16:49 +0200)]
Add explicit width / height to full size image attachments
Tim Düsterhus [Mon, 26 Apr 2021 14:48:42 +0000 (16:48 +0200)]
Improve IDE support in AttachmentBBCode
Matthias Schmidt [Mon, 26 Apr 2021 14:38:53 +0000 (16:38 +0200)]
Fix code style issue
Matthias Schmidt [Mon, 26 Apr 2021 14:32:07 +0000 (16:32 +0200)]
Fix handling of standalone instruction attribute in DevTools
Matthias Schmidt [Mon, 26 Apr 2021 14:22:00 +0000 (16:22 +0200)]
Merge branch '5.3'