workqueue: implicit ordered attribute should be overridable
authorTejun Heo <tj@kernel.org>
Sun, 23 Jul 2017 12:36:15 +0000 (08:36 -0400)
committerWilly Tarreau <w@1wt.eu>
Thu, 2 Nov 2017 09:45:58 +0000 (10:45 +0100)
commit162f50e6914ff75f11d15e52507aa88875878fd8
tree0300728c1598b5469dff7556d80ea13ca5046748
parentef6fa3f56c073d7d136f7a318088a030c904f4aa
workqueue: implicit ordered attribute should be overridable

commit 0a94efb5acbb6980d7c9ab604372d93cd507e4d8 upstream.

5c0338c68706 ("workqueue: restore WQ_UNBOUND/max_active==1 to be
ordered") automatically enabled ordered attribute for unbound
workqueues w/ max_active == 1.  Because ordered workqueues reject
max_active and some attribute changes, this implicit ordered mode
broke cases where the user creates an unbound workqueue w/ max_active
== 1 and later explicitly changes the related attributes.

This patch distinguishes explicit and implicit ordered setting and
overrides from attribute changes if implict.

Signed-off-by: Tejun Heo <tj@kernel.org>
Fixes: 5c0338c68706 ("workqueue: restore WQ_UNBOUND/max_active==1 to be ordered")
Cc: Holger Hoffstätte <holger@applied-asynchrony.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Willy Tarreau <w@1wt.eu>
include/linux/workqueue.h
kernel/workqueue.c