net: ping: do not abuse udp_poll()
authorEric Dumazet <edumazet@google.com>
Sat, 3 Jun 2017 16:29:25 +0000 (09:29 -0700)
committerWilly Tarreau <w@1wt.eu>
Thu, 2 Nov 2017 06:16:25 +0000 (07:16 +0100)
commitf7eb769a8db069e8a999cea74457c24d813b7c38
treef06b586475389a9b03b1e7197a9875ee7ea529a8
parentca58e3129147cd80996c9a7cde5faee28f9981ec
net: ping: do not abuse udp_poll()

commit 77d4b1d36926a9b8387c6b53eeba42bcaaffcea3 upstream.

Alexander reported various KASAN messages triggered in recent kernels

The problem is that ping sockets should not use udp_poll() in the first
place, and recent changes in UDP stack finally exposed this old bug.

Fixes: c319b4d76b9e ("net: ipv4: add IPPROTO_ICMP socket kind")
Fixes: 6d0bfe226116 ("net: ipv6: Add IPv6 support to the ping socket.")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Sasha Levin <alexander.levin@verizon.com>
Cc: Solar Designer <solar@openwall.com>
Cc: Vasiliy Kulikov <segoon@openwall.com>
Cc: Lorenzo Colitti <lorenzo@google.com>
Acked-By: Lorenzo Colitti <lorenzo@google.com>
Tested-By: Lorenzo Colitti <lorenzo@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
[wt: removed the parts related to ping6 as 6d0bfe226116 is not in 3.10]

Signed-off-by: Willy Tarreau <w@1wt.eu>
include/net/ipv6.h
net/ipv4/af_inet.c
net/ipv6/raw.c