Bluetooth: btmrvl: fix thread stopping race
authorDaniel Drake <dsd@laptop.org>
Tue, 11 Jun 2013 19:40:20 +0000 (15:40 -0400)
committerJohn W. Linville <linville@tuxdriver.com>
Thu, 13 Jun 2013 17:05:40 +0000 (13:05 -0400)
commitea05fea9042620ac3b8ab9a3e5e4d2ed80c89244
treea5f6856405fb195854847a660c50d51bbcacaf1f
parent59f45d576a0715026d1919ab8a12047616204656
Bluetooth: btmrvl: fix thread stopping race

There is currently a race condition in the btmrvl_remove_card() which
is causing hangs on suspend for OLPC. When the race occurs,
kthread_stop() never returns.

The problem is that btmrvl_service_main_thread() calls kthread_should_stop()
and then does a fair number of things before restarting the loop and
sleeping.

If the thread gets stopped after kthread_should_stop() is checked, but
before the sleep happens, the thread will go to sleep and won't necessarily
be woken up.

Move the kthread_should_stop() check into a race-free place.

Signed-off-by: Daniel Drake <dsd@laptop.org>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/bluetooth/btmrvl_main.c