ipv6: check return value of ipv6_get_lladdr
authorHannes Frederic Sowa <hannes@stressinduktion.org>
Mon, 24 Jun 2013 19:42:40 +0000 (21:42 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 25 Jun 2013 23:27:28 +0000 (16:27 -0700)
commitdc8482926e2b1006ed6962ac8388cb92aed4efc7
treec4d2ff3316fbc20cb942e7ea443f4c88f60a70ab
parent4c7ab054ab4f5d63625508ed6f8a607184cae7c2
ipv6: check return value of ipv6_get_lladdr

We should check the return value of ipv6_get_lladdr in inet6_set_iftoken.

A possible situation, which could leave ll_addr unassigned is, when
the user removed her link-local address but a global scoped address was
already set. In this case the interface would still be IF_READY and not
dead. In that case the RS source address is some value from the stack.

v2: Daniel Borkmann noted a small indent inconstancy; no semantic
changes.

Cc: Daniel Borkmann <dborkman@redhat.com>
Acked-by: Daniel Borkmann <dborkman@redhat.com>
Reviewed-by: Flavio Leitner <fbl@redhat.com>
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/addrconf.c