Bluetooth: Fix leak of uninitialized data to userspace
authorVegard Nossum <vegard.nossum@gmail.com>
Sun, 30 Nov 2008 11:17:19 +0000 (12:17 +0100)
committerMarcel Holtmann <marcel@holtmann.org>
Sun, 30 Nov 2008 11:17:19 +0000 (12:17 +0100)
commitc6bf514c6e0171c5b731beffaa0c4463e2335f3d
treea7a2a7ac9f39175173b1835901e9763762adddd8
parent7644d63d1348ec044ccd8f775fefe5eb7cbcac69
Bluetooth: Fix leak of uninitialized data to userspace

    struct hci_dev_list_req {
            __u16  dev_num;
            struct hci_dev_req dev_req[0];  /* hci_dev_req structures */
    };

sizeof(struct hci_dev_list_req) == 4, so the two bytes immediately
following "dev_num" will never be initialized. When this structure
is copied to userspace, these uninitialized bytes are leaked.

Fix by using kzalloc() instead of kmalloc(). Found using kmemcheck.

Signed-off-by: Vegard Nossum <vegard.nossum@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
net/bluetooth/hci_core.c