ALSA: hda - Fix unbalanced runtime PM notification at resume
authorTakashi Iwai <tiwai@suse.de>
Wed, 20 Nov 2013 11:15:07 +0000 (12:15 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 29 Nov 2013 19:11:47 +0000 (11:11 -0800)
commitc3bd14e68a1d4eaabbac84a3a28288a3bf13f9f6
tree93cca759fc5447eae94c8832984374645924ac53
parent7088cd2da7489d71a6b5d569899f8af3f85247c4
ALSA: hda - Fix unbalanced runtime PM notification at resume

commit 0fc28fc030a85aa3d6d14e9e9fca0c8237c9ffb5 upstream.

When a codec is resumed, it keeps the power on while the resuming
phase via hda_keep_power_on(), then turns down via
snd_hda_power_down().  At that point, snd_hda_power_down() notifies
the power down to the controller, and this may confuse the refcount if
the codec was already powered up before the resume.

In the end result, the controller goes to runtime suspend even before
the codec is kicked off to the power save, and the communication
stalls happens.

The fix is to add the power-up notification together with
hda_keep_power_on(), and clears the flag appropriately.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/pci/hda/hda_codec.c