[SCSI] fix oops in scsi_run_queue()
authorJames Bottomley <James.Bottomley@suse.de>
Sun, 1 May 2011 14:42:07 +0000 (09:42 -0500)
committerJames Bottomley <James.Bottomley@suse.de>
Tue, 3 May 2011 20:30:00 +0000 (15:30 -0500)
commitc055f5b2614b4f758ae6cc86733f31fa4c2c5844
tree9c4e094c66454e855c52da7e37c6c7fa73a4bfe4
parent3fd9952df4964fac7d5868ba48eadcc9dae3ba46
[SCSI] fix oops in scsi_run_queue()

The recent commit closing the race window in device teardown:

commit 86cbfb5607d4b81b1a993ff689bbd2addd5d3a9b
Author: James Bottomley <James.Bottomley@suse.de>
Date:   Fri Apr 22 10:39:59 2011 -0500

    [SCSI] put stricter guards on queue dead checks

is causing a potential NULL deref in scsi_run_queue() because the
q->queuedata may already be NULL by the time this function is called.
Since we shouldn't be running a queue that is being torn down, simply
add a NULL check in scsi_run_queue() to forestall this.

Tested-by: Jim Schutt <jaschut@sandia.gov>
Cc: stable@kernel.org
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/scsi_lib.c