bridge: dont send notification when skb->len == 0 in rtnl_bridge_notify
authorRoopa Prabhu <roopa@cumulusnetworks.com>
Thu, 29 Jan 2015 00:23:11 +0000 (16:23 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Feb 2015 01:48:48 +0000 (17:48 -0800)
commitb4faf21b76b2a0cf00e5a75e73efb22a09868b18
tree734e02603da6a2e10a31fe650251d66a20a351d2
parent650a7901c0fe0c3b0e5d9c1c945f140058585a6f
bridge: dont send notification when skb->len == 0 in rtnl_bridge_notify

[ Upstream commit 59ccaaaa49b5b096cdc1f16706a9f931416b2332 ]

Reported in: https://bugzilla.kernel.org/show_bug.cgi?id=92081

This patch avoids calling rtnl_notify if the device ndo_bridge_getlink
handler does not return any bytes in the skb.

Alternately, the skb->len check can be moved inside rtnl_notify.

For the bridge vlan case described in 92081, there is also a fix needed
in bridge driver to generate a proper notification. Will fix that in
subsequent patch.

v2: rebase patch on net tree

Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/core/rtnetlink.c