Revert "md/raid5: For odirect-write performance, do not set STRIPE_PREREAD_ACTIVE."
authorNeilBrown <neilb@suse.de>
Wed, 19 Sep 2012 02:48:30 +0000 (12:48 +1000)
committerNeilBrown <neilb@suse.de>
Wed, 19 Sep 2012 02:48:30 +0000 (12:48 +1000)
commita852d7b8a0cf29499905c9243fa6d3fb93898b82
tree006200722d6313f3ed8680c2fee6bd8d66a9de91
parent55d512e245bc7699a8800e23df1a24195dd08217
Revert "md/raid5: For odirect-write performance, do not set STRIPE_PREREAD_ACTIVE."

This reverts commit 895e3c5c58a80bb9e4e05d9ac38b4f30e0f97d80.

While this patch seemed like a good idea and did help some workloads,
it hurts other workloads.
Large sequential O_DIRECT writes were faster,
Small random O_DIRECT writes were slower.

Other changes (batching RAID5 writes) have improved the sequential
writes using a different mechanism, so the net result of this patch
is definitely negative.  So revert it.

Reported-by: Shaohua Li <shli@kernel.org>
Tested-by: Jianpeng Ma <majianpeng@gmail.com>
Signed-off-by: NeilBrown <neilb@suse.de>
drivers/md/raid5.c