regmap: regmap: avoid spurious warning in regmap_read_debugfs
authorRussell King <rmk+kernel@arm.linux.org.uk>
Sat, 26 Jan 2013 11:45:35 +0000 (11:45 +0000)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Sun, 27 Jan 2013 02:45:10 +0000 (10:45 +0800)
commita3471469bcba61f8f18ca4c267b0cdd90a61e035
treecc2cd6329ab62136e902c1fa5f8116337da0036c
parent949db153b6466c6f7cad5a427ecea94985927311
regmap: regmap: avoid spurious warning in regmap_read_debugfs

Gcc warns about the case where regmap_read_debugfs tries to walk an
empty map->debugfs_off_cache list, which would results in uninitialized
variable getting returned, if we hadn't checked the same condition
just before that.

After an originally suggested inferior patch from Arnd Bergmann,
this is the solution that Russell King came up with, sidestepping
the problem by merging the error case for an empty list with the
normal path.

Without this patch, building mxs_defconfig results in:

drivers/base/regmap/regmap-debugfs.c: In function 'regmap_read_debugfs':
drivers/base/regmap/regmap-debugfs.c:147:9: : warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]

Reported-by: Vincent Stehle <v-stehle@ti.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
drivers/base/regmap/regmap-debugfs.c