net: ipv6: fix error return code
authorJulia Lawall <Julia.Lawall@lip6.fr>
Wed, 29 Aug 2012 06:49:12 +0000 (06:49 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 31 Aug 2012 20:27:48 +0000 (16:27 -0400)
commit48f125ce1cc3ff275f9587b5bf56bf0f90766c7d
tree40cc8210126cdb67afffff0b18bf9b82e089cc4e
parentfa026e223df2514b271b20f839ab05d7f21181b9
net: ipv6: fix error return code

Initialize return variable before exiting on an error path.

The initial initialization of the return variable is also dropped, because
that value is never used.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}

// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/esp6.c