inet_diag: fix possible overflow in inet_diag_dump_one_icsk()
authorEric Dumazet <edumazet@google.com>
Fri, 13 Mar 2015 16:49:59 +0000 (09:49 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 26 Mar 2015 14:00:55 +0000 (15:00 +0100)
commit43b93504d1196578a3c48b2f2562e1bfed588a3d
treead09c74b786d966cde44c01a8e4d0d4493ef0e45
parent895652af317379b0347353b00bca9d1bb26335bb
inet_diag: fix possible overflow in inet_diag_dump_one_icsk()

[ Upstream commit c8e2c80d7ec00d020320f905822bf49c5ad85250 ]

inet_diag_dump_one_icsk() allocates too small skb.

Add inet_sk_attr_size() helper right before inet_sk_diag_fill()
so that it can be updated if/when new attributes are added.

iproute2/ss currently does not use this dump_one() interface,
this might explain nobody noticed this problem yet.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ipv4/inet_diag.c