USB: serial: keyspan_pda: verify endpoints at probe
authorJohan Hovold <johan@kernel.org>
Tue, 3 Jan 2017 15:39:48 +0000 (16:39 +0100)
committerWilly Tarreau <w@1wt.eu>
Wed, 7 Jun 2017 22:46:50 +0000 (00:46 +0200)
commit1df7c6638a001bbb608e25deb7ce816bd6ffea8a
tree828982a16af609b2cb57cbcfe2461559d0a9d94a
parent18b787dc3785f8ddf8f9702bbcf4a28111301af0
USB: serial: keyspan_pda: verify endpoints at probe

commit 5d9b0f859babe96175cd33d7162a9463a875ffde upstream.

Check for the expected endpoints in attach() and fail loudly if not
present.

Note that failing to do this appears to be benign since da280e348866
("USB: keyspan_pda: clean up write-urb busy handling") which prevents a
NULL-pointer dereference in write() by never marking a non-existent
write-urb as free.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/usb/serial/keyspan_pda.c