Bluetooth: Fix hci core device initialization
authorDavid Herrmann <dh.herrmann@googlemail.com>
Sat, 8 Oct 2011 12:58:47 +0000 (14:58 +0200)
committerGustavo F. Padovan <padovan@profusion.mobi>
Fri, 14 Oct 2011 18:22:28 +0000 (15:22 -0300)
commit0ac7e7002c4d0841197e9ccb8cfecc5b8c58b200
tree5050ba12aedf48b75660ab9175fcae26250cd603
parent928abaa777501ddab94b1b49aae485a2c730d303
Bluetooth: Fix hci core device initialization

We must not call device_del() if we didn't use device_add(). See module.c
for comments on that. Therefore, we need to call device_initialize() when
allocating the hci device and later device_add() instead of
device_register().

This also fixes a bug when hci_register_dev() failed and we call
hci_free_dev() without a valid core device. hci_free_dev() segfaults while
calling put_device() on invalid memory.

We already do this with hci_conn connections (hci_conn_init_sysfs()) so
they do not need to be fixed.

Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
include/net/bluetooth/hci_core.h
net/bluetooth/hci_core.c
net/bluetooth/hci_sysfs.c