tcp: Fix >4GB writes on 64-bit.
authorDavid S. Miller <davem@davemloft.net>
Tue, 28 Sep 2010 03:24:54 +0000 (20:24 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 28 Sep 2010 03:24:54 +0000 (20:24 -0700)
commit01db403cf99f739f86903314a489fb420e0e254f
treebf04fbfb3ed88d6cf7abeea1ab5209be36907882
parent0b20406cda621c2495d10baab1e87127ceb43337
tcp: Fix >4GB writes on 64-bit.

Fixes kernel bugzilla #16603

tcp_sendmsg() truncates iov_len to an 'int' which a 4GB write to write
zero bytes, for example.

There is also the problem higher up of how verify_iovec() works.  It
wants to prevent the total length from looking like an error return
value.

However it does this using 'int', but syscalls return 'long' (and
thus signed 64-bit on 64-bit machines).  So it could trigger
false-positives on 64-bit as written.  So fix it to use 'long'.

Reported-by: Olaf Bonorden <bono@onlinehome.de>
Reported-by: Daniel Büse <dbuese@gmx.de>
Reported-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/socket.h
net/core/iovec.c
net/ipv4/tcp.c