tracing: Do not add event files for modules that fail tracepoints
authorSteven Rostedt (Red Hat) <rostedt@goodmis.org>
Wed, 26 Feb 2014 18:37:38 +0000 (13:37 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Mar 2014 04:38:16 +0000 (21:38 -0700)
commitd6a6d1f38ce55aa5a7d8aab972176660b19fd7ab
treed7df976223802e2eda5fa641717ff568f47903c8
parent1f7dc3c002c02493219f7e6ee5930a30f7a57175
tracing: Do not add event files for modules that fail tracepoints

commit 45ab2813d40d88fc575e753c38478de242d03f88 upstream.

If a module fails to add its tracepoints due to module tainting, do not
create the module event infrastructure in the debugfs directory. As the events
will not work and worse yet, they will silently fail, making the user wonder
why the events they enable do not display anything.

Having a warning on module load and the events not visible to the users
will make the cause of the problem much clearer.

Link: http://lkml.kernel.org/r/20140227154923.265882695@goodmis.org
Fixes: 6d723736e472 "tracing/events: add support for modules to TRACE_EVENT"
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/tracepoint.h
kernel/trace/trace_events.c
kernel/tracepoint.c