ext4: rationalize ext4_extents.h inclusion
authorTheodore Ts'o <tytso@mit.edu>
Wed, 28 Nov 2012 18:03:30 +0000 (13:03 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Wed, 28 Nov 2012 18:03:30 +0000 (13:03 -0500)
commit4a092d737955301da22b9d5e07f5036da821a932
treee0532dda14a20822c61448a395cc60b6803b0f46
parent766f44d46a726cb59f52a75c5c87425a10c4bade
ext4: rationalize ext4_extents.h inclusion

Previously, ext4_extents.h was being included at the end of ext4.h,
which was bad for a number of reasons: (a) it was not being included
in the expected place, and (b) it caused the header to be included
multiple times.  There were #ifdef's to prevent this from causing any
problems, but it still was unnecessary.

By moving the function declarations that were in ext4_extents.h to
ext4.h, which is standard practice for where the function declarations
for the rest of ext4.h can be found, we can remove ext4_extents.h from
being included in ext4.h at all, and then we can only include
ext4_extents.h where it is needed in ext4's source files.

It should be possible to move a few more things into ext4.h, and
further reduce the number of source files that need to #include
ext4_extents.h, but that's a cleanup for another day.

Reported-by: Sachin Kamat <sachin.kamat@linaro.org>
Reported-by: Wei Yongjun <weiyj.lk@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/ext4/ext4.h
fs/ext4/ext4_extents.h
fs/ext4/extents.c
fs/ext4/indirect.c
fs/ext4/migrate.c
fs/ext4/move_extent.c
fs/ext4/page-io.c
fs/ext4/super.c