iscsi-target: Fix iscsit_allocate_se_cmd_for_tmr failure path bugs
authorDan Carpenter <error27@gmail.com>
Sun, 14 Aug 2011 05:35:00 +0000 (22:35 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Mon, 22 Aug 2011 19:26:30 +0000 (19:26 +0000)
commitba7736696341ad4253125055c0c85aa9f42959a0
tree7433fc8fa41e8dd54c56d4eea4a031c0f7d9f780
parent6626a0572657a0945a7b9ccf4a6d6ad1750f9adc
iscsi-target: Fix iscsit_allocate_se_cmd_for_tmr failure path bugs

This patch fixes two bugs in allocation failure handling in
iscsit_allocate_se_cmd_for_tmr():

This first reported by DanC is a free-after call to transport_free_se_cmd(), this
patch drops the transport_free_se_cmd() call all together, as iscsit_release_cmd()
will release existing allocations as expected.

The second is a bug where iscsi_cmd_t was being leaked on a cmd->tmr_req allocation
failure, so make this jump to iscsit_release_cmd() as well.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/iscsi/iscsi_target_util.c