md: always set MD_RECOVERY_INTR when aborting a reshape or other "resync".
authorNeilBrown <neilb@suse.de>
Wed, 28 May 2014 03:39:23 +0000 (13:39 +1000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 11 Jun 2014 19:03:24 +0000 (12:03 -0700)
commitd86a5d297deedda0d991e1216ad8817d2d5a3a2b
treedc3c27f8c4c78a97d23b07d39ca857fe874b8cf3
parentfe01110735379c9b04f25b356f1a1589ecb9227d
md: always set MD_RECOVERY_INTR when aborting a reshape or other "resync".

commit 3991b31ea072b070081ca3bfa860a077eda67de5 upstream.

If mddev->ro is set, md_to_sync will (correctly) abort.
However in that case MD_RECOVERY_INTR isn't set.

If a RESHAPE had been requested, then ->finish_reshape() will be
called and it will think the reshape was successful even though
nothing happened.

Normally a resync will not be requested if ->ro is set, but if an
array is stopped while a reshape is on-going, then when the array is
started, the reshape will be restarted.  If the array is also set
read-only at this point, the reshape will instantly appear to success,
resulting in data corruption.

Consequently, this patch is suitable for any -stable kernel.

Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/md/md.c