RDMA/iwcm: Fix hang in uninterruptible wait on cm_id destroy
authorAnimesh K Trivedi <ATR@zurich.ibm.com>
Tue, 28 Sep 2010 14:44:02 +0000 (14:44 +0000)
committerRoland Dreier <rolandd@cisco.com>
Tue, 12 Oct 2010 03:24:04 +0000 (20:24 -0700)
commit26012f0750dd73348b0a0a680a4bee2715d4a334
tree5e180250d46e74f9116c15503830b1b9a0b1ac50
parent557d0540b96176dc42943e84c88c288f523388ca
RDMA/iwcm: Fix hang in uninterruptible wait on cm_id destroy

A process can get stuck in an uninterruptible wait in the
kernel while destroying a cm_id when iw_cm_connect() fails:

For example, When creation of a PD fails but the user continues with
an attempt to connect to the server without checking the return value,
in iw_cm_connect() a NULL qp is found so the call fails.  However the
IWCM_F_CONNECT_WAIT bit is not cleared.  destroy_cm_id() then waits
forever for IWCM_F_CONNECT_WAIT to be cleared.

The same problem exists on the passive side with the accept call.

Fix this by clearing the bit and waking up any waiters in the
appropriate spots.

Signed-off-by: Animesh Trivedi <atr@zurich.ibm.com>
Acked-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
drivers/infiniband/core/iwcm.c