kbuild: clang: choose GCC_TOOLCHAIN_DIR not on LD
authorNick Desaulniers <ndesaulniers@google.com>
Mon, 11 Feb 2019 19:30:04 +0000 (11:30 -0800)
committerMichael Benedict <michaelbt@live.com>
Sun, 22 Sep 2019 16:23:32 +0000 (02:23 +1000)
commit4cad47189dbc45de5c28b0165d1ff14d3eb3c1c5
tree1cd20b09594969df68bb4b9ac9efc72f427b461c
parentff013918c4300fdfa78d6a483443669532c85d17
kbuild: clang: choose GCC_TOOLCHAIN_DIR not on LD

commit ad15006cc78459d059af56729c4d9bed7c7fd860 upstream.

This causes an issue when trying to build with `make LD=ld.lld` if
ld.lld and the rest of your cross tools aren't in the same directory
(ex. /usr/local/bin) (as is the case for Android's build system), as the
GCC_TOOLCHAIN_DIR then gets set based on `which $(LD)` which will point
where LLVM tools are, not GCC/binutils tools are located.

Instead, select the GCC_TOOLCHAIN_DIR based on another tool provided by
binutils for which LLVM does not provide a substitute for, such as
elfedit.

Fixes: 785f11aa595b ("kbuild: Add better clang cross build support")
Change-Id: I6c5356dee86e2fa7e6b195aba82509c3a876630d
Link: https://github.com/ClangBuiltLinux/linux/issues/341
Suggested-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Tested-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Makefile