netfilter: nf_nat_h323: fix logical-not-parentheses warning
authorNick Desaulniers <ndesaulniers@google.com>
Fri, 11 Aug 2017 18:16:07 +0000 (11:16 -0700)
committerMichael Benedict <michaelbt@live.com>
Sat, 31 Aug 2019 16:28:13 +0000 (02:28 +1000)
commit0fc1e8c752ec5ae6bfcbacfb51804ac2e9f8bfb6
tree0a31e0528105340c855ab1271509320551dd3ce5
parentfb0c632fc650f3e02de7c947e3ab49793e0b98f9
netfilter: nf_nat_h323: fix logical-not-parentheses warning

commit eee6ebbac18a189ef33d25ea9b8bcae176515e49 upstream.

Clang produces the following warning:

net/ipv4/netfilter/nf_nat_h323.c:553:6: error:
logical not is only applied to the left hand side of this comparison
  [-Werror,-Wlogical-not-parentheses]
if (!set_h225_addr(skb, protoff, data, dataoff, taddr,
    ^
add parentheses after the '!' to evaluate the comparison first
add parentheses around left hand side expression to silence this warning

There's not necessarily a bug here, but it's cleaner to return early,
ex:

if (x)
  return
...

rather than:

if (x == 0)
  ...
else
  return

Also added a return code check that seemed to be missing in one
instance.

Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ipv4/netfilter/nf_nat_h323.c