GitHub/WoltLab/WCF.git
3 years agoMerge branch '5.4'
Matthias Schmidt [Wed, 7 Jul 2021 08:25:44 +0000 (10:25 +0200)]
Merge branch '5.4'

3 years agoExplicitly show error message if import queue is empty
Matthias Schmidt [Wed, 7 Jul 2021 08:25:33 +0000 (10:25 +0200)]
Explicitly show error message if import queue is empty

Close #3804
See #4379

3 years agoMerge branch '5.4'
Matthias Schmidt [Wed, 7 Jul 2021 07:06:09 +0000 (09:06 +0200)]
Merge branch '5.4'

3 years agoMerge branch '5.3' into 5.4
Matthias Schmidt [Wed, 7 Jul 2021 07:05:42 +0000 (09:05 +0200)]
Merge branch '5.3' into 5.4

3 years agoFix reading value of `CheckboxFormField`
Matthias Schmidt [Wed, 7 Jul 2021 07:01:14 +0000 (09:01 +0200)]
Fix reading value of `CheckboxFormField`

In contrast to `BooleanFormField` for which an explicit "no" input field exists, a normal checkbox does not submit any data if no checked.

3 years agoMerge pull request #4376 from WoltLab/rebuild-active-app
Tim Düsterhus [Tue, 6 Jul 2021 12:56:59 +0000 (14:56 +0200)]
Merge pull request #4376 from WoltLab/rebuild-active-app

Remove the need to rebuild the active application

3 years agoMerge branch '5.4' of https://github.com/WoltLab/WCF into 5.4
Alexander Ebert [Tue, 6 Jul 2021 12:47:11 +0000 (14:47 +0200)]
Merge branch '5.4' of https://github.com/WoltLab/WCF into 5.4

3 years agoIncorrect type cast to `number`
Alexander Ebert [Tue, 6 Jul 2021 12:47:03 +0000 (14:47 +0200)]
Incorrect type cast to `number`

3 years agoFix conversion of `Dictionary` to `Map` in `Acp/Ui/Menu/Item/Handler`
Matthias Schmidt [Tue, 6 Jul 2021 12:34:01 +0000 (14:34 +0200)]
Fix conversion of `Dictionary` to `Map` in `Acp/Ui/Menu/Item/Handler`

See 2727575fbe8a2ca2fe4a19288c7a982969170882

3 years agoSearch for articles toggled the incorrect container
Alexander Ebert [Tue, 6 Jul 2021 12:33:14 +0000 (14:33 +0200)]
Search for articles toggled the incorrect container

3 years agoExplicitly delete obsolete style logo description phrases
Matthias Schmidt [Tue, 6 Jul 2021 12:26:22 +0000 (14:26 +0200)]
Explicitly delete obsolete style logo description phrases

See dcb0fe8ec9560f4a7905d9fd1241bc72d1a5c337

3 years agoMerge branch '5.4'
Matthias Schmidt [Tue, 6 Jul 2021 12:24:24 +0000 (14:24 +0200)]
Merge branch '5.4'

3 years agoMerge branch '5.3' into 5.4
Matthias Schmidt [Tue, 6 Jul 2021 12:24:10 +0000 (14:24 +0200)]
Merge branch '5.3' into 5.4

3 years agoRemove obsolete style logo upload field descriptions
Matthias Schmidt [Tue, 6 Jul 2021 12:23:51 +0000 (14:23 +0200)]
Remove obsolete style logo upload field descriptions

See #3456

3 years agoMerge pull request #4375 from WoltLab/controller-workaround
Tim Düsterhus [Tue, 6 Jul 2021 11:52:40 +0000 (13:52 +0200)]
Merge pull request #4375 from WoltLab/controller-workaround

Remove old workaround for the upgrade from 2.1 to 3.0

3 years agoMerge pull request #4370 from WoltLab/devtools-api-compat
Tim Düsterhus [Tue, 6 Jul 2021 11:47:30 +0000 (13:47 +0200)]
Merge pull request #4370 from WoltLab/devtools-api-compat

Remove support for the API compatibility tags from dev tools

3 years agoMerge branch '5.4'
Marcel Werk [Tue, 6 Jul 2021 11:15:10 +0000 (13:15 +0200)]
Merge branch '5.4'

3 years agoFixed missing language version for embedded articles
Marcel Werk [Tue, 6 Jul 2021 11:08:46 +0000 (13:08 +0200)]
Fixed missing language version for embedded articles

3 years agoUse temporary variables for `Request` objects in FontManager
Tim Düsterhus [Tue, 6 Jul 2021 10:49:19 +0000 (12:49 +0200)]
Use temporary variables for `Request` objects in FontManager

This is for consistency with other code sending HTTP requests and to shorten
the lines, as one of them exceeded 120 characters.

3 years agoMerge branch '5.4'
Tim Düsterhus [Tue, 6 Jul 2021 10:49:01 +0000 (12:49 +0200)]
Merge branch '5.4'

3 years agoMerge remote-tracking branch 'origin/5.4' into 5.4
Tim Düsterhus [Tue, 6 Jul 2021 10:48:04 +0000 (12:48 +0200)]
Merge remote-tracking branch 'origin/5.4' into 5.4

3 years agoMerge branch '5.3' into 5.4
Tim Düsterhus [Tue, 6 Jul 2021 10:47:52 +0000 (12:47 +0200)]
Merge branch '5.3' into 5.4

3 years agoAdd missing encoding of `$family` in font download requests
Tim Düsterhus [Tue, 6 Jul 2021 10:46:01 +0000 (12:46 +0200)]
Add missing encoding of `$family` in font download requests

3 years agoRemove the need to rebuild the active application
Tim Düsterhus [Tue, 6 Jul 2021 10:11:09 +0000 (12:11 +0200)]
Remove the need to rebuild the active application

Calculating this value live does not come with a relevant performance loss and
simplifies the request handling logic.

3 years agoSimplify extraction of abbreviation for active application check
Tim Düsterhus [Tue, 6 Jul 2021 10:04:55 +0000 (12:04 +0200)]
Simplify extraction of abbreviation for active application check

3 years agoMerge branch '5.4'
Matthias Schmidt [Tue, 6 Jul 2021 09:42:44 +0000 (11:42 +0200)]
Merge branch '5.4'

3 years agoAdd missing since tag for `User::requiresMultifactor()`
Matthias Schmidt [Tue, 6 Jul 2021 09:42:35 +0000 (11:42 +0200)]
Add missing since tag for `User::requiresMultifactor()`

3 years agoMove call to `checkAppEvaluation()` into `handle()`
Tim Düsterhus [Tue, 6 Jul 2021 09:34:17 +0000 (11:34 +0200)]
Move call to `checkAppEvaluation()` into `handle()`

It fits better here to cleanly separate the handling from the building. No
behavioral change was found.

3 years agoMove the check for expired app evaluations into a dedicated method
Tim Düsterhus [Tue, 6 Jul 2021 09:32:06 +0000 (11:32 +0200)]
Move the check for expired app evaluations into a dedicated method

3 years agoMake the evaluation check independent of local variables
Tim Düsterhus [Tue, 6 Jul 2021 09:30:33 +0000 (11:30 +0200)]
Make the evaluation check independent of local variables

3 years agoSimplify extraction of abbreviation for evaluation check
Tim Düsterhus [Tue, 6 Jul 2021 09:29:44 +0000 (11:29 +0200)]
Simplify extraction of abbreviation for evaluation check

3 years agoAdd `@since` to RequestHandler::checkOfflineMode()
Tim Düsterhus [Tue, 6 Jul 2021 09:29:14 +0000 (11:29 +0200)]
Add `@since` to RequestHandler::checkOfflineMode()

see 60fff547e76067211270f9f5eb7da9f257f847fc

3 years agoMove the check for offline mode into a dedicated method
Tim Düsterhus [Tue, 6 Jul 2021 09:19:37 +0000 (11:19 +0200)]
Move the check for offline mode into a dedicated method

3 years agoUse `getActiveRequest()` method in favor of directly accessing the class property
Tim Düsterhus [Tue, 6 Jul 2021 09:21:54 +0000 (11:21 +0200)]
Use `getActiveRequest()` method in favor of directly accessing the class property

3 years agoRemove old workaround for the upgrade from 2.1 to 3.0
Tim Düsterhus [Tue, 6 Jul 2021 09:10:18 +0000 (11:10 +0200)]
Remove old workaround for the upgrade from 2.1 to 3.0

3 years agoUse `isACPRequest()` method in favor of a local variable in RequestHandler::handle()
Tim Düsterhus [Tue, 6 Jul 2021 09:04:44 +0000 (11:04 +0200)]
Use `isACPRequest()` method in favor of a local variable in RequestHandler::handle()

3 years agoRemove unused local variable `$appendSession` in LinkHandler::getLink()
Tim Düsterhus [Tue, 6 Jul 2021 08:58:18 +0000 (10:58 +0200)]
Remove unused local variable `$appendSession` in LinkHandler::getLink()

3 years agoMerge branch '5.4'
Tim Düsterhus [Tue, 6 Jul 2021 08:23:46 +0000 (10:23 +0200)]
Merge branch '5.4'

3 years agoMerge branch '5.3' into 5.4
Tim Düsterhus [Tue, 6 Jul 2021 08:23:25 +0000 (10:23 +0200)]
Merge branch '5.3' into 5.4

3 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Tue, 6 Jul 2021 07:34:53 +0000 (09:34 +0200)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Tim Düsterhus [Tue, 6 Jul 2021 07:34:26 +0000 (09:34 +0200)]
Merge branch '3.1' into 5.2

3 years agoRemove duplicate `class` attribute in cacheList.tpl
Tim Düsterhus [Tue, 6 Jul 2021 07:32:45 +0000 (09:32 +0200)]
Remove duplicate `class` attribute in cacheList.tpl

3 years agoSupport sorting users in `UserOnlineListBoxController` (#4372)
Matthias Schmidt [Tue, 6 Jul 2021 07:12:34 +0000 (09:12 +0200)]
Support sorting users in `UserOnlineListBoxController` (#4372)

Close #4182

3 years agoRemove support for the API compatibility tags from dev tools
Tim Düsterhus [Mon, 5 Jul 2021 14:09:47 +0000 (16:09 +0200)]
Remove support for the API compatibility tags from dev tools

3 years agoRemove obsolete import
Tim Düsterhus [Mon, 5 Jul 2021 14:21:52 +0000 (16:21 +0200)]
Remove obsolete import

3 years agoRemove cleanup of `userID` and `password` cookies
Tim Düsterhus [Mon, 5 Jul 2021 14:00:08 +0000 (16:00 +0200)]
Remove cleanup of `userID` and `password` cookies

They are no longer used as of WoltLab Suite 5.4, however the removal remained
in the code to clean up the browser's cookie store on logout. Remove it, the
cookies will naturally expire in the future.

3 years agoSet `optimize-autoloader: true` in composer.json
Tim Düsterhus [Mon, 5 Jul 2021 13:08:13 +0000 (15:08 +0200)]
Set `optimize-autoloader: true` in composer.json

3 years agoMerge pull request #4369 from WoltLab/composer
Tim Düsterhus [Mon, 5 Jul 2021 13:03:53 +0000 (15:03 +0200)]
Merge pull request #4369 from WoltLab/composer

Update composer dependencies

3 years agoUpdate fileDelete.xml for composer updates
Tim Düsterhus [Mon, 5 Jul 2021 13:00:35 +0000 (15:00 +0200)]
Update fileDelete.xml for composer updates

3 years agoUpdate composer dependencies
Tim Düsterhus [Mon, 5 Jul 2021 12:49:15 +0000 (14:49 +0200)]
Update composer dependencies

3 years agoMerge branch '5.4'
Tim Düsterhus [Mon, 5 Jul 2021 12:19:01 +0000 (14:19 +0200)]
Merge branch '5.4'

3 years agoCheck for WebP support in update_com.woltlab.wcf_5.4_checkSystemRequirements.php
Tim Düsterhus [Mon, 5 Jul 2021 12:18:15 +0000 (14:18 +0200)]
Check for WebP support in update_com.woltlab.wcf_5.4_checkSystemRequirements.php

3 years agoMerge branch '5.3' into 5.4
Tim Düsterhus [Mon, 5 Jul 2021 12:17:29 +0000 (14:17 +0200)]
Merge branch '5.3' into 5.4

3 years agoMerge pull request #4368 from WoltLab/upgrade-check-webp
Tim Düsterhus [Mon, 5 Jul 2021 12:09:42 +0000 (14:09 +0200)]
Merge pull request #4368 from WoltLab/upgrade-check-webp

Add check for GD support to PackageEnableUpgradeOverrideForm

3 years agoAdd check for GD support to PackageEnableUpgradeOverrideForm
Tim Düsterhus [Mon, 5 Jul 2021 11:57:40 +0000 (13:57 +0200)]
Add check for GD support to PackageEnableUpgradeOverrideForm

3 years agoExport `WCFMessageQuoteManager` interface in `Ui/Message/Quote`
Matthias Schmidt [Mon, 5 Jul 2021 10:51:46 +0000 (12:51 +0200)]
Export `WCFMessageQuoteManager` interface in `Ui/Message/Quote`

See #3876

3 years agoMerge branch '5.4'
Tim Düsterhus [Mon, 5 Jul 2021 10:45:51 +0000 (12:45 +0200)]
Merge branch '5.4'

3 years agoMerge branch '5.3' into 5.4
Tim Düsterhus [Mon, 5 Jul 2021 10:45:33 +0000 (12:45 +0200)]
Merge branch '5.3' into 5.4

3 years agoValidate the `actionName` in MessageQuoteAction
Tim Düsterhus [Mon, 5 Jul 2021 10:39:50 +0000 (12:39 +0200)]
Validate the `actionName` in MessageQuoteAction

3 years agoMerge branch '5.4'
Matthias Schmidt [Mon, 5 Jul 2021 09:54:20 +0000 (11:54 +0200)]
Merge branch '5.4'

3 years agoFix adding pages if only one language is available
Matthias Schmidt [Mon, 5 Jul 2021 09:53:05 +0000 (11:53 +0200)]
Fix adding pages if only one language is available

See 128dbea9130f7decfb255d0d6e04f83e291021e6

3 years agoMerge branch '5.4'
Matthias Schmidt [Mon, 5 Jul 2021 09:32:16 +0000 (11:32 +0200)]
Merge branch '5.4'

3 years agoFix code formatting issue
Matthias Schmidt [Mon, 5 Jul 2021 09:32:03 +0000 (11:32 +0200)]
Fix code formatting issue

3 years agoMerge branch '5.4'
Matthias Schmidt [Mon, 5 Jul 2021 09:27:25 +0000 (11:27 +0200)]
Merge branch '5.4'

3 years agoEnsure that app abbreviation is unique before app installation
Matthias Schmidt [Fri, 2 Jul 2021 11:23:40 +0000 (13:23 +0200)]
Ensure that app abbreviation is unique before app installation

Close #4344

3 years agoFix path of database PIP file located in `files_wcf/` for DevTools syncs
Matthias Schmidt [Mon, 5 Jul 2021 09:25:37 +0000 (11:25 +0200)]
Fix path of database PIP file located in `files_wcf/` for DevTools syncs

Close #4359

3 years agoMake renaming columns with PHP DB API idempotent (#4367)
Matthias Schmidt [Mon, 5 Jul 2021 09:15:20 +0000 (11:15 +0200)]
Make renaming columns with PHP DB API idempotent (#4367)

An error message should only be shown if the neither a column with the old name, nor with the name name exists so that after the rename, a second rename is a no-op.

Close #4362
See #3765

3 years agoMerge branch '5.4'
Tim Düsterhus [Mon, 5 Jul 2021 07:57:17 +0000 (09:57 +0200)]
Merge branch '5.4'

3 years agoMerge branch '5.3' into 5.4
Tim Düsterhus [Mon, 5 Jul 2021 07:56:34 +0000 (09:56 +0200)]
Merge branch '5.3' into 5.4

Also applied the second change from #4366.

Co-authored-by: Sascha Greuel <sascha@softcreatr.de>
3 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Mon, 5 Jul 2021 07:54:22 +0000 (09:54 +0200)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Tim Düsterhus [Mon, 5 Jul 2021 07:54:10 +0000 (09:54 +0200)]
Merge branch '3.1' into 5.2

3 years agoFix typo in de.xml
Tim Düsterhus [Mon, 5 Jul 2021 07:53:22 +0000 (09:53 +0200)]
Fix typo in de.xml

Closes #4366

Co-authored-by: Sascha Greuel <sascha@softcreatr.de>
3 years agoAdd missing `@since` to AbstractOauth2Action
Tim Düsterhus [Mon, 5 Jul 2021 07:01:02 +0000 (09:01 +0200)]
Add missing `@since` to AbstractOauth2Action

3 years agoMake AbstractOauth2Action::getHttpClient() non-final
Tim Düsterhus [Sun, 4 Jul 2021 13:35:07 +0000 (15:35 +0200)]
Make AbstractOauth2Action::getHttpClient() non-final

It might be desirable to be able to add custom headers, specifically a custom
`user-agent`, for non-stock IDPs.

3 years agoReplace use of `WCF.Clipboard` with `Controller/Clipboard`
Matthias Schmidt [Fri, 2 Jul 2021 11:37:38 +0000 (13:37 +0200)]
Replace use of `WCF.Clipboard` with `Controller/Clipboard`

See #3876

3 years agoMerge branch '5.4'
Tim Düsterhus [Fri, 2 Jul 2021 10:52:43 +0000 (12:52 +0200)]
Merge branch '5.4'

3 years agoMerge pull request #4356 from WoltLab/user-logged-in
Tim Düsterhus [Fri, 2 Jul 2021 09:28:01 +0000 (11:28 +0200)]
Merge pull request #4356 from WoltLab/user-logged-in

Add UserLoggedIn event and cancel lost password requests upon login

3 years agoAdd cancelLostPasswordRequest to UserAction
Tim Düsterhus [Fri, 2 Jul 2021 08:36:18 +0000 (10:36 +0200)]
Add cancelLostPasswordRequest to UserAction

3 years agoCancel lost password requests when the user logs in
Tim Düsterhus [Thu, 1 Jul 2021 12:59:02 +0000 (14:59 +0200)]
Cancel lost password requests when the user logs in

Resolves #3922

3 years agoImplement the UserLoggedIn event
Tim Düsterhus [Thu, 1 Jul 2021 12:49:34 +0000 (14:49 +0200)]
Implement the UserLoggedIn event

3 years agoAdd a UserLoggedIn event
Tim Düsterhus [Thu, 1 Jul 2021 12:44:02 +0000 (14:44 +0200)]
Add a UserLoggedIn event

3 years agoMerge pull request #4353 from WoltLab/ColorFormField
Matthias Schmidt [Fri, 2 Jul 2021 09:04:28 +0000 (11:04 +0200)]
Merge pull request #4353 from WoltLab/ColorFormField

Modernize color picker and add `ColorFormField`

3 years agoSupport wildcard for category name in `AclFormField` (#4355)
Matthias Schmidt [Fri, 2 Jul 2021 08:37:30 +0000 (10:37 +0200)]
Support wildcard for category name in `AclFormField` (#4355)

3 years agoFix TOTP QR code in dark styles
Tim Düsterhus [Thu, 1 Jul 2021 13:49:00 +0000 (15:49 +0200)]
Fix TOTP QR code in dark styles

3 years agoRelease 5.3.10 5.3.10
Alexander Ebert [Thu, 1 Jul 2021 12:13:27 +0000 (14:13 +0200)]
Release 5.3.10

3 years agoMerge branch '5.4'
Tim Düsterhus [Thu, 1 Jul 2021 09:48:32 +0000 (11:48 +0200)]
Merge branch '5.4'

3 years agoMerge branch '5.3' into 5.4
Tim Düsterhus [Thu, 1 Jul 2021 09:48:22 +0000 (11:48 +0200)]
Merge branch '5.3' into 5.4

3 years agoMerge pull request #4354 from WoltLab/systemcheck-performance
Tim Düsterhus [Thu, 1 Jul 2021 09:41:48 +0000 (11:41 +0200)]
Merge pull request #4354 from WoltLab/systemcheck-performance

Improve performance of SystemCheckPage::validateWritableDirectories()

3 years agoImprove performance of SystemCheckPage::validateWritableDirectories()
Tim Düsterhus [Thu, 1 Jul 2021 09:21:08 +0000 (11:21 +0200)]
Improve performance of SystemCheckPage::validateWritableDirectories()

The previous implementation resulted in a syscall hell for large attachment or
image directories. RecursiveDirectoryIterator requires two syscalls for
directory entry just for iteration and that does not yet include any custom
logic.

Replace the implementation by a simple `glob()`. This is a small behavior
change, as a `*` will only check the files immediately below the directory in
question instead of recursing all the way down. However this likely is what was
intended anyway.

3 years agoUpdating minified JavaScript files
WoltLab [Thu, 1 Jul 2021 08:32:22 +0000 (08:32 +0000)]
Updating minified JavaScript files

3 years agoAdd `ColorFormField`
Matthias Schmidt [Thu, 1 Jul 2021 08:06:15 +0000 (10:06 +0200)]
Add `ColorFormField`

3 years agoAdd new phrases to JavaScript for existing uses of color pickers
Matthias Schmidt [Thu, 1 Jul 2021 08:05:10 +0000 (10:05 +0200)]
Add new phrases to JavaScript for existing uses of color pickers

3 years agoDeprecate `WCF.ColorPicker` in favor of `Ui/Color/Picker`
Matthias Schmidt [Thu, 1 Jul 2021 07:59:25 +0000 (09:59 +0200)]
Deprecate `WCF.ColorPicker` in favor of `Ui/Color/Picker`

3 years agoUpdate `Ui/Color/Picker` to use native TypeScript-based implementation
Matthias Schmidt [Thu, 1 Jul 2021 07:58:43 +0000 (09:58 +0200)]
Update `Ui/Color/Picker` to use native TypeScript-based implementation

Instead of having to implement a color picker ourselves, we delegate the task to the browser by using a `input[type=color]` element. Because this color input does not support transparency, there is an additional `input[type=range]` element for transparency.

3 years agoModified update instructions 5.4.0_RC_1
Alexander Ebert [Wed, 30 Jun 2021 13:15:45 +0000 (15:15 +0200)]
Modified update instructions

3 years agoAdd `ColorUtil.stringToRgba()`
Matthias Schmidt [Wed, 30 Jun 2021 12:02:14 +0000 (14:02 +0200)]
Add `ColorUtil.stringToRgba()`

3 years agoAdd `ColorUtil.isValidColor()`
Matthias Schmidt [Wed, 30 Jun 2021 12:00:23 +0000 (14:00 +0200)]
Add `ColorUtil.isValidColor()`

3 years agoAdd `ColorUtil.rgbaToString()`
Matthias Schmidt [Wed, 30 Jun 2021 11:53:10 +0000 (13:53 +0200)]
Add `ColorUtil.rgbaToString()`

3 years agoAdd `ColorUtil.rgbaToHex()`
Matthias Schmidt [Wed, 30 Jun 2021 11:51:02 +0000 (13:51 +0200)]
Add `ColorUtil.rgbaToHex()`

3 years agoUse `.toString(16)` for `ColorUtil.rgbToHex()`
Matthias Schmidt [Wed, 30 Jun 2021 11:48:45 +0000 (13:48 +0200)]
Use `.toString(16)` for `ColorUtil.rgbToHex()`