Remove unused local variables

[GitHub/WoltLab/WCF.git] / wcfsetup / install / files / lib / system / package / FilesFileHandler.class.php

diff --git a/wcfsetup/install/files/lib/system/package/FilesFileHandler.class.php b/wcfsetup/install/files/lib/system/package/FilesFileHandler.class.php
index 795b8a646a5270852cb2f7450c852c0cc5b4c259..2133591bd0cf84ea12e77b6c74a54568ad6f92e0 100644 (file)
--- a/wcfsetup/install/files/lib/system/package/FilesFileHandler.class.php
+++ b/wcfsetup/install/files/lib/system/package/FilesFileHandler.class.php
@@ -1,5 +1,7 @@
 <?php
+
 namespace wcf\system\package;
+
 use wcf\data\package\Package;
 use wcf\system\database\util\PreparedStatementConditionBuilder;
 use wcf\system\exception\SystemException;
@@ -7,68 +9,71 @@ use wcf\system\WCF;
 
 /**
  * File handler implementation for the installation of regular files.
- * 
- * @author     Matthias Schmidt, Marcel Werk
- * @copyright  2001-2018 WoltLab GmbH
- * @license    GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
- * @package    WoltLabSuite\Core\System\Package
+ *
+ * @author  Matthias Schmidt, Marcel Werk
+ * @copyright   2001-2019 WoltLab GmbH
+ * @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
+ * @package WoltLabSuite\Core\System\Package
  */
-class FilesFileHandler extends PackageInstallationFileHandler {
-       /**
-        * @inheritDoc
-        */
-       public function checkFiles(array $files) {
-               if ($this->packageInstallation->getPackage()->package != 'com.woltlab.wcf') {
-                       if (!empty($files)) {
-                               // get registered files of other packages for the
-                               // same application
-                               $conditions = new PreparedStatementConditionBuilder();
-                               $conditions->add('packageID <> ?', [$this->packageInstallation->getPackageID()]);
-                               $conditions->add('filename IN (?)', [$files]);
-                               $conditions->add('application = ?', [$this->application]);
-                               
-                               $sql = "SELECT  filename, packageID
-                                       FROM    wcf".WCF_N."_package_installation_file_log
-                                       ".$conditions;
-                               $statement = WCF::getDB()->prepareStatement($sql);
-                               $statement->execute($conditions->getParameters());
-                               $lockedFiles = $statement->fetchMap('filename', 'packageID');
-                               
-                               // check delivered files
-                               if (!empty($lockedFiles)) {
-                                       foreach ($files as $key => $file) {
-                                               if (isset($lockedFiles[$file])) {
-                                                       $owningPackage = new Package($lockedFiles[$file]);
-                                                       
-                                                       throw new SystemException("A package can't overwrite files from other packages. Only an update from the package which owns the file can do that. (Package '".$this->packageInstallation->getPackage()->package."' tries to overwrite file '".$file."', which is owned by package '".$owningPackage->package."')");
-                                               }
-                                       }
-                               }
-                       }
-               }
-       }
-       
-       /**
-        * @inheritDoc
-        */
-       public function logFiles(array $files) {
-               if (empty($files)) {
-                       return;
-               }
-               
-               $sql = "INSERT IGNORE INTO      wcf".WCF_N."_package_installation_file_log
-                                                       (packageID, filename, application)
-                               VALUES                  (?, ?, ?)";
-               $statement = WCF::getDB()->prepareStatement($sql);
-               
-               WCF::getDB()->beginTransaction();
-               foreach ($files as $file) {
-                       $statement->execute([
-                               $this->packageInstallation->getPackageID(),
-                               $file,
-                               $this->application
-                       ]);
-               }
-               WCF::getDB()->commitTransaction();
-       }
+class FilesFileHandler extends PackageInstallationFileHandler
+{
+    /**
+     * @inheritDoc
+     */
+    public function checkFiles(array $files)
+    {
+        if ($this->packageInstallation->getPackage()->package != 'com.woltlab.wcf') {
+            if (!empty($files)) {
+                // get registered files of other packages for the
+                // same application
+                $conditions = new PreparedStatementConditionBuilder();
+                $conditions->add('packageID <> ?', [$this->packageInstallation->getPackageID()]);
+                $conditions->add('filename IN (?)', [$files]);
+                $conditions->add('application = ?', [$this->application]);
+
+                $sql = "SELECT  filename, packageID
+                        FROM    wcf" . WCF_N . "_package_installation_file_log
+                        " . $conditions;
+                $statement = WCF::getDB()->prepareStatement($sql);
+                $statement->execute($conditions->getParameters());
+                $lockedFiles = $statement->fetchMap('filename', 'packageID');
+
+                // check delivered files
+                if (!empty($lockedFiles)) {
+                    foreach ($files as $file) {
+                        if (isset($lockedFiles[$file])) {
+                            $owningPackage = new Package($lockedFiles[$file]);
+
+                            throw new SystemException("A package can't overwrite files from other packages. Only an update from the package which owns the file can do that. (Package '" . $this->packageInstallation->getPackage()->package . "' tries to overwrite file '" . $file . "', which is owned by package '" . $owningPackage->package . "')");
+                        }
+                    }
+                }
+            }
+        }
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function logFiles(array $files)
+    {
+        if (empty($files)) {
+            return;
+        }
+
+        $sql = "INSERT IGNORE INTO  wcf" . WCF_N . "_package_installation_file_log
+                                    (packageID, filename, application)
+                VALUES              (?, ?, ?)";
+        $statement = WCF::getDB()->prepareStatement($sql);
+
+        WCF::getDB()->beginTransaction();
+        foreach ($files as $file) {
+            $statement->execute([
+                $this->packageInstallation->getPackageID(),
+                $file,
+                $this->application,
+            ]);
+        }
+        WCF::getDB()->commitTransaction();
+    }
 }