arm64: vdso: work-around broken ELF toolchains in Makefile
authorWill Deacon <will.deacon@arm.com>
Fri, 19 Jun 2015 12:56:33 +0000 (13:56 +0100)
committerDanny Wood <danwood76@gmail.com>
Tue, 29 Jan 2019 13:09:07 +0000 (13:09 +0000)
commit1ff339930432d189e35852bc35b557c0627a1270
tree6175d3cd58964374393765bacc126fb78daa3f4d
parent2b4255894c58a9ee376f259067d73eed9def8a2e
arm64: vdso: work-around broken ELF toolchains in Makefile

commit 6f1a6ae87c0c60d7c462ef8fd071f291aa7a9abb upstream.

When building the kernel with a bare-metal (ELF) toolchain, the -shared
option may not be passed down to collect2, resulting in silent corruption
of the vDSO image (in particular, the DYNAMIC section is omitted).

The effect of this corruption is that the dynamic linker fails to find
the vDSO symbols and libc is instead used for the syscalls that we
intended to optimise (e.g. gettimeofday). Functionally, there is no
issue as the sigreturn trampoline is still intact and located by the
kernel.

This patch fixes the problem by explicitly passing -shared to the linker
when building the vDSO.

Reported-by: Szabolcs Nagy <Szabolcs.Nagy@arm.com>
Reported-by: James Greenlaigh <james.greenhalgh@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/arm64/kernel/vdso/Makefile