ALSA: timer: Remove kernel warning at compat ioctl error paths
authorTakashi Iwai <tiwai@suse.de>
Tue, 21 Nov 2017 15:36:11 +0000 (16:36 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Nov 2017 08:40:48 +0000 (08:40 +0000)
commit6352ec905f914143ca80ea68b8cbf30f6ae27aa3
treeb182a183c8b43ec855e319e22f6fdd352815d699
parent47f25441ffcfb262b83ec8acc7d94eddc4727014
ALSA: timer: Remove kernel warning at compat ioctl error paths

commit 3d4e8303f2c747c8540a0a0126d0151514f6468b upstream.

Some timer compat ioctls have NULL checks of timer instance with
snd_BUG_ON() that bring up WARN_ON() when the debug option is set.
Actually the condition can be met in the normal situation and it's
confusing and bad to spew kernel warnings with stack trace there.
Let's remove snd_BUG_ON() invocation and replace with the simple
checks.  Also, correct the error code to EBADFD to follow the native
ioctl error handling.

Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/core/timer_compat.c