From fea72e74437fd62b1fa89cdbc278e34b6e0c9e38 Mon Sep 17 00:00:00 2001 From: Matthias Schmidt Date: Wed, 7 Feb 2018 20:09:13 +0100 Subject: [PATCH] Fix type documentation issues --- wcfsetup/install/files/lib/acp/form/RescueModeForm.class.php | 2 +- wcfsetup/install/files/lib/acp/page/UserListPage.class.php | 2 +- wcfsetup/install/files/lib/data/trophy/TrophyAction.class.php | 2 ++ .../cache/builder/CategoryACLOptionCacheBuilder.class.php | 2 ++ .../condition/AbstractObjectTextPropertyCondition.class.php | 1 + .../lib/system/message/quote/MessageQuoteManager.class.php | 2 +- .../system/package/PackageUninstallationDispatcher.class.php | 2 +- .../package/plugin/MenuPackageInstallationPlugin.class.php | 2 +- .../install/files/lib/system/request/ControllerMap.class.php | 4 ++-- wcfsetup/install/files/lib/system/setup/Uninstaller.class.php | 2 +- .../lib/system/template/TemplateScriptingCompiler.class.php | 2 +- .../event/UserFollowFollowingUserNotificationEvent.class.php | 1 - 12 files changed, 14 insertions(+), 10 deletions(-) diff --git a/wcfsetup/install/files/lib/acp/form/RescueModeForm.class.php b/wcfsetup/install/files/lib/acp/form/RescueModeForm.class.php index 6fef2ac1f8..c4c317d6c3 100644 --- a/wcfsetup/install/files/lib/acp/form/RescueModeForm.class.php +++ b/wcfsetup/install/files/lib/acp/form/RescueModeForm.class.php @@ -37,7 +37,7 @@ class RescueModeForm extends AbstractCaptchaForm { public $applications; /** - * @var string[] + * @var string[][] */ public $applicationValues = []; diff --git a/wcfsetup/install/files/lib/acp/page/UserListPage.class.php b/wcfsetup/install/files/lib/acp/page/UserListPage.class.php index 86d8bafaa2..78d5a78129 100755 --- a/wcfsetup/install/files/lib/acp/page/UserListPage.class.php +++ b/wcfsetup/install/files/lib/acp/page/UserListPage.class.php @@ -52,7 +52,7 @@ class UserListPage extends SortablePage { /** * list of column values - * @var string[] + * @var string[][] */ public $columnValues = []; diff --git a/wcfsetup/install/files/lib/data/trophy/TrophyAction.class.php b/wcfsetup/install/files/lib/data/trophy/TrophyAction.class.php index 98d1bfbc27..107dd0efd5 100644 --- a/wcfsetup/install/files/lib/data/trophy/TrophyAction.class.php +++ b/wcfsetup/install/files/lib/data/trophy/TrophyAction.class.php @@ -40,8 +40,10 @@ class TrophyAction extends AbstractDatabaseObjectAction implements IToggleAction /** * @inheritDoc + * @return Trophy */ public function create() { + /** @var Trophy $trophy */ $trophy = parent::create(); if (isset($this->parameters['tmpHash']) && $this->parameters['data']['type'] === Trophy::TYPE_IMAGE) { diff --git a/wcfsetup/install/files/lib/system/cache/builder/CategoryACLOptionCacheBuilder.class.php b/wcfsetup/install/files/lib/system/cache/builder/CategoryACLOptionCacheBuilder.class.php index 874e57cb9c..a264ed18de 100644 --- a/wcfsetup/install/files/lib/system/cache/builder/CategoryACLOptionCacheBuilder.class.php +++ b/wcfsetup/install/files/lib/system/cache/builder/CategoryACLOptionCacheBuilder.class.php @@ -1,5 +1,6 @@ getCategories() as $objectTypeName => $categories) { $objectType = CategoryHandler::getInstance()->getObjectTypeByName($objectTypeName); $aclObjectType = $objectType->getProcessor()->getObjectTypeName('com.woltlab.wcf.acl'); diff --git a/wcfsetup/install/files/lib/system/condition/AbstractObjectTextPropertyCondition.class.php b/wcfsetup/install/files/lib/system/condition/AbstractObjectTextPropertyCondition.class.php index c91836fffa..f9cdbedd05 100644 --- a/wcfsetup/install/files/lib/system/condition/AbstractObjectTextPropertyCondition.class.php +++ b/wcfsetup/install/files/lib/system/condition/AbstractObjectTextPropertyCondition.class.php @@ -111,6 +111,7 @@ abstract class AbstractObjectTextPropertyCondition extends AbstractTextCondition parent::setData($condition); if ($this->supportsMultipleValues) { + /** @noinspection PhpParamsInspection */ $this->fieldValue = implode(',', $this->fieldValue); } } diff --git a/wcfsetup/install/files/lib/system/message/quote/MessageQuoteManager.class.php b/wcfsetup/install/files/lib/system/message/quote/MessageQuoteManager.class.php index 7dcd009a74..4fa545a442 100644 --- a/wcfsetup/install/files/lib/system/message/quote/MessageQuoteManager.class.php +++ b/wcfsetup/install/files/lib/system/message/quote/MessageQuoteManager.class.php @@ -45,7 +45,7 @@ class MessageQuoteManager extends SingletonFactory { /** * list of quote messages by quote id - * @var string[] + * @var array */ protected $quoteData = []; diff --git a/wcfsetup/install/files/lib/system/package/PackageUninstallationDispatcher.class.php b/wcfsetup/install/files/lib/system/package/PackageUninstallationDispatcher.class.php index ff7ca2022b..d1334a1bf9 100644 --- a/wcfsetup/install/files/lib/system/package/PackageUninstallationDispatcher.class.php +++ b/wcfsetup/install/files/lib/system/package/PackageUninstallationDispatcher.class.php @@ -156,7 +156,7 @@ class PackageUninstallationDispatcher extends PackageInstallationDispatcher { * Deletes the given list of files from the target dir. * * @param string $targetDir - * @param string $files + * @param string[] $files * @param boolean $deleteEmptyDirectories * @param boolean $deleteEmptyTargetDir */ diff --git a/wcfsetup/install/files/lib/system/package/plugin/MenuPackageInstallationPlugin.class.php b/wcfsetup/install/files/lib/system/package/plugin/MenuPackageInstallationPlugin.class.php index a5d8762705..44d986f6b4 100644 --- a/wcfsetup/install/files/lib/system/package/plugin/MenuPackageInstallationPlugin.class.php +++ b/wcfsetup/install/files/lib/system/package/plugin/MenuPackageInstallationPlugin.class.php @@ -22,7 +22,7 @@ use wcf\system\WCF; class MenuPackageInstallationPlugin extends AbstractXMLPackageInstallationPlugin implements IIdempotentPackageInstallationPlugin { /** * box meta data per menu - * @var string[] + * @var array */ public $boxData = []; diff --git a/wcfsetup/install/files/lib/system/request/ControllerMap.class.php b/wcfsetup/install/files/lib/system/request/ControllerMap.class.php index 066c24d02e..2ba8fa195a 100644 --- a/wcfsetup/install/files/lib/system/request/ControllerMap.class.php +++ b/wcfsetup/install/files/lib/system/request/ControllerMap.class.php @@ -19,12 +19,12 @@ use wcf\system\WCFACP; */ class ControllerMap extends SingletonFactory { /** - * @var string[][] + * @var array */ protected $ciControllers; /** - * @var string[][] + * @var array */ protected $customUrls; diff --git a/wcfsetup/install/files/lib/system/setup/Uninstaller.class.php b/wcfsetup/install/files/lib/system/setup/Uninstaller.class.php index e9bcaa7348..9973a7750b 100644 --- a/wcfsetup/install/files/lib/system/setup/Uninstaller.class.php +++ b/wcfsetup/install/files/lib/system/setup/Uninstaller.class.php @@ -38,7 +38,7 @@ class Uninstaller { * Creates a new Uninstaller object. * * @param string $targetDir - * @param array $files + * @param string[] $files * @param boolean $deleteEmptyTargetDir * @param boolean $deleteEmptyDirectories */ diff --git a/wcfsetup/install/files/lib/system/template/TemplateScriptingCompiler.class.php b/wcfsetup/install/files/lib/system/template/TemplateScriptingCompiler.class.php index 6bd43c6fd2..ae47ce22de 100644 --- a/wcfsetup/install/files/lib/system/template/TemplateScriptingCompiler.class.php +++ b/wcfsetup/install/files/lib/system/template/TemplateScriptingCompiler.class.php @@ -166,7 +166,7 @@ class TemplateScriptingCompiler { /** * list of static includes per template - * @var string[] + * @var string[][] */ protected $staticIncludes = []; diff --git a/wcfsetup/install/files/lib/system/user/notification/event/UserFollowFollowingUserNotificationEvent.class.php b/wcfsetup/install/files/lib/system/user/notification/event/UserFollowFollowingUserNotificationEvent.class.php index 100f2eebd7..c56a73218c 100644 --- a/wcfsetup/install/files/lib/system/user/notification/event/UserFollowFollowingUserNotificationEvent.class.php +++ b/wcfsetup/install/files/lib/system/user/notification/event/UserFollowFollowingUserNotificationEvent.class.php @@ -102,7 +102,6 @@ class UserFollowFollowingUserNotificationEvent extends AbstractUserNotificationE /** * @inheritDoc - * @return UserFollowUserNotificationObject * @since 3.1 */ public static function getTestAdditionalData(IUserNotificationObject $object) { -- 2.20.1