From fe685b80469996149ca28c74062f72b5879c1607 Mon Sep 17 00:00:00 2001 From: "Jorge Boncompte [DTI2]" Date: Mon, 21 Nov 2011 10:25:54 +0000 Subject: [PATCH] atm: br2684: Do not move counters backwards This snippet has caused several bugs in the past, and I don't see the point on substracting the skb len from netdev stats. Signed-off-by: Jorge Boncompte [DTI2] Signed-off-by: David S. Miller --- net/atm/br2684.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/net/atm/br2684.c b/net/atm/br2684.c index d07223c834af..81cf33b1527d 100644 --- a/net/atm/br2684.c +++ b/net/atm/br2684.c @@ -557,15 +557,8 @@ static int br2684_regvcc(struct atm_vcc *atmvcc, void __user * arg) skb_queue_splice_init(rq, &queue); spin_unlock_irqrestore(&rq->lock, flags); - skb_queue_walk_safe(&queue, skb, tmp) { - struct net_device *dev; - + skb_queue_walk_safe(&queue, skb, tmp) br2684_push(atmvcc, skb); - dev = skb->dev; - - dev->stats.rx_bytes -= skb->len; - dev->stats.rx_packets--; - } /* initialize netdev carrier state */ if (atmvcc->dev->signal == ATM_PHY_SIG_LOST) -- 2.20.1