From fdf2c2e4ff14dab7648e7d4431e10c0c18df2ff8 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Thu, 24 Mar 2022 08:52:07 +0300 Subject: [PATCH] lib/test: use after free in register_test_dev_kmod() [ Upstream commit dc0ce6cc4b133f5f2beb8b47dacae13a7d283c2c ] The "test_dev" pointer is freed but then returned to the caller. Fixes: d9c6a72d6fa2 ("kmod: add test driver to stress test the module loader") Signed-off-by: Dan Carpenter Signed-off-by: Luis Chamberlain Signed-off-by: Sasha Levin --- lib/test_kmod.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/test_kmod.c b/lib/test_kmod.c index c0ce0156d54b..74f8d386f85e 100644 --- a/lib/test_kmod.c +++ b/lib/test_kmod.c @@ -1162,6 +1162,7 @@ static struct kmod_test_device *register_test_dev_kmod(void) if (ret) { pr_err("could not register misc device: %d\n", ret); free_test_dev_kmod(test_dev); + test_dev = NULL; goto out; } -- 2.20.1