From fc6a82a2a496f2e71d77d8515e84790fc6b45422 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Tim=20D=C3=BCsterhus?= <duesterhus@woltlab.com>
Date: Wed, 22 Sep 2021 10:36:53 +0200
Subject: [PATCH] Remove add() and update() from ISearchIndexManager

These methods are long-deprecated, remove them from the interface to not force
search engine authors to implement these.

It is expected that code consuming the search API uses the `SearchIndexManager`
class instead of directly accessing a specific `*SearchIndexManager`. The
`SearchIndexManager` only uses `->set()` on the underlying actual
`*SearchIndexManager`. Thus no compatibility break is expected.
---
 .../search/ISearchIndexManager.class.php      | 52 -------------------
 .../search/SearchIndexManager.class.php       |  2 -
 2 files changed, 54 deletions(-)

diff --git a/wcfsetup/install/files/lib/system/search/ISearchIndexManager.class.php b/wcfsetup/install/files/lib/system/search/ISearchIndexManager.class.php
index 8c4fc52fa1..38b645fc4a 100644
--- a/wcfsetup/install/files/lib/system/search/ISearchIndexManager.class.php
+++ b/wcfsetup/install/files/lib/system/search/ISearchIndexManager.class.php
@@ -37,58 +37,6 @@ interface ISearchIndexManager
         $metaData = ''
     );
 
-    /**
-     * Adds a new entry.
-     *
-     * @param string $objectType
-     * @param int $objectID
-     * @param string $message
-     * @param string $subject
-     * @param int $time
-     * @param int $userID
-     * @param string $username
-     * @param int $languageID
-     * @param string $metaData
-     * @deprecated  3.0 - please use `set()` instead
-     */
-    public function add(
-        $objectType,
-        $objectID,
-        $message,
-        $subject,
-        $time,
-        $userID,
-        $username,
-        $languageID = null,
-        $metaData = ''
-    );
-
-    /**
-     * Updates the search index.
-     *
-     * @param string $objectType
-     * @param int $objectID
-     * @param string $message
-     * @param string $subject
-     * @param int $time
-     * @param int $userID
-     * @param string $username
-     * @param int $languageID
-     * @param string $metaData
-     * @deprecated  3.0 - please use `set() instead`
-     */
-    public function update(
-        $objectType,
-        $objectID,
-        $message,
-        $subject,
-        $time,
-        $userID,
-        $username,
-        $languageID = null,
-        $metaData = ''
-    );
-
     /**
      * Deletes search index entries.
      *
diff --git a/wcfsetup/install/files/lib/system/search/SearchIndexManager.class.php b/wcfsetup/install/files/lib/system/search/SearchIndexManager.class.php
index ca72ebe301..4c51d7afa1 100644
--- a/wcfsetup/install/files/lib/system/search/SearchIndexManager.class.php
+++ b/wcfsetup/install/files/lib/system/search/SearchIndexManager.class.php
@@ -130,7 +130,6 @@ class SearchIndexManager extends SingletonFactory implements ISearchIndexManager
     }
 
     /**
-     * @inheritDoc
      * @deprecated  3.0 - please use `set() instead`
      */
     public function add(
@@ -148,7 +147,6 @@ class SearchIndexManager extends SingletonFactory implements ISearchIndexManager
     }
 
     /**
-     * @inheritDoc
      * @deprecated  3.0 - please use `set() instead`
      */
     public function update(
-- 
2.20.1