From fa9a89fc6637958594f285c8466422105e86e28c Mon Sep 17 00:00:00 2001 From: Jay Freyensee Date: Wed, 20 Jul 2016 21:26:16 -0600 Subject: [PATCH] nvme: initialize variable before logical OR'ing it It is typically not good coding or secure coding practice to logical OR a variable without an initialization value first. Here on this line: integrity.flags |= BLK_INTEGRITY_DEVICE_CAPABLE; BLK_INTEGRITY_DEVICE_CAPABLE is being OR'ed to a member variable never set to an initial value. This patch fixes that. Signed-off-by: Jay Freyensee Reviewed-by: Ming Lin Reviewed-by: Sagi Grimberg Reviewed-by: Christoph Hellwig Signed-off-by: Jens Axboe --- drivers/nvme/host/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 9f0ec3b4659f..74b1d380dd42 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -842,6 +842,7 @@ static void nvme_init_integrity(struct nvme_ns *ns) { struct blk_integrity integrity; + memset(&integrity, 0, sizeof(integrity)); switch (ns->pi_type) { case NVME_NS_DPS_PI_TYPE3: integrity.profile = &t10_pi_type3_crc; -- 2.20.1