From fa4154601eac75216a2229e5e20855c24629d3a4 Mon Sep 17 00:00:00 2001 From: Matthias Schmidt Date: Fri, 6 Nov 2020 14:45:07 +0100 Subject: [PATCH] Fix storing ids in `Ui/Dialog` elements See b6b1bdd4461e8a841b3d0aff02043aef5acceb3a --- wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Dialog.js | 2 +- wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/Dialog.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Dialog.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Dialog.js index 01ed6e661c..5d881c2d04 100644 --- a/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Dialog.js +++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Dialog.js @@ -290,7 +290,7 @@ define(["require", "exports", "tslib", "../Core", "../Dom/Change/Listener", "./S dialog.classList.add("dialogContainer"); dialog.setAttribute("aria-hidden", "true"); dialog.setAttribute("role", "dialog"); - dialog.id = id; + dialog.dataset.id = id; const header = document.createElement("header"); dialog.appendChild(header); const titleId = Util_1.default.getUniqueId(); diff --git a/wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/Dialog.ts b/wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/Dialog.ts index 203e47488d..f7bbd73031 100644 --- a/wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/Dialog.ts +++ b/wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/Dialog.ts @@ -348,7 +348,7 @@ const UiDialog = { dialog.classList.add("dialogContainer"); dialog.setAttribute("aria-hidden", "true"); dialog.setAttribute("role", "dialog"); - dialog.id = id; + dialog.dataset.id = id; const header = document.createElement("header"); dialog.appendChild(header); -- 2.20.1