From fa254c0b1864ed1495c503261644f4b748076554 Mon Sep 17 00:00:00 2001 From: Alexander Ebert Date: Thu, 5 Oct 2023 18:09:02 +0200 Subject: [PATCH] Rename `getId()` to `getElementID()` MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The naming is more in line with the PHP API and makes it clear that this is not the label group’s id. --- wcfsetup/install/files/acp/templates/articleAdd.tpl | 2 +- wcfsetup/install/files/lib/system/label/LabelPicker.class.php | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/wcfsetup/install/files/acp/templates/articleAdd.tpl b/wcfsetup/install/files/acp/templates/articleAdd.tpl index 08422a3737..d9e999885e 100644 --- a/wcfsetup/install/files/acp/templates/articleAdd.tpl +++ b/wcfsetup/install/files/acp/templates/articleAdd.tpl @@ -171,7 +171,7 @@ {foreach from=$labelPickers item=labelPicker}
-
+
{@$labelPicker->toHtml()} {if $errorField == 'label' && $errorType[$labelPicker->labelGroup->groupID]|isset} diff --git a/wcfsetup/install/files/lib/system/label/LabelPicker.class.php b/wcfsetup/install/files/lib/system/label/LabelPicker.class.php index 75ebcfc197..60322c603a 100644 --- a/wcfsetup/install/files/lib/system/label/LabelPicker.class.php +++ b/wcfsetup/install/files/lib/system/label/LabelPicker.class.php @@ -35,14 +35,14 @@ final class LabelPicker > EOT, $this->selected, - $this->getId(), + $this->getElementID(), $this->labelGroup->getTitle(), StringUtil::encodeHTML(JSON::encode($labels)), $this->labelGroup->groupID, ); } - public function getId(): string + public function getElementID(): string { return "labelGroup{$this->labelGroup->groupID}"; } -- 2.20.1