From f7099ad7bd35c56795fb50f5026b7040abac62da Mon Sep 17 00:00:00 2001 From: Rakhi Sharma Date: Sat, 13 Feb 2016 10:54:20 +0530 Subject: [PATCH] staging: rtl8712: Fixed a comparision coding style warning. WARNING: Comparisons should place the constant on the right side of the test Fixed this warning by placing the constant on right side. Signed-off-by: Rakhi Sharma - Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8712/rtl8712_efuse.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c b/drivers/staging/rtl8712/rtl8712_efuse.c index eaa93fbb95a3..76f60ba5ee9b 100644 --- a/drivers/staging/rtl8712/rtl8712_efuse.c +++ b/drivers/staging/rtl8712/rtl8712_efuse.c @@ -161,7 +161,7 @@ static u8 efuse_is_empty(struct _adapter *padapter, u8 *empty) /* read one byte to check if E-Fuse is empty */ if (efuse_one_byte_rw(padapter, true, 0, &value)) { - if (0xFF == value) + if (value == 0xFF) *empty = true; else *empty = false; @@ -345,7 +345,7 @@ static u8 fix_header(struct _adapter *padapter, u8 header, u16 header_addr) ret = false; } else if (pkt.data[i * 2] != value) { ret = false; - if (0xFF == value) /* write again */ + if (value == 0xFF) /* write again */ efuse_one_byte_write(padapter, addr, pkt.data[i * 2]); } @@ -353,7 +353,7 @@ static u8 fix_header(struct _adapter *padapter, u8 header, u16 header_addr) ret = false; } else if (pkt.data[i * 2 + 1] != value) { ret = false; - if (0xFF == value) /* write again */ + if (value == 0xFF) /* write again */ efuse_one_byte_write(padapter, addr + 1, pkt.data[i * 2 + 1]); @@ -420,7 +420,7 @@ u8 r8712_efuse_pg_packet_write(struct _adapter *padapter, const u8 offset, } /* write header fail */ bResult = false; - if (0xFF == efuse_data) + if (efuse_data == 0xFF) return bResult; /* nothing damaged. */ /* call rescue procedure */ if (!fix_header(padapter, efuse_data, efuse_addr)) -- 2.20.1